Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: Add return type hints for models#3382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
DjVinnii wants to merge1 commit intoMailu:master
base:master
Choose a base branch
Loading
fromDjVinnii:chore/type-hints

Conversation

@DjVinnii
Copy link
Contributor

What type of PR?

Enhancement

What does this PR do?

Add return type hints for the models.

Type hinting in Python helps with the readability of the code as well as better IDE support. However, due to the nature of Python it is not enforcing the types as Python is not a type safe language.

@mergify
Copy link
Contributor

mergifybot commentedAug 25, 2024

Thanks for submitting this pull request.
Bors-ng will now build test images. When it succeeds, we will continue to review and test your PR.

bors try

Note: if this build fails,read this.

bors-mailubot added a commit that referenced this pull requestAug 25, 2024
@DjVinniiDjVinnii changed the titlechore: Add return type hintschore: Add return type hints for modelsAug 25, 2024
@DjVinnii
Copy link
ContributorAuthor

Btw, I'd like to open more PRs to add type hinting but will make sure it will be in smaller chunks to keep it easier to review.

boralp reacted with thumbs up emoji

@bors-mailu
Copy link
Contributor

try

Build succeeded:

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DjVinnii
[8]ページ先頭
©2009-2025 Movatter.jp