Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: added babel transform-object-assign to fix IE support#255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Pwntastic wants to merge1 commit intoLogRocket:master
base:master
Choose a base branch
Loading
fromPwntastic:transform-object-assign

Conversation

@Pwntastic
Copy link

Using native Object.assign was breaking IE support, so I pulled inbabel-plugin-transform-object-assign to add in a polyfill when necessary.

Also the linter was complaining about the quotes aroundTRACE so I fixed that too.

Izumi-kun, adipascu, and oliviertassinari reacted with thumbs up emoji
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@539dab5).Click here to learn what that means.
The diff coverage is0%.

Impacted file tree graph

@@           Coverage Diff           @@##             master   #255   +/-   ##=======================================  Coverage          ?    82%           =======================================  Files             ?      5             Lines             ?    150             Branches          ?      0           =======================================  Hits              ?    123             Misses            ?     27             Partials          ?      0
Impacted FilesCoverage Δ
src/core.js73.33% <0%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update539dab5...bc923ec. Read thecomment docs.

@cyberhck
Copy link

what's going on with this one? why is this PR not merged?

@Pwntastic
Copy link
Author

Is there anything that I specifically need to do?

@cyberhck
Copy link

cyberhck commentedSep 28, 2017•
edited
Loading

it almost looks like author of this repo didn't even look at this PR 😄

BTW to make tests pass, you need to ADD some tests, reason those are failing is because redux-logger doesn't have enough test coverage.

@z-vr
Copy link

just spent an hour figuring it out, can this be merged please.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Pwntastic@codecov-io@cyberhck@z-vr
[8]ページ先頭
©2009-2025 Movatter.jp