- Notifications
You must be signed in to change notification settings - Fork317
Extended diff option to allow for a custom differ function#241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecov-io commentedJun 9, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov Report
@@ Coverage Diff @@## master #241 +/- ##==========================================+ Coverage 83.56% 83.78% +0.22%========================================== Files 5 5 Lines 146 148 +2 ==========================================+ Hits 122 124 +2 Misses 24 24
Continue to review full report at Codecov.
|
src/diff.js Outdated
| exportdefaultfunctiondiffLogger(prevState,newState,logger,isCollapsed){ | ||
| constdiff=differ(prevState,newState); | ||
| exportdefaultfunctiondiffLogger(prevState,newState,logger,isCollapsed,customDiffer){ | ||
| constdiff=(customDiffer||differ)(prevState,newState); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Maybe you could usedefault paremeters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@thiamsantos Yeah that makes sense ->b1f3281
I use Immutable.js alongside anImmutable.js Object Formatter Chrome Extension, and it would be great to be able to use a custom differ instead of needing to convert everything via the
stateTransformeroption.