NotificationsYou must be signed in to change notification settings
Fork317
Star5.7k

Refactor index.js & add more tests#223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

mfeniseycopes wants to merge5 commits intoLogRocket:master

base:master

Choose a base branch

frommfeniseycopes:refactor

Open

Refactor index.js & add more tests#223

mfeniseycopes wants to merge5 commits intoLogRocket:masterfrommfeniseycopes:refactor

Conversation

Copy link

mfeniseycopes commentedApr 16, 2017

Refactorsindex.js to utilize more helper methods and make code more semantic. No changes in logic or naming conventions, just shifting things around. Also, moves early returns to the top of createLogger to prevent unnecessary assignments and variable creation.

Also, adds more specs toindex.spec.js (still needs more though) and moves helper tests tohelpers.spec.js.

Let me know what you think!

Copy link

codecov-io commentedApr 16, 2017•
edited
Loading

Codecov Report

Merging#223 intomaster willdecrease coverage by14.21%.
The diff coverage is89.28%.

@@             Coverage Diff             @@##           master     #223       +/-   ##===========================================- Coverage   83.56%   69.34%   -14.22%===========================================  Files           5        5                 Lines         146      137        -9     ===========================================- Hits          122       95       -27- Misses         24       42       +18

Impacted Files	Coverage Δ
src/index.js	`89.74% <89.28%> (+2.9%)`	⬆️
src/diff.js	`8% <0%> (-92%)`	⬇️
src/core.js	`78.68% <0%> (+2.63%)`	⬆️

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update07cb031...ace19b8. Read thecomment docs.