Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Automatically update pkgver using makepkg#24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
j-waters wants to merge1 commit intoKSXGitHub:master
base:master
Choose a base branch
Loading
fromj-waters:update-pkgver

Conversation

@j-waters
Copy link

If apkgver() function exists, the PKGBUILD file will be copied into a new temporary directory,makepkg -od will be run, and then the new PKGBUILD file will be the one that is copied into the aur repo.

makepkg -od:

  • -o skips building, but still runspkgver()
  • -d skips dependency checks, which is fine as long as no dependencies (other than git) are used in thepkgver() function

@j-watersj-watersforce-pushed theupdate-pkgver branch 2 times, most recently from9988ac9 toe6f7194CompareAugust 30, 2021 00:59
@KSXGitHub
Copy link
Owner

It seems that you're busy. Notify me by@ mention when you're done.

@j-watersj-watersforce-pushed theupdate-pkgver branch 2 times, most recently frombc58083 to8befa3bCompareAugust 30, 2021 01:11
@yuezk
Copy link

Hi@KSXGitHub Is it ready to merge this PR?

Comment on lines +63 to +64
cd /tmp/makepkg;
makepkg -od;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

; is unnecessary.

if ["$update_pkgver"="true" ];then
echo'::group::Updating pkgver'
echo'Running `makepkg -od` to update pkgver'
mkdir -p /tmp/makepkg
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

There's a command calledmktemp that always exists (provided by thecoreutils package). It is better to use that thanmkdir -p /tmp/makepkg.

@yuezk
Copy link

@KSXGitHub I submitted another PR (#26) for updating thepkgver, it will work with the case where thePKGBUILD depends on the local source code tarballs in the package repository. Please also take a look. Thanks.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@KSXGitHubKSXGitHubKSXGitHub requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@j-waters@KSXGitHub@yuezk
[8]ページ先頭
©2009-2025 Movatter.jp