- Notifications
You must be signed in to change notification settings - Fork74
Expand PCA sizes#191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
david-cortes-intel wants to merge2 commits intoIntelPython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Expand PCA sizes#191
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ContributorAuthor
david-cortes-intel commentedOct 28, 2025
CI errors should be fixed once this PR is merged in sklearnex:uxlfoundation/scikit-learn-intelex#2741 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR expands the sizes of the synthetic datasets used to benchmark PCA.
Currently, these cases involve 3 components, in many cases out of thousands of features, which is not a representative application and thus not a good candidate for benchmarking. The PR expands those to 20 which is more reasonable.
It also makes the synthetic datasets wider (=more columns) and shorter (=fewer rows) as large-scale PCA is for the most part meant to be applied to wide datasets, and substantially increases the sizes of the inputs for
.transform()as the benchmarks for those cases are very short.Note that this PR might increase the time it takes to execute a benchmark run, especially from the data generation step. I do not know how much the timings will change if this is merged.
Checklist:
Completeness and readability
Testing