- Notifications
You must be signed in to change notification settings - Fork74
Code quality improvement#173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
marcialouis wants to merge6 commits intoIntelPython:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
+23 −8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Updating code from the main repo
… and Unresolved comment '# TODO: add float values'. lines of code = 1
Fixes in Unresolved comment '# TODO: remove placeholding zeroed y' and Fixes in Unresolved comment '# TODO: add float values'.
…ce unix time in ms with datetime'.
- Updated to include additional information (, , and ) in the benchmark results.- Ensured that the dictionary is updated with the new fields and metrics.- Modified to handle and process the new data descriptors in the benchmark results.These changes enhance the benchmark results by providing more detailed information about the dataset and its characteristics
Changes for datetime representation Unresolved comment '# TODO: replace unix time in ms with datetime'.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a comprehensive description of proposed changes
List associated issue number(s) if exist(s):#6 (for example)
Documentation PR (if needed): #1340 (for example)
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
Checklist to comply withbefore moving PR from draft:
PR completeness and readability
Testing