- Notifications
You must be signed in to change notification settings - Fork74
Add EMON, VTune, psrecord, ITTpy support in benchmarks#115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
943c545 tofb5575fComparefb5575f to1b80bd8Compare| deftime_box_filter(func,*args,n_meas,time_limit,**kwargs): | ||
| defdetect_LLC_size(): | ||
| withopen('/sys/devices/system/cpu/cpu0/cache/index3/size','r')asf: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Add support for all systems or exception for non-Linux
| print('# Intel(R) Extension for Scikit-learn case result:') | ||
| print(json.dumps(output,indent=4)) | ||
| print('# Intel(R) Extension for Scikit-learn case finished.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
sklbench may not use sklearnex, so, this outputs will be confusing for some cases
| ################################################################################## | ||
| #ruby interpreter, change it according to the path where ruby is installed in your system | ||
| #RUBY_PATH="c:\Ruby192\bin\ruby.exe" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are these commented lines required to be included?
| fit_time,_=bench.measure_function_time(regr.fit,X_train,y_train,box_filter_measurements=params.box_filter_measurements_fit,time_limit=params.time_limit_fit,params=params,stage='fit') | ||
| # Time predict | ||
| predict_time,yp=bench.measure_function_time(regr.predict,X_test,params=params) | ||
| predict_time,yp=bench.measure_function_time(regr.predict,X_test,box_filter_measurements=params.box_filter_measurements_infer,time_limit=params.time_limit_infer,params=params,stage='infer') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why only ridge regression includesbox_filter_measurements,time_limit andparams arguments?
| common_params=config['common'] | ||
| forparams_setinconfig['cases']: | ||
| params=common_params.copy() | ||
| # print('PRE PARAMS:', params) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Remove commented code
| #RUBY_OPTIONS=--server -J-Xmx5g -J-Xms5g --1.8 | ||
| #Number of threads to process data in parallel. Typically it should equal to the number of logical CPUs in your processing system. | ||
| PARALLELISM=24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Avoid hardcoded number of threads
| # Time fit | ||
| time,_=bench.measure_function_time(dbscan.fit,X,params=params) | ||
| time,_=bench.measure_function_time(dbscan.fit,X,params=params,stage='fit') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Try to alignstage andstages arguments ofbench.measure_function_time andbench.print_output if possible
| analysis_stage_collection= ['default'] | ||
| ifanalysis_prefix!=None: | ||
| analysis_stage_collection.extend(['fit','infer']) | ||
| foranalysis_stageinanalysis_stage_collection: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Check that non-measured stage is not included in single benchmark output
| defflush_caches(): | ||
| flush_datafile='data/flush_data.npy' | ||
| ifos.path.exists(flush_datafile): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You can add a check to see if the file is in datasets_root
| try: | ||
| importitt | ||
| itt_module_installed=True | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| except: | |
| exceptImportError: |
| iterations_to_flush=3 | ||
| try: | ||
| fromsklearnex.clusterimportKMeans | ||
| except: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| except: | |
| exceptImportError: |
| ifkeyinanalysis_config.keys(): | ||
| args=dict_to_cmd_args(analysis_config[key]) | ||
| returnargs | ||
| else: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
What condition does thiselse belong to?
Same for the 107 line
No description provided.