This repository was archived by the owner on Mar 28, 2019. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork0
Formik based form samples#1
Open
reinhard wants to merge29 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Error handling
| // see https://github.com/jaredpalmer/formik/issues/288 | ||
| const {user, setErrors} = action | ||
| if (user.name.startsWith('G')) { | ||
| setErrors({name: 'Names starting with \'G\' are not allowed.'}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@reinhard Why not check this directly in Form usingname: yup.string().matches(insertRegexHere).required()?
If this is an example for server side errors: I think these should be treated the "normal" redux way, meaning an FORMS_POST_USER_ERROR action is thrown and reducer saves userPostError.
This userPostRestError may be injected to UserForm and used as "external" error to be added to internal formik errors like
constUserForm=({user, onSubmit, restError}:Props)=>{return(<Formikkey={user.id+user.lastModified.toString()}displayName="UserForm"onSubmit={(values,{setErrors})=>onSubmit(values,setErrors)}initialValues={user}validateOnChange={false}validationSchema={validationSchema}render={({values, errors, touched, setErrors})=>{if(restError){// setErrors(..add external restErrors if present)}return(<Form><FormRowname="name"label="Name"errors={errors}touched={touched}/><FormRowname="email"label="E-Mail"errors={errors}touched={touched}/><AddressesFormvalues={values}errors={errors}touched={touched}/><Boxmt={2}><ButtonLink><Linkto="/forms">Cancel</Link></ButtonLink><buttontype="submit">Save</button> // or render "general" rest errors like "internal server error" without binding to a field{(restError)&&<div> Error saving user:{restError}</Box></Form>)}}/>)}
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.