Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix(tabs): replace igx-icon with igc-icon in WC demo + fix theme parameters - 20.1.x#16416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
adrianptrv wants to merge3 commits into20.1.x
base:20.1.x
Choose a base branch
Loading
fromapetrov/fix-tabs-demo-icon-20.1.x

Conversation

@adrianptrv
Copy link
Contributor

Closes1915
Related WC PR:#1929

  • Replacedigx-icon withigc-icon in the WC Tabs demo.
  • Fixed the$border-radius theme parameter so it works correctly.
  • Updated$item-background to apply only to Tab items instead of both Tab items and the Tab Header.

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includesfeature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the rootREADME.MD
  • This PR includesCHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includesng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@desig9stein
Copy link
Contributor

THEME: INDIGO
It looks like item-active-background is not used anywhere in the Indigo theme. Its current value also seems incorrect: when I apply it in the expected place, it renders as transparent. I believe it should use the same color as the item-hover-background, since that’s what is currently used in that state.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@simeonoffsimeonoffAwaiting requested review from simeonoff

At least 1 approving review is required to merge this pull request.

Assignees

@desig9steindesig9stein

Labels

demosstylingtabs❌ status: awaiting-testPRs awaiting manual verification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adrianptrv@desig9stein

[8]ページ先頭

©2009-2025 Movatter.jp