Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Portable Ruby 3.4.8#21265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
p-linnane merged 2 commits intomainfromportable-ruby-3.4.8
Dec 17, 2025
Merged

Portable Ruby 3.4.8#21265

p-linnane merged 2 commits intomainfromportable-ruby-3.4.8
Dec 17, 2025

Conversation

@p-linnane
Copy link
Member

  • Have you followed the guidelines in ourContributing document?
  • Have you checked to ensure there aren't other openPull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?Here's an example.
  • Have you successfully runbrew lgtm (style, typechecking and tests) with your changes locally?

Bootsnap 1.19.0removed CompileCache::JSON. Removing this fixesBootsnap.setup 'compile_cache_json' argument is deprecated and has no effect.

brew vendor-gems needed an additionalrequire to handleError: uninitialized constant Homebrew::DevCmd::VendorGems::GitHub.

Signed-off-by: Patrick Linnane <patrick@linnane.io>
CopilotAI review requested due to automatic review settingsDecember 17, 2025 04:31
Copy link
Contributor

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull request overview

This PR updates Homebrew's portable Ruby from version 3.4.7 to 3.4.8 and fixes two related issues: removing a deprecated Bootsnap configuration option and adding a missing require statement. The Ruby version update is reflected consistently across all configuration files and portable Ruby distributions for all supported platforms.

Key Changes

  • Updates portable Ruby from 3.4.7 to 3.4.8 across all platforms (x86_64/arm64 for Linux/Darwin)
  • Removes deprecatedcompile_cache_json parameter from Bootsnap configuration
  • Adds missingrequire "utils/github" to vendor-gems.rb to fix uninitialized constant error

Reviewed changes

Copilot reviewed 3 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
FileDescription
Library/Homebrew/vendor/portable-ruby-versionUpdates portable Ruby version from 3.4.7 to 3.4.8
Library/Homebrew/vendor/portable-ruby-x86_64-linuxUpdates SHA hash for x86_64 Linux portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-x86_64-darwinUpdates SHA hash for x86_64 Darwin portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-arm64-linuxUpdates SHA hash for arm64 Linux portable Ruby distribution
Library/Homebrew/vendor/portable-ruby-arm64-darwinUpdates SHA hash for arm64 Darwin portable Ruby distribution
Library/Homebrew/.ruby-versionUpdates Ruby version from 3.4.7 to 3.4.8
Library/Homebrew/Gemfile.lockUpdates Ruby version from 3.4.7p58 to 3.4.8p72
Library/Homebrew/startup/bootsnap.rbRemoves deprecatedcompile_cache_json option from Bootsnap.setup call
Library/Homebrew/dev-cmd/vendor-gems.rbAdds missing require for utils/github to fix GitHub constant error

💡Add Copilot custom instructions for smarter, more guided reviews.Learn how to get started.

@p-linnane
Copy link
MemberAuthor

Just need to wait for a new version ofsetup-ruby.

Copy link
Member

@MikeMcQuaidMikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@p-linnane! Good to merge when 🟢

Signed-off-by: Patrick Linnane <patrick@linnane.io>
@p-linnanep-linnane added this pull request to themerge queueDec 17, 2025
Merged via the queue intomain with commit8e96d6fDec 17, 2025
38 checks passed
@p-linnanep-linnane deleted the portable-ruby-3.4.8 branchDecember 17, 2025 16:54
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

Copilot code reviewCopilotCopilot left review comments

@MikeMcQuaidMikeMcQuaidMikeMcQuaid approved these changes

@carlocabcarlocabcarlocab approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@p-linnane@MikeMcQuaid@carlocab

[8]ページ先頭

©2009-2025 Movatter.jp