Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: Add AppImage support for Linux Casksfeat: add appimage support for linux#21225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
biplavbarua wants to merge5 commits intoHomebrew:main
base:main
Choose a base branch
Loading
frombiplavbarua:feat/cask/appimage

Conversation

@biplavbarua
Copy link

Description

This PR adds support forappimage artifacts in Casks, primarily for Linux support.

Changes

  • AddedCask::Artifact::AppImage class.
  • Addedappimagedir configuration (defaults to~/Applications).
  • Added tests for AppImage artifact.
  • Fixed test helper to includeappimagedir.
  • Overriddendsl_key to ensureappimage stanza works correctly.

Testing

  • brew tests --only=cask/artifact/appimage passes.- [ ] Have you followed the guidelines in ourContributing document?
  • Have you checked to ensure there aren't other openPull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes?Here's an example.
  • Have you successfully runbrew lgtm (style, typechecking and tests) with your changes locally?

@biplavbaruabiplavbaruaforce-pushed thefeat/cask/appimage branch 3 times, most recently from5370783 to9d01204CompareDecember 13, 2025 12:36
@SMillerDev
Copy link
Member

If these are just my changes this will break cask CI because I had only half an attempt to make Linux only and partial arch requirement installs work.

@biplavbarua
Copy link
Author

Hi! Thanks for the heads up.

I've actually built upon your initial work and fixed the issues to get the CI passing.

Specifically, I:

  1. Added the missing dsl_key override so AppImages are correctly detected.
  2. Fixed the Sorbet/Typecheck errors (including the strictinstance_variable_get issues in the installer).
  3. Added a new test suite (appimage_spec.rb).

The CI checks are currently all green ✅.

@SMillerDev
Copy link
Member

None of those are the issue. The issue is that since there are essentially no Appimages that support ARM, the cask CI needs to be able to support selective architecture selections.

That part is currently not working, and needs more testing and coding. It should also probably be split out from this PR, since it's blocking a flutter PR in the cask repo.

Copy link
Member

@SMillerDevSMillerDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The problem isn't that appimages need special handling though. They problem is that if you define an architecture requirement in an on_linux block, the CI matrix builder does not honor it.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@SMillerDevSMillerDevSMillerDev left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@biplavbarua@SMillerDev
[8]ページ先頭
©2009-2025 Movatter.jp