- Notifications
You must be signed in to change notification settings - Fork30
[Enhancement]HiFi feature implementation#975
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
ipavlidakis wants to merge5 commits intodevelopChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
9484432 to4561d95Compare
Generated by 🚫Danger |
e20ea43 todade6d4Compare# Conflicts:#Sources/StreamVideo/Utils/Store/StoreTask.swift
eb2eb3b to283a24aCompare
Public Interfacepublic struct StatelessMicrophoneIconView: View- @MainActor public init(call: Call?,callSettings: CallSettings = .init(),size: CGFloat = 44,controlStyle: ToggleControlStyle = .init(+ @MainActor public init(call: Call?,callSettings: CallSettings = .default,size: CGFloat = 44,controlStyle: ToggleControlStyle = .init( public final class MicrophoneManager: ObservableObject, CallSettingsManager, @unchecked Sendable- public func toggle()async throws+ public func toggle(file: StaticString = #file,function: StaticString = #function,line: UInt = #line)async throws- public func enable()async throws+ public func enable(file: StaticString = #file,function: StaticString = #function,line: UInt = #line)async throws- public func disable()async throws+ public func disable(file: StaticString = #file,function: StaticString = #function,line: UInt = #line)async throws public struct StatelessVideoIconView: View- public init(call: Call?,callSettings: CallSettings = .init(),size: CGFloat = 44,controlStyle: ToggleControlStyle = .init(+ public init(call: Call?,callSettings: CallSettings = .default,size: CGFloat = 44,controlStyle: ToggleControlStyle = .init( @MainActor public class CallState: ObservableObject- @Published public internal var callSettings+ @Published public internal var callSettings: CallSettings public final class CallSettings: ObservableObject, Sendable, Equatable, CustomStringConvertible- public let audioOn: Bool+ public static let `default`- public let videoOn: Bool+ public let audioOn: Bool- public let speakerOn: Bool+ public let videoOn: Bool- public let audioOutputOn: Bool+ public let speakerOn: Bool- public let cameraPosition: CameraPosition+ public let audioOutputOn: Bool- public var shouldPublish: Bool+ public let cameraPosition: CameraPosition- public var description: String+ public var shouldPublish: Bool-+ public var description: String-+- public convenience init(_ response: CallSettingsResponse,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)+- public init(audioOn: Bool = true,videoOn: Bool = true,speakerOn: Bool = true,audioOutputOn: Bool = true,cameraPosition: CameraPosition = .front,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)+ public convenience init(_ response: CallSettingsResponse,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-+ public init(audioOn: Bool = true,videoOn: Bool = true,speakerOn: Bool = true,audioOutputOn: Bool = true,cameraPosition: CameraPosition = .front,file: StaticString = #file,function: StaticString = #function,line: UInt = #line)-+- public static func ==(lhs: CallSettings,rhs: CallSettings)-> Bool++ public static func ==(lhs: CallSettings,rhs: CallSettings)-> Bool |
SDK Size
|
StreamVideo XCSize
Show 75 more objects
|
StreamVideoSwiftUI XCSize
|
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔗 Issue Links
Resolveshttps://linear.app/stream/issue/IOS-1103/hifi-implementation
🎯 Goal
Describe why we are making this change.
📝 Summary
Provide bullet points with the most important changes in the codebase.
🛠 Implementation
Provide a detailed description of the implementation and explain your decisions if you find them relevant.
🎨 Showcase
Add relevant screenshots and/or videos/gifs to easily see what this PR changes, if applicable.
imgimg🧪 Manual Testing Notes
Explain how this change can be tested manually, if applicable.
☑️ Contributor Checklist
🎁 Meme
Provide a funny gif or image that relates to your work on this pull request. (Optional)