Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork4.9k
SPDX [ 40 ][ Src / Mod / Robot ]#25115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
| @@ -1,3 +1,5 @@ | |||
| // SPDX-License-Identifier: LGPL-2.1-or-later | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Considering the license history of the Robot workbench, I took a closer look at this one. I believe that it comes from here:https://github.com/orocos/orocos_kinematics_dynamics/blob/fb840b0edb3e9905c354276d6513dddf4fd4ac1b/orocos_kdl/src/frameacc.inl -- so I can confirm that LGPL-2.1 is correct.
chennes commentedNov 12, 2025
It's not obvious to a casual inspection that the entire kdl_cp subdirectory is really a3rd party library -- it's been totally separated from its provenance. For future work we should consider adding some kind of acknowledgement and backlink. Or maybe someone like@onekk would like to take on making it a subtree? |
onekk commentedNov 12, 2025
From the little I know the kdl library was patched by jregel (I have read this info in one of the old posts, but I don't remember where). So it is not an exact copy of the upstream, that in the meantime has evolved a lot. I don't code in C++ as my knowledge is very limited to the minimum to read some not too complicated sources. as the kdl is the core of the inverse kinematics probably some quite deep knowledge of the matter is needed to think to update the sources to a more recent upstream code. kind regards |
Added missing SPDX license identifiers.