Fix the wording "counter example"#129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

pieterhijma wants to merge1 commit intoFreeCAD:main

base:main

Choose a base branch

frompieterhijma:fix-counter-example

Open

Fix the wording "counter example"#129

pieterhijma wants to merge1 commit intoFreeCAD:mainfrompieterhijma:fix-counter-example

Conversation

Copy link

Contributor

pieterhijma commentedMay 2, 2025

Make a small fix in reaction tothis feedback by@benj5378.

pieterhijma mentioned this pull request

May 2, 2025

Add guidelines for use ofauto for types in C++#123

Merged

Copy link

Contributor

hyarion commentedMay 2, 2025

I think we could make it more clear what is good and what is bad.
Maybe we could do something in the same style as the core guidelines (example fromhttps://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#f16-for-in-parameters-pass-cheaply-copied-types-by-value-and-others-by-reference-to-const):

voidf1(const string& s);// OK: pass by reference to const; always cheapvoidf2(string s);// bad: potentially expensivevoidf3(int x);// OK: Unbeatablevoidf4(constint& x);// bad: overhead on access in f4()

in this case it could look like:

auto value = randomThing.weirdProperty->getValue();// bad: non-obvious typelong value = randomThing.weirdProperty->getValue();// OK: type is specified, no need to guess type