- Notifications
You must be signed in to change notification settings - Fork23
Allow decoding of SMBIOS Type 11 serialnumbers#55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
5fc3f51 to7dd55b1Compare7dd55b1 to588d216Compare588d216 tod378c02Comparecfg0 will struggle with keyboard which also use 'B' for some languages |
framework_lib/src/smbios.rs Outdated
| pubfndump_oem_strings(strings:&SMBiosStringSet){ | ||
| for(i, s)in strings.into_iter().enumerate(){ | ||
| let idx = i +1; | ||
| let sn =match idx{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would be cooler if you didn't use idx positions for decoding the serial number (remember what happened last time these positions changed?). Just put them in a big array, shuffle them, and try to tell what each of them is based on the serial number contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The order doesn't change, the factory also depends on it, as far as I remember.
Decoding the serialnumber is harder as we would have to embed all possible serialnumbers and I couldn't include those for unannounced projects.
d378c02 to35f0d76CompareThey're the serialnumbers of what the system was originally assembledwith in the factory.TODO- [ ] Cleanup code- [ ] Make safer with fewer unwraps- [ ] Custom command, not in info- [ ] Make sure date is decoded correctly- [ ] Support Framework 12- [x] Support Framework 13- [ ] Support Framework 16Signed-off-by: Daniel Schaefer <dhs@frame.work>
Signed-off-by: Daniel Schaefer <dhs@frame.work>
35f0d76 to630eec7Compare
Uh oh!
There was an error while loading.Please reload this page.
They're the serialnumbers of what the system was originally assembled with in the factory.
TODO