- Notifications
You must be signed in to change notification settings - Fork23
Decode additional Framework16 and AMD related memmap items#39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
JohnAZoidberg wants to merge1 commit intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
a889601 to53c15faCompare53c15fa to4421678Compare4421678 tof87d5d5CompareTODO:- [ ] Handle it better than just increasing EC_MEMMAP_SIZE*2- [ ] Figure out all items and whether they apply to Lotus and also Azalea- [ ] Figure out Lotus and Azalea fan namesExample:```cargo build && sudo ./target/debug/framework_tool --driver portio --expansion-bayAMD Power Slider: DC, Battery Saver (0b0001000) STT Table: 7 CBP: true ([0, 0]) DTT Temp: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]Expansion Bay Serial Struct: [0, 0, 0, 0] PD Version: [0, 0, 0, 0] GPU CTRL: 0x8 MUX Status: GPU Board Status: Present PCIe Config: 8x1 Display On: false GPU Type: AMD R23M (2)```Reference data:```Fan Module Serial Struct: [0, 0, 0, 0] Batt Manuf 2023-22-7 PD Version: [0, 0, 0, 0] GPU CTRL: 0x0 Power Slider: AC, Best Power Efficiency (0b1000000) Display On: false STT Table: 13 CBP: true ([0, 0]) GPU Type: Initializing (0) DTT Temp: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]dGPU Module Serial Struct: [0, 0, 0, 0] Batt Manuf 2023-7-22 PD Version: [0, 0, 0, 0] GPU CTRL: 0x8 Power Slider: DC, Battery Saver (0b0001000) Display On: false STT Table: 7 CBP: true ([0, 0]) GPU Type: AMD R23M (2) DTT Temp: [0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0]```Signed-off-by: Daniel Schaefer <dhs@frame.work>
f87d5d5 to3a47334CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
Example:
Reference data: