- Notifications
You must be signed in to change notification settings - Fork27
Fixed : don't crash when stat graph setting is broken#45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
arnaudbesnier commentedMar 12, 2017
Hi@kevin-frugier, I am not a big fan of the idea of hiding the Forest issue you pointed by adding protections on the liana. The best for us would be to have a simple way to reproduce your charts "destruction" and then fix this issue. Do you have any reproduction steps? Thanks! |
kevin-frugier commentedMar 13, 2017
Personally I'm not a big fan of an update of Forest crashing my PRODUCTION server either. Anyway the liana is already quite robust to failures because it doesn't crash on exceptions. As for reproduction steps, the only thing I can tell you is that I migrated from Node 0.10.46 to 6.9.5 (at last!) but none of the model declaration has changed and the graph anyway is not declared at all on the serverside (only in Forest) and uses standard data. Luckily, it's during the validation phase of this migration (to 6.9.5) that I noticed that Forest had lost some of my graphs settings (like 'group_by'). |
…ver, HasManyAssociator and HasManyDissociator
roopakv commentedOct 14, 2018
would actually love if there was some progress on this. |
Uh oh!
There was an error while loading.Please reload this page.
For some reason, after returning to ForestAdmin UI after a while, some settings of my graphs were broken without having changed anything.
That's a bummer in itself (why did ForestAdmin loose my config out of the blue?), but the real problem is that this case was not properly handled by forest-express-mongoose hence resulting into a crash of my app.
The change of
line-stat-getter.jsfixes the crash.The change of
pie-stat-getter.jschanges the cryptic[forest] 🌳🌳🌳 Cannot read property 'reference' of undefinedinto
[forest] 🌳🌳🌳 Missing param `group_by_field`None of that would be required if the graph setting never broke for no reason (it's indeed impossible to create a graph without proper settings).