Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Strings builder dsl#2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
revonateB0T wants to merge6 commits intomain
base:main
Choose a base branch
Loading
fromlocale
Draft

Strings builder dsl#2016

revonateB0T wants to merge6 commits intomainfromlocale

Conversation

@revonateB0T
Copy link
Collaborator

No description provided.

@revonateB0TrevonateB0T marked this pull request as ready for reviewDecember 11, 2024 08:35
Copy link
Owner

@FooIbarFooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We can't use data class as we want multiple layers of fallbacks, e.g. zh-HK -> zh-TW -> en.

@revonateB0T
Copy link
CollaboratorAuthor

We can't use data class as we want multiple layers of fallbacks, e.g. zh-HK -> zh-TW -> en.

We can use data class.copy, but it seems data class hits jvm max method limit.

@revonateB0T
Copy link
CollaboratorAuthor

@FooIbar reimplemented, PTAL.

Pros: cleanest way for translators to add new strings
Cons: 1. No compiler check to avoid us mutate strings 2.No compiler check to avoid duplicate translations

@revonateB0TrevonateB0T changed the titleRefine StringsStrings builder dslDec 11, 2024
@revonateB0T
Copy link
CollaboratorAuthor

dex size decrease for 100KB as well

Copy link
Owner

@FooIbarFooIbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I don't think this is the way. How do the translators check for missing translations? They could just remove theby EnStrings before.

@revonateB0T
Copy link
CollaboratorAuthor

revonateB0T commentedDec 11, 2024
edited
Loading

I don't think this is the way. How do the translators check for missing translations? They could just remove theby EnStrings before.

I don't think translators will use IDE or check for compiler message.
They just compare the whole file with EN file, so the cleanest way to add is better

@revonateB0TrevonateB0T marked this pull request as draftDecember 11, 2024 12:53
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@FooIbarFooIbarFooIbar left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@revonateB0T@FooIbar

[8]ページ先頭

©2009-2025 Movatter.jp