- Notifications
You must be signed in to change notification settings - Fork60
Add callout_completions setting to selectively disable callout completions#321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Feel-ix-343 wants to merge1 commit intomainChoose a base branch fromdevin/1764099715-callout-completions-setting
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…tionsAddresses issue#226 - allows users to disable callout completions via aboolean setting in their config file. The setting defaults to true tomaintain backward compatibility.Users can now set callout_completions = false in their .moxide.toml or~/.config/moxide/settings.toml to disable callout completions and usetheir own snippet implementations instead.Co-Authored-By: Felix Zeller <felixazeller@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Summary
Adds a new
callout_completionsboolean setting that allows users to disable callout completions. This addresses issue#226 where users want to disable the built-in callout completions to use their own snippet implementations (e.g., via LuaSnip).The setting defaults to
trueto maintain backward compatibility. Users can setcallout_completions = falsein their.moxide.tomlor~/.config/moxide/settings.tomlto disable callout completions.Review & Testing Checklist for Human
callout_completions = falseto a config file and confirming callout completions no longer appear when typing>in a markdown fileNotes
Closes#226
Link to Devin run:https://app.devin.ai/sessions/72a475cd2c40405f92aaad90a79e481f
Requested by: Felix Zeller (@Feel-ix-343)