- Notifications
You must be signed in to change notification settings - Fork133
fix: move IMessageProducer and IProducerAccessor from main project to Abstractions#643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Zananok commentedApr 18, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Please suggest a fix for Its not used in the interface, but its used in the base interface it inherits/extends. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Zananok commentedJun 15, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Bump |
…from Confluent.KafkaThis moves IMessageProducer.cs and IProducerAccessor.cs into the Abstractions project,introduces delivery-report and result-flow conversions for KafkaFlow, and fully decouplesKafkaFlow from Confluent.Kafka
…ect to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.
Description
Move IMessageProducer.cs and IProducerAccessor.cs from main project to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.
I created 3 interfaces and 3 implementations (as a transfer object) mirroring the original, replacing types with
objectfor those for which implementing the types would be a little too much work, and since a lot of the project already just usesobject, I followed suit.The only purpose of this PR is to move the interfaces to the Abstractions project as they are too coupled and prevents the Abstrations project to be what it should be.Fixes # (issue)
Decouples IProducerAccessor and IMessageProducer from Confluent.Kafka's
DeliveryResultandDeliveryReportand moves the Interfaces to the ideal place: the Abstractions project.How Has This Been Tested?
Imported my local KafkaFlow to both a producing and consumer project and it ran without throwing an exception.
An extra manual check would be appreciated.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of ourContributor Ownership Statement