Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: move IMessageProducer and IProducerAccessor from main project to Abstractions#643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Zananok wants to merge1 commit intoFarfetch:master
base:master
Choose a base branch
Loading
fromZananok:master

Conversation

@Zananok
Copy link

…ect to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.

Description

Move IMessageProducer.cs and IProducerAccessor.cs from main project to Abstractions by introducing delivery report flow and result flow conversions for KafkaFlow and decoupling it from Confluent.Kafka.

I created 3 interfaces and 3 implementations (as a transfer object) mirroring the original, replacing types withobject for those for which implementing the types would be a little too much work, and since a lot of the project already just usesobject, I followed suit.The only purpose of this PR is to move the interfaces to the Abstractions project as they are too coupled and prevents the Abstrations project to be what it should be.

Fixes # (issue)

Decouples IProducerAccessor and IMessageProducer from Confluent.Kafka'sDeliveryResult andDeliveryReport and moves the Interfaces to the ideal place: the Abstractions project.

How Has This Been Tested?

Imported my local KafkaFlow to both a producing and consumer project and it ran without throwing an exception.
An extra manual check would be appreciated.

Checklist

  • [ x ] My code follows the style guidelines of this project
  • [ x ] I have performed a self-review of my own code
  • I have added tests to cover my changes
  • I have made corresponding changes to the documentation

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of ourContributor Ownership Statement

@Zananok
Copy link
Author

Zananok commentedApr 18, 2025
edited
Loading

Please suggest a fix forhttps://app.codacy.com/gh/Farfetch/kafkaflow/pull-requests/643/issues#issue-449a910beecdd513142243dcdeee702c: "Unused code - 'TKey' is not used in the interface.", or perhaps consider removing/creating an exception for this static code analysis rule.

Its not used in the interface, but its used in the base interface it inherits/extends.

@Zananok
Copy link
Author

Zananok commentedJun 15, 2025
edited
Loading

Bump
@BLage Any updates?

…from Confluent.KafkaThis moves IMessageProducer.cs and IProducerAccessor.cs into the Abstractions project,introduces delivery-report and result-flow conversions for KafkaFlow, and fully decouplesKafkaFlow from Confluent.Kafka
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@BLageBLageBLage left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Zananok@BLage

[8]ページ先頭

©2009-2025 Movatter.jp