- Notifications
You must be signed in to change notification settings - Fork133
fix: out of order production issue#567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| /// <param name="headers">The message headers</param> | ||
| /// <param name="deliveryHandler">A handler with the operation result</param> | ||
| /// <param name="partition">The partition where the message will be produced, if no partition is provided it will be calculated using the message key</param> | ||
| [Obsolete("This method will be remove in the next major release, please use ProduceAsync() instead")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why are we marking the Produce methods as obsolete? In scenarios where the message throughput is high, the non async producer can produce at a significant higher rate since it doesn't need to wait for the report.
Why can't the framework support this?
Sorry, a bit confused here. If the issue is related to calling the ProduceAsync without await, isn't expected that the Task execution order cannot be guaranteed? In .NET ecosystem, this is expected since it is the way that .NET handles task execution. If the caller does not want to wait for the delivery report, as an alternative, can use the non-async producer or set the aks to 0. |
Description
Fix an issue that the messages are published in the wrong order when we call ProduceAsync() many times without awaiting.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes.
Checklist
Disclaimer
By sending us your contributions, you are agreeing that your contribution is made subject to the terms of ourContributor Ownership Statement