Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add e2e tests#331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
Naseem77 wants to merge18 commits intostaging
base:staging
Choose a base branch
Loading
fromadd-e2e-tests
Open
Changes from1 commit
Commits
Show all changes
18 commits
Select commitHold shift + click to select a range
4906b4c
Add e2e Tests
Naseem77Dec 10, 2025
1238be6
Add api calls/responses for logic layer
Naseem77Dec 10, 2025
d96ac6b
adding pom for homePage
Naseem77Dec 10, 2025
7b40625
adding auth setup
Naseem77Dec 10, 2025
783d9f4
add docker compose file for database connections
Naseem77Dec 15, 2025
862a87b
add sidebar tests
Naseem77Dec 15, 2025
692efed
add user profile tests
Naseem77Dec 15, 2025
4d34598
update user profile tests
Naseem77Dec 15, 2025
a966b03
update auth setup - adding another user
Naseem77Dec 15, 2025
1b880a4
add database tests
Naseem77Dec 16, 2025
f9e369c
update playwright CI
Naseem77Dec 16, 2025
c124c2e
update ci
Naseem77Dec 16, 2025
f6c751f
update ci
Naseem77Dec 16, 2025
2ddeb39
Update playwright.yml
Naseem77Dec 16, 2025
2e65792
update ci
Naseem77Dec 16, 2025
d7233b7
update ci
Naseem77Dec 16, 2025
bfa04c1
Update playwright.yml
Naseem77Dec 16, 2025
610c3f5
update CI and tests
Naseem77Dec 16, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
PrevPrevious commit
NextNext commit
update ci
  • Loading branch information
@Naseem77
Naseem77 committedDec 16, 2025
commitf6c751f32a80d5f38c11924995edc5458fc40ced

Some comments aren't visible on the classic Files Changed page.

36 changes: 25 additions & 11 deletions.github/workflows/playwright.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,103 +11,117 @@

jobs:
test:
timeout-minutes: 60
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

# Setup Python
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_VERSION }}

# Setup Node.js
- uses: actions/setup-node@v4
with:
node-version: ${{ env.NODE_VERSION }}

# Install pipenv
- name: Install pipenv
run: pip install pipenv

# Install Python dependencies
- name: Install Python dependencies
run: pipenv sync --dev

# Install Node dependencies (frontend)
- name: Install frontend dependencies
run: npm ci

# Build frontend
- name: Build frontend
run: npm run build
working-directory: ./app

# Start Docker Compose services (test databases + FalkorDB)
# Start Docker Compose services (test databases)
- name: Start test databases
run: |
docker compose -f e2e/docker-compose.test.yml up -d
# Wait for databases to be healthy
echo "Waiting for databases to be ready..."
sleep10
sleep20
docker ps -a
# Verify all containers are running
docker compose -f e2e/docker-compose.test.yml ps

# Start FalkorDB (Redis graph database)
- name: Start FalkorDB
run: |
docker run -d --name falkordb-test -p 6379:6379 falkordb/falkordb:latest
sleep 5
docker ps -a

# Start the FastAPI applicationin background
# Start the FastAPI applicationwith frontend build
- name: Start FastAPI application
run: |
pipenv run uvicorn api.index:app --host localhost --port 5000 &
# Build frontend and start server in background using Make
make run-prod > /tmp/uvicorn.log 2>&1 &
UVICORN_PID=$!
echo "Started server with PID: $UVICORN_PID"
# Wait for app to start
echo "Waiting for application to start..."
sleep 10
curl -f http://localhost:5000/ || (echo "Failed to start application" && exit 1)
for i in {1..30}; do
if curl -f http://localhost:5000/ 2>/dev/null; then
echo "Application started successfully!"
break
fi
echo "Waiting... attempt $i/30"
sleep 1
if [ $i -eq 30 ]; then
echo "Failed to start application after 30 seconds"
echo "=== Server logs ==="
cat /tmp/uvicorn.log
exit 1
fi
done
env:
HOST: localhost
PORT: 5000
PYTHONUNBUFFERED: 1
FASTAPI_SECRET_KEY: test-secret-key-for-ci
APP_ENV: development
FASTAPI_DEBUG: False
FALKORDB_HOST: localhost
FALKORDB_PORT: 6379
DISABLE_MCP: true

# Install Playwright browsers
- name: Install Playwright Browsers
run: npx playwright install --with-deps chromium firefox

# Run Playwright tests
- name: Run Playwright tests

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[blocker]: Playwright CI never launches backend. The Playwright workflow installs dependencies and immediately runsnpx playwright test, but it neither starts the QueryWeaver backend/frontend nor setsPLAYWRIGHT_BASE_URL, so every navigation/API helper will hit an empty localhost port and time out on CI. Add a step (or PlaywrightwebServer config) that starts the API/frontend, waits for it to become reachable, and exportsPLAYWRIGHT_BASE_URL before the tests run.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

[blocker] This job installs deps and immediately executesnpx playwright test, but it never starts the QueryWeaver API/UI (or configures Playwright’swebServer). With no server listening onhttp://localhost:5000 every navigation/auth request in the suite will hitECONNREFUSED on CI. Please add a step (orwebServer config) that boots the backend and waits for it to be ready before running the tests so the workflow can actually exercise the app.

run: npx playwright test --reporter=list
env:
CI: true

# Upload test results on failure
- uses: actions/upload-artifact@v4
if: failure()
with:
name: playwright-report
path: playwright-report/
retention-days: 30

# Upload test screenshots on failure
- uses: actions/upload-artifact@v4
if: failure()
with:
name: test-results
path: test-results/
retention-days: 30

# Cleanup - Stop all containers
- name: Cleanup Docker containers
if: always()
run: |
docker compose -f e2e/docker-compose.test.yml down -v || true
docker stop falkordb-test || true
docker rm falkordb-test || true
Loading

[8]ページ先頭

©2009-2025 Movatter.jp