Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1k
Fix support for Chinese and other characters in setwarp and sethome filenames; ensure backward compatibility with old safe string names replaced by underscores#5890
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
wkea wants to merge7 commits intoEssentialsX:2.xChoose a base branch
base:2.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…ilenames; ensure backward compatibility with old safe string names replaced by underscoreshis PR addresses the issue where and commands in the Essentials plugin do not support Chinese and other non-alphanumeric characters in filenames. The following changes have been made to ensure broader character support and maintain backward compatibility:setwarpsethomeSupport for Chinese and other characters:Updated the regular expression patterns to allow Chinese characters and other non-alphanumeric characters in and filenames.setwarpsethomeBackward compatibility with old safe string names:When a player uses the command, the system will first attempt to match the provided with the new format./home <homename>homename
…in do not support Chinese and other non-alphanumeric characters in filenames. The following changes have been made to ensure broader character support and maintain backward compatibility:setwarpsethomeSupport for Chinese and other characters:Updated the regular expression patterns to allow Chinese characters and other non-alphanumeric characters in and filenames.setwarpsethomeBackward compatibility with old safe string names:When a player uses the command, the system will first attempt to match the provided with the new format./home <homename>homenameIf no match is found, it will then attempt to match the old format where special characters were replaced by underscores, ensuring compatibility with existing configurations.These changes allow players to use a wider range of characters in their home and warp names while preserving the functionality for names created with the previous format.Example UsageNew behavior: Players can now set home names like ./sethome 我的房子Backward compatibility: If a player previously had a home named (converted from ), using will still work ./home 我的菜地 (/home ____)
…in do not support Chinese and other non-alphanumeric characters in filenames. The following changes have been made to ensure broader character support and maintain backward compatibility:setwarpsethomeSupport for Chinese and other characters:Updated the regular expression patterns to allow Chinese characters and other non-alphanumeric characters in and filenames.setwarpsethomeBackward compatibility with old safe string names:When a player uses the command, the system will first attempt to match the provided with the new format./home <homename>homenameIf no match is found, it will then attempt to match the old format where special characters were replaced by underscores, ensuring compatibility with existing configurations.These changes allow players to use a wider range of characters in their home and warp names while preserving the functionality for names created with the previous format.Example UsageNew behavior: Players can now set home names like ./sethome 我的房子Backward compatibility: If a player previously had a home named (converted from ), using will still work ./home 我的菜地 (/home ____)
Avoid causing potential bugs
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Information
This PRfixes#5889.
Details
Proposed fix:
This PR addresses the issue where and commands in the Essentials plugin do not support Chinese and other non-alphanumeric characters in filenames. The following changes have been made to ensure broader character support and maintain backward compatibility:setwarpsethome
Support for Chinese and other characters:
Updated the regular expression patterns to allow Chinese characters and other non-alphanumeric characters in and filenames.setwarpsethome
Backward compatibility with old safe string names:
When a player uses the command, the system will first attempt to match the provided with the new format./home homename
If no match is found, it will then attempt to match the old format where special characters were replaced by underscores, ensuring compatibility with existing configurations.
These changes allow players to use a wider range of characters in their home and warp names while preserving the functionality for names created with the previous format.
Example Usage:
New behavior: Players can now set home names like ./sethome 我的房子
Backward compatibility: If a player previously had a home named (converted from ), using will still work./home 我的菜地 ("____")
Environments tested:
OS: Windows 10
Java version: OpenJDK 21(21.0.3)
Most recent Paper version (1.20.4,#497)