Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork1k
Introduce command trees; improve Commandessentials#5384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
mdcfe wants to merge10 commits into2.xChoose a base branch fromfeature/improve-ess-command
base:2.x
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Not sure if we want this long-term or not, but we'll keep it for now
Dumb question maybe, but wouldn't it be possible to use Mojang's brigadier library for this purpose? |
Using that severely limits the flexibility we have and reduces the code quality. |
# Conflicts:#Essentials/src/main/java/com/earth2me/essentials/commands/Commandessentials.java
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Information
This PR closes an internal goal.
Details
Proposed feature:
This implements two separate features (may be split into separate PRs later down the line):
EssentialsCommand/essentials, splitting complex subcommands into separate classesrunandtabCompleteimpls with treeEnvironments tested:
OS: Windows 11 22H2
Java version: Eclipse Temurin 17.0.6
Demonstration:
This PR should preserve all existing functionality of
/essentials.