Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add support for Folia#5291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
JRoy wants to merge24 commits into2.x
base:2.x
Choose a base branch
Loading
fromrefactor/folia
Draft

Add support for Folia#5291

JRoy wants to merge24 commits into2.xfromrefactor/folia

Conversation

@JRoy
Copy link
Member

@JRoyJRoy commentedMar 29, 2023•
edited
Loading

this barely works

todo;

  • validate timer race conditions
  • fix the tps command shit
  • InteractionControllerImpl commands don't fucking fire, need to figure out what im going to do, need to delegate threads for commands to run OUTside of the jda event but also get some of that off netty threads
  • review everything ran on global thread
  • entire discord module probably doesn't work
  • finish static accesses to the scheduler
  • what are we doing with api events

iLemon, cgw2023, Hanmingxuan, LuluxClient, Commandcracker, TheDiscordian, RealTriassic, and PikaMug reacted with thumbs up emojidarksaid98, WolfAURman, imDaniX, bladbl, SrBedrock, hkkongou, NotGeri, cgw2023, JellyBrick, LuluxClient, and 3 more reacted with rocket emoji
@JRoyJRoy added type: enhancementFeatures and feature requests. module: mainIssues or PRs for the main Essentials module module: discordIssues or PRs for the EssentialsDiscord module module: chatIssues or PRs for the EssentialsChat module module: spawnIssues or PRs for the EssentialsSpawn module module: geoIssues or PRs for the EssentialsGeo module module: antibuildIssues or PRs for the EssentialsAntiBuild module module: protectIssues or PRs for the EssentialsProtect module labelsMar 29, 2023
@JRoyJRoy added this to the2.20.0 milestoneMar 29, 2023
@JRoyJRoy marked this pull request as draftMarch 29, 2023 23:15
@JRoyJRoy modified the milestones:2.20.0,2.21.0Apr 28, 2023
@cgw2023
Copy link

cgw2023 commentedJun 20, 2023•
edited
Loading

there is a problem with essentialsSpawn folia
respawn-listener is not working
no matter how i tune

respawn-listener-priority: highspawn-join-listener-priority: highrespawn-at-home: falserespawn-at-home-bed: true

player die will not go back to essentials spawn point if no vanilla spawnpoint, bed and home is set

this does not happen in paper/spigot

@ghost

This comment was marked as spam.

@xcomcadx

This comment was marked as spam.

@iLemon
Copy link

This PR runs well on folia 1.20.1 for me.

The only minor issue I've encountered so far is the time and weather setting commands give an error:
CleanShot 2023-07-27 at 17 48 13@2x

The vanilla command (/minecraft:time set day) work fine so this is really minor.

JRoy reacted with thumbs up emoji

# Conflicts:#EssentialsDiscord/src/main/java/net/essentialsx/discord/util/ConsoleInjector.java
@JRoy
Copy link
MemberAuthor

Updated to latest 2.x and fixed time + weather command

@iLemon
Copy link

iLemon commentedJul 31, 2023•
edited
Loading

The time and weather commands now show a success message but doesn't seem to actually have an effect on the time/weather.

[17:46:45] [Region Scheduler Thread #1/INFO]: iLemon issued server command: /time night[17:46:45] [Region Scheduler Thread #1/WARN]: [Essentials] Location task for Essentials v2.20.1-dev+67-0c8bc16 in world CraftWorld{name=world} at 0, 0 generated an exceptionjava.lang.IllegalStateException: Cannot modify time off of the global regionat io.papermc.paper.threadedregions.RegionizedServer.ensureGlobalTickThread(RegionizedServer.java:106) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at org.bukkit.craftbukkit.v1_20_R1.CraftWorld.setTime(CraftWorld.java:858) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at com.earth2me.essentials.commands.Commandtime.lambda$run$0(Commandtime.java:92) ~[EssentialsX-2.20.1-dev+67-0c8bc16.jar:?]at io.papermc.paper.threadedregions.scheduler.FoliaRegionScheduler.lambda$wrap$0(FoliaRegionScheduler.java:35) ~[folia-1.20.1.jar:?]at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue$ChunkBasedPriorityTask.executeInternal(RegionizedTaskQueue.java:504) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at io.papermc.paper.threadedregions.RegionizedTaskQueue$PrioritisedQueue.executeTask(RegionizedTaskQueue.java:434) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at io.papermc.paper.threadedregions.RegionizedTaskQueue$RegionTaskQueueData.drainTasks(RegionizedTaskQueue.java:263) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1514) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at io.papermc.paper.threadedregions.TickRegions$ConcreteRegionTickHandle.tickRegion(TickRegions.java:360) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at io.papermc.paper.threadedregions.TickRegionScheduler$RegionScheduleHandle.runTick(TickRegionScheduler.java:385) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at ca.spottedleaf.concurrentutil.scheduler.SchedulerThreadPool$TickThreadRunner.run(SchedulerThreadPool.java:525) ~[folia-1.20.1.jar:git-Folia-"daacd42"]at java.lang.Thread.run(Thread.java:833) ~[?:?]
TheDevMinerTV reacted with thumbs up emoji

@Git-North
Copy link

I thought weather commands were disabled on folia

# Conflicts:#Essentials/src/main/java/com/earth2me/essentials/commands/Commandskull.java
@JRoy
Copy link
MemberAuthor

Fixed the commands again

@LuluxClient
Copy link

Everything works fine except the respawn feature (tested from the previous comment to see if it was still an issue)

@DarkyG2
Copy link

No issues on my end after testing it on prod, would love to see a merge to the main branch

@nyancat-hu

This comment was marked as off-topic.

@DarkyG2
Copy link

Small issue with commands in kits, I'm getting the error "[22:57:44 WARN]: [Essentials] Dispatching command async" and that's it and I won't receive the items executed thru a command

@Potothingi

This comment has been minimized.

@RitaSister

This comment has been minimized.

@TATA82
Copy link

folia support is work 1.20.6?

@RitaSister
Copy link

folia support is work 1.20.6?

no, doesn't support

@RitaSister

This comment was marked as off-topic.

@Q2297045667
Copy link

Will 1.21 be updated?

@mdcfemdcfe modified the milestones:2.21.0,2.22.0Sep 15, 2024
@Q2297045667
Copy link

Will he still update it?Will it support future versions of Minecraft in the future?

@Potothingi
Copy link

Folia is now Stable, I hope this PR gets updated.
https://papermc.io/downloads/folia

Q2297045667, PikaMug, LKirillK, Euphillya, and VadSzil42 reacted with thumbs up emojiP1otrulla reacted with laugh emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module: antibuildIssues or PRs for the EssentialsAntiBuild modulemodule: chatIssues or PRs for the EssentialsChat modulemodule: discordIssues or PRs for the EssentialsDiscord modulemodule: geoIssues or PRs for the EssentialsGeo modulemodule: mainIssues or PRs for the main Essentials modulemodule: protectIssues or PRs for the EssentialsProtect modulemodule: spawnIssues or PRs for the EssentialsSpawn moduletype: enhancementFeatures and feature requests.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

14 participants

@JRoy@cgw2023@xcomcadx@iLemon@Git-North@LuluxClient@DarkyG2@nyancat-hu@Potothingi@RitaSister@TATA82@Q2297045667@mdcfe
[8]ページ先頭
©2009-2025 Movatter.jp