Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Implementation of CommandFilters, replacing cooldowns and costs#3886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
FrankHeijden wants to merge15 commits intoEssentialsX:2.x
base:2.x
Choose a base branch
Loading
fromFrankHeijden:extract-command-filters

Conversation

@FrankHeijden
Copy link
Contributor

Basically implements#3200, with just a small difference in yaml format: made thename required, as a key, just like kits.
Automatic converter is included, and will create the new yaml format from existing nodes.
Formats forcommand will be the same as with thecommand-costs, formats forpattern will be the same as incommand-cooldowns.

Closes#3200,#3847

oskarkk reacted with thumbs up emojitriagonal and imDaniX reacted with rocket emoji
@Bobcat00
Copy link
Contributor

How does this affect PR#3744 ?

@FrankHeijden
Copy link
ContributorAuthor

FrankHeijden commentedDec 30, 2020•
edited
Loading

How does this affect PR#3744 ?

They should go hand in hand with each other, defining apattern filter in this version will behave the same as a regularcommand-cooldown in that PR

@Bobcat00
Copy link
Contributor

Bobcat00 commentedDec 30, 2020•
edited
Loading

They should go hand in hand with each other, defining apattern filter in this version will behave the same as a regularcommand-cooldown in that PR

So this PR needs#3744 ? Just asking because 3744 hasn't been merged yet.

@FrankHeijden
Copy link
ContributorAuthor

They should go hand in hand with each other, defining apattern filter in this version will behave the same as a regularcommand-cooldown in that PR

So this PR needs#3744 ? Just asking because 3744 hasn't been merged yet.

I mean they are independent features --#3744 fixes a bug wherecommands.yml defined commands aren't recognised by EssX, this one refactors the cooldowns/costs into a separate yml file as described per#3200 (and by doing that fixing a bug where periods couldn't be used in the regexes, because yml prohibits periods in keys).

Make CommandFilter more extendable + fix AsyncTeleport not applying command cooldown
@FrankHeijden
Copy link
ContributorAuthor

So I just came across a thing which prevented AsyncTeleport's from applying command cooldowns - this is due to the fact AsyncTeleport creates a new Trade without the command defined in it. I added a newcooldownCommand parameter for the Trade#charge() command, so this method can know what command we should apply cooldowns on.

@JRoyJRoy requested a review frommdcfeJanuary 3, 2021 23:34
@triagonaltriagonal added type: enhancementFeatures and feature requests. bug: confirmedConfirmed bugs in EssentialsX. type: bugfixPRs that fix bugs in EssentialsX. and removed bug: confirmedConfirmed bugs in EssentialsX. labelsJan 9, 2021
# Conflicts:#Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
@JRoy
Copy link
Member

Conflicts need to be addressed, please reopen when done so.

@JRoyJRoy closed thisJun 11, 2021
@FrankHeijden
Copy link
ContributorAuthor

Cant reopen this one, opening#4224 instead

@triagonaltriagonal reopened thisJun 15, 2021
# Conflicts:#Essentials/src/main/java/com/earth2me/essentials/Essentials.java#Essentials/src/main/java/com/earth2me/essentials/Settings.java
@JRoyJRoy added the module: mainIssues or PRs for the main Essentials module labelJun 17, 2021
@FrankHeijden
Copy link
ContributorAuthor

What’s the status on this PR? 😅

@JRoy
Copy link
Member

JRoy commentedJul 27, 2021•
edited
Loading

What’s the status on this PR? 😅

This likely won't make it in time for 2.19 but 100% 2.20/2.19.x

FrankHeijden reacted with thumbs up emoji

@JRoyJRoy added this to the2.19.1 milestoneAug 2, 2021
@JRoyJRoy modified the milestones:2.19.1,2.20.0Oct 24, 2021
Copy link
Member

@JRoyJRoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Needs to be updated to configurate (use EssentialsConfiguration over EssentialsConf)

@FrankHeijden
Copy link
ContributorAuthor

Needs to be updated to configurate (use EssentialsConfiguration over EssentialsConf)

Done

@mdcfe
Copy link
Member

Just a quick heads-up: I have a pending review for this PR, but I likely won't have time to properly review this for a few weeks.

FrankHeijden reacted with thumbs up emoji

@JRoy
Copy link
Member

Remaining errors (EssentialsConf and logger stuff) need to be fixed. It's almost been 2 years since this PR was made, and I appreciate your persistence 😅. This pull request will be merged for 2.20 which is HOPEFULLY before the new year.

@FrankHeijden
Copy link
ContributorAuthor

@JRoy Some build dependencies are timing out because they redirect to jcenter, which closed down. Do they need to be updated or is there a repo missing for these dependencies?

WkyRXerS

@JRoyJRoy modified the milestones:2.20.0,2.21.0Apr 28, 2023
# Conflicts:#Essentials/src/main/java/com/earth2me/essentials/EssentialsPlayerListener.java
@mdcfemdcfe modified the milestones:2.21.0,2.22.0Sep 15, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@JRoyJRoyJRoy requested changes

@mdcfemdcfeAwaiting requested review from mdcfe

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

module: mainIssues or PRs for the main Essentials moduletype: bugfixPRs that fix bugs in EssentialsX.type: enhancementFeatures and feature requests.

Projects

None yet

Milestone

2.22.0

Development

Successfully merging this pull request may close these issues.

Replace command-costs and command-cooldowns with command filters system

5 participants

@FrankHeijden@Bobcat00@JRoy@mdcfe@triagonal
[8]ページ先頭
©2009-2025 Movatter.jp