Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Work with frozen intrinsics#5868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
arlyon wants to merge1 commit intoEffect-TS:main
base:main
Choose a base branch
Loading
fromarlyon:arlyon/work-with-frozen-intrinsics

Conversation

@arlyon
Copy link

@arlyonarlyon commentedDec 4, 2025•
edited
Loading

Type

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

In some places (frozen-intrinsics, deterministic sandboxes like in temporal), error is readonly to limit the amount of peturbation. This causes issues when effect assumes it can modify, leading to exceptions. This changes that code to a best-effort attempt with a silent failure. I chose to just duplicate the snippet in the ai lib.

Related

Though outside this repo, this pattern is used within node itself. The core snippet comes from their internal checks. I have added a wrapper to DRY the set, unset, and error handling.

https://github.com/nodejs/node/blob/e77694631f1642c302f664703197b5aabc65b482/lib/internal/errors.js#L246

@changeset-bot
Copy link

changeset-botbot commentedDec 4, 2025•
edited
Loading

⚠️ No Changeset found

Latest commit:1757334

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go.If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@mikearnaldi
Copy link
Member

withStackTraceLimit will introduce a stack frame so it changes the shape of the trace

@arlyon
Copy link
Author

Ah, you are correct. I will re-impl without the helper just with the check

@arlyonarlyonforce-pushed thearlyon/work-with-frozen-intrinsics branch fromc3df8ed to1757334CompareDecember 8, 2025 12:49
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@IMax153IMax153Awaiting requested review from IMax153IMax153 is a code owner

@mikearnaldimikearnaldiAwaiting requested review from mikearnaldimikearnaldi is a code owner

Assignees

No one assigned

Labels

None yet

Projects

Status: Discussion Ongoing

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@arlyon@mikearnaldi
[8]ページ先頭
©2009-2025 Movatter.jp