- Notifications
You must be signed in to change notification settings - Fork1.5k
fix: AndroidonLoad event when view width and height are zero#953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
thomas-coldwell wants to merge3 commits intoDylanVann:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
5 tasks
Beamanator commentedJan 18, 2023
@DylanVann Is there any chance you can let us know your thoughts on this change?@thomas-coldwell and I would be happy to discuss with you if you have any questions / concerns about this update |
Beamanator commentedAug 21, 2023
Bump? 🙃 |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Hey@DylanVann 👋
This PR aims to fix an existing issue with the
onLoadevent not firing on Android when the view style's width or height is zero as documented here#865. There is a similar PR#446 that was opened, but as mentioned in reviews this causes crashes due to the.override(Target.SIZE_ORIGINAL)method being applied to Glide. Instead, this PR follows the recommended way of getting the natural image dimensions as documented here in the Glide repobumptech/glide#781 (comment).The changes here include:
onLoadmethod on Android to work in the same way iOS does - reporting the original natural image dimensionsThese changes are best tested with the
AutoSizecomponent in the example app - as you can see setting the width to zero still triggers theonLoadevent and this example is then rendered correctly.