Codecov Report

Merging#437 (c86abda) intomain (a7a8643) willdecrease coverage by45.01%.
The diff coverage is17.39%.

❗ Current headc86abda differs from pull request most recent head0ee6e1f. Consider uploading reports for the commit0ee6e1f to get more accurate results

@@             Coverage Diff             @@##             main     #437       +/-   ##===========================================- Coverage   96.29%   51.28%   -45.02%===========================================  Files           1        2        +1       Lines          27       39       +12       Branches        2        0        -2     ===========================================- Hits           26       20        -6- Misses          1       19       +18

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update4d8c749...0ee6e1f. Read thecomment docs.

Hey all! Is this going somewhere?

Is this PR still being worked on? Would be such a nice feature to have.

There are some conflicts, I think you should resolve them@Mickagd before@DylanVann can take a look at this PR ^^

Please consider implementing this! It would be so useful!

Really happy to see this still moving forward! I can't wait to remove my component hack 😄

Hello. Any update on this?

@LuisRodriguezLD As far as I can see there are conflicts.

I've reimplemented this. Confirmed to work on iOS. Android I'll check later. I'll make a PR when I'm done.

On a sidenote, my solution uses a lot less code so I'm hoping that makes it easier to get it merged.

Hi@RWOverdijk. Thanks for your work! Could you publish your reimplementation on your fork that we can help to test it and speed up this to get it merged?

We really need this to be compatible with RN v0.60+.

@Elindorath Sure thing. I have to finish android first though. The module is compatible with 0.60+ for me, so I'm not sure what you mean

Hi@RWOverdijk , how is it going with Android ? :) Need any help ?

Promise should also return which pictures from array couldn't be fetched, not only how many couldn't be fetched.

@joan-saum It's going all right. The biggest problem right now is time and priorities. I can push the iOS stuff at some point this or next week though, maybe someone else can then PR the android stuff to my branch and we can get this thing going!

Sorry for my lack of time... It bothers me as well.

Please, consider to also add id to every image, so we can check from react-native side which images failed to load.

@sebinq I will not be doing that but you could add that after if you want.

@RWOverdijk thanks for info,, I will try.

The problem is that my project isn't selling well enough to prioritize this feature (My sales strategy was well calculated but man, am I bad at math.).

We have updated our PR with your last changes.
There is a lot of people that need these changes.
Could you please merge this request@DylanVann ?
Thanks a lot !

Please merge this PR. I really need it 👍

Hi guys just a last call if it's possible to merge this PR, we invested time here to bring last changes to the PR and I think this will help a lot of people.
So I hope my words will find you@DylanVann
Thanks a lot for your work and maybe we could help to maintain this package for other needs !

how to implement this into my project? because i don't have src folder in my node_modules fast image

Hi@putuoka, did you download the stable version of the package or did you download it from this pull request?

If you have downloaded the stable version in yournode_modules folder you should see the compiled package in thedist folder, if not you should see the entire project as the below image:

Hi@putuoka, did you download the stable version of the package or did you download it from this pull request?

If you have downloaded the stable version in yournode_modules folder you should see the compiled package in thedist folder, if not you should see the entire project as the below image:

Hi@nicomontanari , thanks for the reply. i have downloaded stable version using yarn add react-native-fast-image
what i mean is, in this pull request there is 12 files change one of them isPreloaderManager.tsx which i can't find in my node_modules react-native-fast-image

sorry because i'm new with rn i might missing something here. sorry for my english. please enlighten me because i need to use preload promise/callback to know when it done downloading resources and then i can use it as cache with fast images & redux persist

@putuoka you need to install this package withyarn add DylanVann/react-native-fast-image#pull/437/head ornpm install DylanVann/react-native-fast-image#pull/437/head if you use npm

@putuoka you need to install this package withyarn add DylanVann/react-native-fast-image#pull/437/head ornpm install DylanVann/react-native-fast-image#pull/437/head if you use npm

Hi@nicomontanari i got this error:

error: Error: While trying to resolve module `react-native-fast-image` from file `D:\gcp-app\src\MainApp.js`, the package `D:\gcp-app\node_modules\react-native-fast-image\package.json` was successfully found. However, this package itself specifies a `main` module field that could not be resolved (`D:\gcp-app\node_modules\react-native-fast-image\dist\index.cjs.js`. Indeed, none of these files exist:

edit: runyarn upgrade --latest into node_modules fast image after that runyarn build i solve that error by doing this but still can't use new preload.

solved!! it's working!! here what i do:

1. clone original repo not from this pull request
2. runyarn install no need upgrade to latest. after that changes necessary files according to this pull request.
3. runyarn build copy "dist" folder to your destination node_modules which has original install of this package

note: it can't preload 151 images. sometimes just 32, sometimes 113

Btw This pull make FastImage.clearDiskCache() broken

TypeError: Cannot read property 'clearDiskCache' of null

code:

FastImage.clearDiskCache().then(() => {      //preloadComplete(isComplete);      console.log('clear');    });

really need this!

Any plans yet to merge this? Any forks that have this merged with upstream?

Any plans yet to merge this? Any forks that have this merged with upstream?

I added the changes to my fork with the updated stream:#986

This would be so nice to have!

Had the same need, couldn't patch the PR due to conflicts. I am using another patch to get thecache folder path
With that I wrote a tiny function to get the state and even a progress of the cached images. Maybe this helps someone as a workaround...

  async function checkCacheFolder(cacheFolderPath, expectedImageCount) {    try {      const files = await RNFS.readDir(cacheFolderPath);      const imageCount = files.filter(        file => file.isFile() && file.name.endsWith('.jpg'),      ).length;      if (imageCount === expectedImageCount) {        console.log('Images cache complete');        return;      }      let progress = (imageCount / expectedImageCount) * 100;      console.log(progress.toFixed(0));      setTimeout(() => {       checkCacheFolder(          cacheFolderPath,          expectedImageCount,        );      }, 1000);    } catch (error) {      //Sentry will log that    }  },