- Notifications
You must be signed in to change notification settings - Fork194
[GPT] Get secondary header address from primary if otherwise valid#306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
Penguinwizzard wants to merge1 commit intoDiscUtils:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The UEFI spec states that to validate a GPT we should check the sig,CRC, self-referential LBA, partition entry array CRC, and for theprimary GPT, the GPT at the alternateLBA. Here we were instead checkingthe GPT at the end of the disk, which may not be the same as thealternateLBA if the disk was grown by a non-partition-aware tool (e.g.in a RAID array). By checking the indicated alternateLBA, we accept morevalid GPT-based disks, where before we may have been looking atuninitialized data.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The UEFI spec states that to validate a GPT we should check the sig, CRC, self-referential LBA, partition entry array CRC, and for the primary GPT, the GPT at the alternateLBA. Here we were instead checking the GPT at the end of the disk, which may not be the same as the alternateLBA if the disk was grown by a non-partition-aware tool (e.g. in a RAID array). By checking the indicated alternateLBA, we accept more valid GPT-based disks, where before we may have been looking at uninitialized data.