Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix GC thread crash in WimFileSystem dispose#263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
svenclaesson wants to merge1 commit intoDiscUtils:develop
base:develop
Choose a base branch
Loading
fromsvenclaesson:fix_wim_dispose

Conversation

@svenclaesson
Copy link

@svenclaessonsvenclaesson commentedOct 20, 2022
edited
Loading

If this code in constructor of WimFileSystem throws

ShortResourceHeader metaDataFileInfo = _file.LocateImage(index);
if (metaDataFileInfo == null)
{
throw new ArgumentException("No such image: " + index, nameof(index));
}

_metaDataStream is never set

Later the GC will call the deconstructor inDiscFileSystemDispose(false) that will throw when _metaDataStream is not set

This is a major problem for us when trying to work with a corrupt wim-image.

@svenclaesson
Copy link
Author

@LordMike please consider this

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@svenclaesson

[8]ページ先頭

©2009-2025 Movatter.jp