- Notifications
You must be signed in to change notification settings - Fork67
IES updates#965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
AnastaZIuk wants to merge64 commits intomasterChoose a base branch
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Open
IES updates#965
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
small change to make sure `ditt` doesn't autodelete
…ubresource bitflags to not trigger asserts, update examples_tests submodule
…experimental, no real validation), update examples_tests submodule
…arguments in json payload, CI should pass now
…ate examples_tests
…ODO on how to improve it even more
… with GPU converter, encode to EF_A2R10G10B10_UNORM_PACK32, update examples_tests submodule
…/hlsl/ies/sampler.hlsl, wipe CIESProfile::sample, save work (won't compile!)
…32_t & make Nabla compile again
…hlsl/pc.hlsl to allow me precompile unified uber shader, a little formatting, update examples_tests submodule
…add sample function overload to sampler.hlsl, create include/nbl/builtin/hlsl/ies/texture.hlsl to share texel write method between C++ & HLSL (the correct one including blending and corner sampling)TODO: need to update IES viewer example to compile again and clean bindings a bit (keep only octahedral image to write and sample from + add new ies::Texture::SInfo)
…sts & use NBL_CONST_MEMBER_FUNC, update examples_tests submodule
| // ISOTROPIC_BITS = 0b011, texture to sample is Nx1, pretend v=middle always , and make u REPEAT or CLAMP_TO_BORDER | ||
| // FULL_THETA_BIT = 0b100, handle truncated domain and rotate by 45 degrees for anisotropic | ||
| // (certain combos wont work like 90 degree 2 symmetry domain & half theta), it really needs to be an 8 case label thing explicitly enumerated | ||
| vec2 nbl_glsl_IES_convert_dir_to_uv(vec3 dir,vec2 halfMinusHalfPixel) |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TODO: forgot to wipe, not used anymore
| float sum=dot(vec3(1.0f),abs(dir)); | ||
| // TODO: when rewriting to HLSL this is not IES namespace or folder, this should be octahedral mapping sitting somewhere where the spherical/polar sits | ||
| // NOTE: I changed it to return NDC [-1,1]^2 instead of UV coords [0,1]^2 | ||
| vec2 nbl_glsl_TODOnamespace_octahedral_mapping(vec3 dir) |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TODO: forgot to wipe, not used anymore
| # One could not use it at all and rely on C++ intellisense for .hlsl files, | ||
| # but then I found I must right click in a .hlsl file -> Rescan -> Rescan File | ||
| # to resolve include files, "Rescan solution" doesn't work | ||
| target_sources(NablaPRIVATE"${NBL_ROOT_PATH}/include/shadertoolsconfig.json") |
MemberAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
TODO: actually remove it, its better to setup .hlsl exts to target C++ inteli
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.