- Notifications
You must be signed in to change notification settings - Fork67
[WIP] Llvmpipe device#955
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| // erase extensions not supported by llvm | ||
| { | ||
| core::vector<constchar*> llvmUnsupportedExtensions = { | ||
| "VK_NV_shader_image_footprint", | ||
| "VK_KHR_fragment_shader_barycentric", | ||
| "VK_EXT_conservative_rasterization", | ||
| "VK_KHR_external_memory_win32", | ||
| "VK_KHR_shader_subgroup_uniform_control_flow", | ||
| "VK_EXT_pci_bus_info", | ||
| "VK_KHR_external_fence_win32", | ||
| "VK_KHR_external_semaphore_win32", | ||
| "VK_KHR_win32_keyed_mutex", | ||
| "VK_EXT_discard_rectangles" | ||
| "VK_NV_compute_shader_derivatives", | ||
| "VK_NV_shader_sm_builtins" | ||
| }; | ||
| for (constchar* extension : llvmUnsupportedExtensions) | ||
| { | ||
| auto it =std::find_if(extensionStrings.begin(), extensionStrings.end(), [extension](constchar* s) {returnstd::strcmp(s, extension) ==0; }); | ||
| if(it != extensionStrings.end()) | ||
| extensionStrings.erase(it); | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
this can get removed, we achieve much better with Vulkan Configurator & Profile Layer
| "name":"subgroupOpsShaderStages", | ||
| "value":"asset::IShader::E_SHADER_STAGE::ESS_COMPUTE | asset::IShader::E_SHADER_STAGE::ESS_ALL_GRAPHICS" | ||
| "value":"asset::IShader::E_SHADER_STAGE::ESS_UNKNOWN" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
what does llvm-pipe report here ?
| "name":"supportedDepthResolveModes", | ||
| "value":"RESOLVE_MODE_FLAGS::SAMPLE_ZERO_BIT | RESOLVE_MODE_FLAGS::MIN_BIT | RESOLVE_MODE_FLAGS::MAX_BIT" | ||
| "value":"RESOLVE_MODE_FLAGS::SAMPLE_ZERO_BIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if we intend to downgrade Nabla (by merging this PR) then we need to neatly handle this in renderpass creation
| // remove inheritedQueries since llvmpipe doesn't support it | ||
| vk_deviceFeatures2.features.inheritedQueries = VK_FALSE; | ||
| //vk_deviceFeatures2.features = VkPhysicalDeviceFeatures{}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
if we intend to downgrade Nabla permamently, then we need to bringinheritedQueries into the Nabla limits JSON
then check in commandbuffers that when someone is recording an execute secondary commandbuffers command in a primary cmdbuf, no queries are open unlessinheritedQueries limit is true
Description
Testing
TODO list: