- Notifications
You must be signed in to change notification settings - Fork67
Make STL loader/writer and PLY writer work again#901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…sing performActionBasedOnOrientationSystem
…side, comment out some legacy code
| staticinlinevoidperformActionBasedOnOrientationSystem(aType& varToHandle,void (*performOnCertainOrientation)(aType& varToHandle)) | ||
| { | ||
| performOnCertainOrientation(varToHandle); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I decided these functions make no sense for geometries (as an appropriate geometry transform in a collection can be used instead of changing the mesh data), see git blame in PLY loader
| uint32_t topHierarchyLevel; | ||
| IAssetLoader::IAssetLoaderOverride* loaderOverride; | ||
| private: | ||
| const std::string_viewgetPipelineCacheKey(bool withColorAttribute) {return withColorAttribute ?"nbl/builtin/pipeline/loader/STL/color_attribute" :"nbl/builtin/pipeline/loader/STL/no_color_attribute"; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
everything to do with a pipeline needs to go
…into yas_mesh_loaders
…ation in IAssetManager
…into yas_mesh_loaders
…into yas_mesh_loaders
devshgraphicsprogramming commentedJul 31, 2025
@kevyuu can you review this? |
…xt in binary writer
…lling std::find_first_of
…into yas_mesh_loaders
No description provided.