Commiteb6ddb6

authored and

committed

Fixsybrenstuvel#173: unpickling doesn't restore full object

When a `PrivateKey` or `PublicKey` is unpickled `AbstractKey.__init__()`should be called so `self.mutex` and `self.blindfac` are created.

1 parent758562f commiteb6ddb6Copy full SHA for eb6ddb6

File tree

-0

lines changed

-0

lines changed

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -251,6 +251,7 @@ def __getstate__(self) -> typing.Tuple[int, int]:`
`251`	`251`	`def__setstate__(self,state:typing.Tuple[int,int])->None:`
`252`	`252`	`"""Sets the key from tuple."""`
`253`	`253`	`self.n,self.e=state`
	`254`	`+AbstractKey.__init__(self,self.n,self.e)`
`254`	`255`
`255`	`256`	`def__eq__(self,other:typing.Any)->bool:`
`256`	`257`	`ifotherisNone:`
`@@ -426,6 +427,7 @@ def __getstate__(self) -> typing.Tuple[int, int, int, int, int, int, int, int]:`
`426`	`427`	`def__setstate__(self,state:typing.Tuple[int,int,int,int,int,int,int,int])->None:`
`427`	`428`	`"""Sets the key from tuple."""`
`428`	`429`	`self.n,self.e,self.d,self.p,self.q,self.exp1,self.exp2,self.coef=state`
	`430`	`+AbstractKey.__init__(self,self.n,self.e)`
`429`	`431`
`430`	`432`	`def__eq__(self,other:typing.Any)->bool:`
`431`	`433`	`ifotherisNone:`

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -203,10 +203,15 @@ def test_private_key(self):`
`203`	`203`	`unpickled=pickle.loads(pickled)`
`204`	`204`	`self.assertEqual(pk,unpickled)`
`205`	`205`
	`206`	`+forattrinrsa.key.AbstractKey.__slots__:`
	`207`	`+self.assertTrue(hasattr(unpickled,attr))`
	`208`	`+`
`206`	`209`	`deftest_public_key(self):`
`207`	`210`	`pk=rsa.key.PublicKey(3727264081,65537)`
`208`	`211`
`209`	`212`	`pickled=pickle.dumps(pk)`
`210`	`213`	`unpickled=pickle.loads(pickled)`
`211`	`214`
`212`	`215`	`self.assertEqual(pk,unpickled)`
	`216`	`+forattrinrsa.key.AbstractKey.__slots__:`
	`217`	`+self.assertTrue(hasattr(unpickled,attr))`

Comments

(0)