Movatterモバイル変換

Skip to content

DevYukine/KurasutaPublic

NotificationsYou must be signed in to change notification settings
Fork23
Star161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

[Feat] Use type-safe EventEmitter interface#402

Open

jonahsnider wants to merge2 commits intoDevYukine:master

base:master

Choose a base branch

fromdice-discord:feat/typed-event-emitter

Open

[Feat] Use type-safe EventEmitter interface#402

jonahsnider wants to merge2 commits intoDevYukine:masterfromdice-discord:feat/typed-event-emitter

+39 −43

Conversation

jonahsnider

Copy link

jonahsnider commentedMar 15, 2021•
edited
Loading

This replaces theSharderEvents enum with an object type that maps event names to listener function signatures. In combination with theTypedEventEmitter interface from@pizzafox/util this means TypeScript users get automatic type-checking of their event listeners, and the library gets safe calls toemit.

In fact, implementing this revealed 2 non-compliantShardingManager#emit usages:

Kurasuta/src/IPC/MasterIPC.ts

Lines 62 to 66 in16a2cfb

	private_shardready(message:NodeMessage){
	const{d:{ shardID}}=message.data;
	this._debug(`Shard${shardID} became ready`);
	this.manager.emit(SharderEvents.SHARD_READY,shardID);
	}

Kurasuta/src/IPC/MasterIPC.ts

Lines 68 to 72 in16a2cfb

	private_shardreconnect(message:NodeMessage){
	const{d:{ shardID}}=message.data;
	this._debug(`Shard${shardID} tries to reconnect`);
	this.manager.emit(SharderEvents.SHARD_RECONNECT,shardID);
	}

Adding the dependency will slightly increase bundle size, even though it's just used at build-time for TypeScript users.The official recommendation is to list it in thedependencies field ofpackage.json.

In its current state this PR is a breaking change sinceSharderEvents is no longer an enum. This could easily be changed back to anenum and rename the new type to something likeSharderEventListeners.

jonahsnider added2 commits

March 15, 2021 00:52

@jonahsnider

[Feat] Use type-safe EventEmitter interface

2687c68

@jonahsnider

[Style] Remove trailing comma

8e265ef

@DevYukine

Copy link

Owner

DevYukine commentedMar 18, 2021

This seems interesting, i will have a look on the weekend at it 👍

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

None yet

2 participants

@jonahsnider

@DevYukine

[8]ページ先頭

©2009-2025 Movatter.jp