Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

TracerFlare: save original log level as indication we are currently collecting#1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@Aaalibaba42
Copy link
Contributor

@Aaalibaba42Aaalibaba42 commentedOct 21, 2025
edited
Loading

What does this PR do?

Change the collecting boolean field to an Option (inside a Mutex for reasons, but that's beside the point) in the TracerFlareManager. Also adding aoriginal_log_level field that is managed by the integrater code.

Motivation

Basically, the integration will have to restore original log level after the Flare is sent, which is impractical because it therefore needs to be saved in a "global" state somewhere. But the TracerFlareManager already has this global scope requirement, thus storing the original log level in it makes sens. The change of thecollecting field is just about simplifying the API, since now functions likezip_and_send take less arguments and stuff.

Additional Notes

Anticipating what's going through FFIs once it's implemented could be interesting.

How to test the change?

cargo test (it's still the design phase, it's not integrated anywhere).

ppitou reacted with rocket emoji
@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch from5314358 to88afef4CompareOctober 21, 2025 14:57
@pr-commenter
Copy link

pr-commenterbot commentedOct 21, 2025
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-11-10 14:56:26

Comparing candidate commit022cce8 in PR branchjwiriath/add-debug-levels-in-tracerflare-cc with baseline commitc9a8858 in branchmain.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
credit_card/is_card_number/execution_time3.896µs3.913µs ± 0.003µs3.913µs ± 0.001µs3.914µs3.918µs3.920µs3.923µs0.26%-0.3737.0300.07%0.000µs1200
credit_card/is_card_number/throughput254927653.806op/s255561761.551op/s ± 181069.161op/s255580652.545op/s ± 97175.786op/s255665232.985op/s255789294.336op/s255882060.589op/s256667428.502op/s0.43%0.3927.1190.07%12803.523op/s1200
credit_card/is_card_number/ 3782-8224-6310-005execution_time78.936µs81.985µs ± 1.069µs81.922µs ± 0.720µs82.657µs83.755µs84.501µs85.034µs3.80%0.0490.0291.30%0.076µs1200
credit_card/is_card_number/ 3782-8224-6310-005throughput11759965.902op/s12199466.281op/s ± 159002.404op/s12206746.602op/s ± 107266.939op/s12308258.073op/s12450771.508op/s12566337.056op/s12668436.128op/s3.78%0.0310.0571.30%11243.168op/s1200
credit_card/is_card_number/ 378282246310005execution_time71.422µs72.077µs ± 0.818µs71.664µs ± 0.183µs72.300µs74.285µs74.357µs74.369µs3.78%1.6671.8231.13%0.058µs1200
credit_card/is_card_number/ 378282246310005throughput13446426.486op/s13875761.237op/s ± 154664.777op/s13954070.677op/s ± 35682.684op/s13983370.257op/s13991203.199op/s13999541.711op/s14001240.167op/s0.34%-1.6321.7021.11%10936.451op/s1200
credit_card/is_card_number/37828224631execution_time3.893µs3.913µs ± 0.003µs3.913µs ± 0.002µs3.914µs3.918µs3.922µs3.929µs0.41%-0.0729.2260.08%0.000µs1200
credit_card/is_card_number/37828224631throughput254511859.994op/s255566503.347op/s ± 207862.749op/s255560630.892op/s ± 123378.029op/s255701909.999op/s255815935.510op/s255877610.877op/s256840849.512op/s0.50%0.0999.2960.08%14698.116op/s1200
credit_card/is_card_number/378282246310005execution_time68.254µs69.062µs ± 0.723µs68.854µs ± 0.404µs69.346µs70.542µs71.130µs71.690µs4.12%1.1890.8571.04%0.051µs1200
credit_card/is_card_number/378282246310005throughput13948936.119op/s14481268.784op/s ± 149860.802op/s14523573.939op/s ± 84716.669op/s14602299.826op/s14636877.418op/s14645493.152op/s14651153.015op/s0.88%-1.1450.7071.03%10596.759op/s1200
credit_card/is_card_number/37828224631000521389798execution_time45.346µs45.667µs ± 0.126µs45.685µs ± 0.089µs45.759µs45.883µs45.909µs45.941µs0.56%-0.109-0.5740.27%0.009µs1200
credit_card/is_card_number/37828224631000521389798throughput21767178.851op/s21897650.326op/s ± 60299.790op/s21889121.118op/s ± 42462.150op/s21942366.871op/s21998263.604op/s22023068.348op/s22052550.725op/s0.75%0.121-0.5710.27%4263.839op/s1200
credit_card/is_card_number/x371413321323331execution_time6.429µs6.436µs ± 0.004µs6.435µs ± 0.003µs6.439µs6.444µs6.447µs6.449µs0.21%0.687-0.2680.06%0.000µs1200
credit_card/is_card_number/x371413321323331throughput155072749.976op/s155374297.773op/s ± 99725.350op/s155400225.337op/s ± 67286.431op/s155448970.312op/s155498936.199op/s155529959.904op/s155540468.597op/s0.09%-0.685-0.2730.06%7051.647op/s1200
credit_card/is_card_number_no_luhn/execution_time3.892µs3.913µs ± 0.003µs3.913µs ± 0.002µs3.915µs3.918µs3.921µs3.922µs0.23%-1.1559.6290.08%0.000µs1200
credit_card/is_card_number_no_luhn/throughput254982381.675op/s255560252.450op/s ± 197276.775op/s255561065.336op/s ± 136665.835op/s255698968.293op/s255781164.684op/s255872081.391op/s256908770.349op/s0.53%1.1799.8010.08%13949.575op/s1200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005execution_time61.432µs62.757µs ± 0.594µs62.771µs ± 0.378µs63.095µs63.787µs64.092µs64.393µs2.58%0.158-0.2220.94%0.042µs1200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005throughput15529560.959op/s15935880.654op/s ± 150637.107op/s15930840.648op/s ± 95891.722op/s16037223.328op/s16184259.675op/s16250663.654op/s16278116.223op/s2.18%-0.109-0.2430.94%10651.652op/s1200
credit_card/is_card_number_no_luhn/ 378282246310005execution_time54.054µs54.255µs ± 0.088µs54.257µs ± 0.060µs54.307µs54.404µs54.478µs54.514µs0.47%0.241-0.1810.16%0.006µs1200
credit_card/is_card_number_no_luhn/ 378282246310005throughput18343937.121op/s18431548.437op/s ± 29896.343op/s18430754.735op/s ± 20254.837op/s18452837.317op/s18478836.652op/s18496249.072op/s18500173.902op/s0.38%-0.232-0.1880.16%2113.991op/s1200
credit_card/is_card_number_no_luhn/37828224631execution_time3.893µs3.912µs ± 0.003µs3.912µs ± 0.002µs3.914µs3.916µs3.918µs3.921µs0.22%-1.43812.5750.07%0.000µs1200
credit_card/is_card_number_no_luhn/37828224631throughput255057034.585op/s255605172.877op/s ± 173079.118op/s255620347.380op/s ± 100401.779op/s255705126.773op/s255811488.315op/s255869504.535op/s256861085.184op/s0.49%1.46312.7740.07%12238.542op/s1200
credit_card/is_card_number_no_luhn/378282246310005execution_time50.332µs50.508µs ± 0.087µs50.501µs ± 0.056µs50.558µs50.661µs50.719µs50.850µs0.69%0.6100.5630.17%0.006µs1200
credit_card/is_card_number_no_luhn/378282246310005throughput19665669.710op/s19798820.406op/s ± 34259.265op/s19801752.455op/s ± 21780.265op/s19822739.672op/s19847802.842op/s19859606.192op/s19867972.307op/s0.33%-0.5990.5360.17%2422.496op/s1200
credit_card/is_card_number_no_luhn/37828224631000521389798execution_time45.375µs45.714µs ± 0.132µs45.727µs ± 0.085µs45.807µs45.917µs45.950µs45.971µs0.53%-0.320-0.3880.29%0.009µs1200
credit_card/is_card_number_no_luhn/37828224631000521389798throughput21753077.539op/s21875457.593op/s ± 63263.772op/s21869061.841op/s ± 40870.512op/s21913363.322op/s21989488.537op/s22023553.379op/s22038558.622op/s0.78%0.333-0.3760.29%4473.424op/s1200
credit_card/is_card_number_no_luhn/x371413321323331execution_time6.429µs6.436µs ± 0.004µs6.435µs ± 0.003µs6.438µs6.444µs6.450µs6.454µs0.29%1.1821.9370.07%0.000µs1200
credit_card/is_card_number_no_luhn/x371413321323331throughput154946160.444op/s155381317.803op/s ± 104641.701op/s155399169.252op/s ± 62668.683op/s155458721.823op/s155510991.527op/s155533483.248op/s155545574.853op/s0.09%-1.1771.9170.07%7399.286op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
credit_card/is_card_number/execution_time[3.913µs; 3.913µs] or [-0.010%; +0.010%]NoneNoneNone
credit_card/is_card_number/throughput[255536667.107op/s; 255586855.996op/s] or [-0.010%; +0.010%]NoneNoneNone
credit_card/is_card_number/ 3782-8224-6310-005execution_time[81.837µs; 82.133µs] or [-0.181%; +0.181%]NoneNoneNone
credit_card/is_card_number/ 3782-8224-6310-005throughput[12177430.077op/s; 12221502.485op/s] or [-0.181%; +0.181%]NoneNoneNone
credit_card/is_card_number/ 378282246310005execution_time[71.964µs; 72.191µs] or [-0.157%; +0.157%]NoneNoneNone
credit_card/is_card_number/ 378282246310005throughput[13854326.187op/s; 13897196.288op/s] or [-0.154%; +0.154%]NoneNoneNone
credit_card/is_card_number/37828224631execution_time[3.912µs; 3.913µs] or [-0.011%; +0.011%]NoneNoneNone
credit_card/is_card_number/37828224631throughput[255537695.569op/s; 255595311.125op/s] or [-0.011%; +0.011%]NoneNoneNone
credit_card/is_card_number/378282246310005execution_time[68.962µs; 69.162µs] or [-0.145%; +0.145%]NoneNoneNone
credit_card/is_card_number/378282246310005throughput[14460499.519op/s; 14502038.050op/s] or [-0.143%; +0.143%]NoneNoneNone
credit_card/is_card_number/37828224631000521389798execution_time[45.650µs; 45.685µs] or [-0.038%; +0.038%]NoneNoneNone
credit_card/is_card_number/37828224631000521389798throughput[21889293.355op/s; 21906007.297op/s] or [-0.038%; +0.038%]NoneNoneNone
credit_card/is_card_number/x371413321323331execution_time[6.436µs; 6.437µs] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number/x371413321323331throughput[155360476.799op/s; 155388118.748op/s] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/execution_time[3.913µs; 3.913µs] or [-0.011%; +0.011%]NoneNoneNone
credit_card/is_card_number_no_luhn/throughput[255532911.786op/s; 255587593.114op/s] or [-0.011%; +0.011%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005execution_time[62.675µs; 62.839µs] or [-0.131%; +0.131%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005throughput[15915003.800op/s; 15956757.508op/s] or [-0.131%; +0.131%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 378282246310005execution_time[54.243µs; 54.267µs] or [-0.022%; +0.022%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 378282246310005throughput[18427405.091op/s; 18435691.782op/s] or [-0.022%; +0.022%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631execution_time[3.912µs; 3.913µs] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631throughput[255581185.775op/s; 255629159.978op/s] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/378282246310005execution_time[50.496µs; 50.520µs] or [-0.024%; +0.024%]NoneNoneNone
credit_card/is_card_number_no_luhn/378282246310005throughput[19794072.401op/s; 19803568.411op/s] or [-0.024%; +0.024%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631000521389798execution_time[45.695µs; 45.732µs] or [-0.040%; +0.040%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631000521389798throughput[21866689.842op/s; 21884225.343op/s] or [-0.040%; +0.040%]NoneNoneNone
credit_card/is_card_number_no_luhn/x371413321323331execution_time[6.435µs; 6.436µs] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/x371413321323331throughput[155366815.469op/s; 155395820.136op/s] or [-0.009%; +0.009%]NoneNoneNone

Group 2

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_trace/test_traceexecution_time242.417ns253.937ns ± 15.158ns245.807ns ± 2.608ns258.965ns285.291ns301.570ns305.165ns24.15%1.5821.7065.95%1.072ns1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_trace/test_traceexecution_time[251.836ns; 256.038ns] or [-0.827%; +0.827%]NoneNoneNone

Group 3

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
write only interfaceexecution_time1.211µs3.265µs ± 1.465µs3.032µs ± 0.026µs3.058µs3.706µs14.598µs14.924µs392.26%7.29254.44144.75%0.104µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
write only interfaceexecution_time[3.062µs; 3.468µs] or [-6.217%; +6.217%]NoneNoneNone

Group 4

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...execution_time205.028µs205.554µs ± 0.311µs205.497µs ± 0.182µs205.703µs206.192µs206.425µs206.510µs0.49%0.9610.4760.15%0.022µs1200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...throughput4842384.317op/s4864906.653op/s ± 7341.761op/s4866247.889op/s ± 4316.564op/s4870279.288op/s4874119.989op/s4876353.450op/s4877390.960op/s0.23%-0.9540.4600.15%519.141op/s1200
normalization/normalize_name/normalize_name/bad-nameexecution_time18.622µs18.830µs ± 0.106µs18.824µs ± 0.073µs18.899µs19.004µs19.117µs19.173µs1.85%0.6400.2420.56%0.007µs1200
normalization/normalize_name/normalize_name/bad-namethroughput52156886.145op/s53108494.474op/s ± 296853.196op/s53122344.587op/s ± 207553.940op/s53329609.300op/s53509254.859op/s53618971.034op/s53699533.815op/s1.09%-0.6090.1820.56%20990.691op/s1200
normalization/normalize_name/normalize_name/goodexecution_time10.797µs10.871µs ± 0.034µs10.870µs ± 0.023µs10.893µs10.928µs10.952µs10.988µs1.09%0.2690.1630.31%0.002µs1200
normalization/normalize_name/normalize_name/goodthroughput91011218.001op/s91992188.373op/s ± 287579.551op/s91999065.966op/s ± 191707.006op/s92187302.114op/s92426598.374op/s92609359.553op/s92616879.320op/s0.67%-0.2490.1380.31%20334.945op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...execution_time[205.511µs; 205.597µs] or [-0.021%; +0.021%]NoneNoneNone
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...throughput[4863889.156op/s; 4865924.151op/s] or [-0.021%; +0.021%]NoneNoneNone
normalization/normalize_name/normalize_name/bad-nameexecution_time[18.815µs; 18.845µs] or [-0.078%; +0.078%]NoneNoneNone
normalization/normalize_name/normalize_name/bad-namethroughput[53067353.476op/s; 53149635.472op/s] or [-0.077%; +0.077%]NoneNoneNone
normalization/normalize_name/normalize_name/goodexecution_time[10.866µs; 10.875µs] or [-0.043%; +0.043%]NoneNoneNone
normalization/normalize_name/normalize_name/goodthroughput[91952332.613op/s; 92032044.133op/s] or [-0.043%; +0.043%]NoneNoneNone

Group 5

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
redis/obfuscate_redis_stringexecution_time34.539µs34.996µs ± 0.713µs34.679µs ± 0.078µs34.793µs36.494µs36.559µs37.859µs9.17%1.7621.5512.03%0.050µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
redis/obfuscate_redis_stringexecution_time[34.897µs; 35.095µs] or [-0.282%; +0.282%]NoneNoneNone

Group 6

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
sdk_test_data/rules-basedexecution_time121.511µs123.573µs ± 1.338µs123.372µs ± 0.489µs123.885µs125.233µs129.254µs134.860µs9.31%4.09527.9971.08%0.095µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
sdk_test_data/rules-basedexecution_time[123.388µs; 123.759µs] or [-0.150%; +0.150%]NoneNoneNone

Group 7

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
concentrator/add_spans_to_concentratorexecution_time10.664ms10.691ms ± 0.014ms10.690ms ± 0.007ms10.697ms10.712ms10.735ms10.760ms0.65%1.5105.2160.13%0.001ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
concentrator/add_spans_to_concentratorexecution_time[10.689ms; 10.693ms] or [-0.018%; +0.018%]NoneNoneNone

Group 8

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
single_flag_killswitch/rules-basedexecution_time170.983ns174.831ns ± 3.583ns174.052ns ± 1.986ns175.906ns182.000ns186.571ns193.769ns11.33%1.8785.1512.04%0.253ns1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
single_flag_killswitch/rules-basedexecution_time[174.335ns; 175.328ns] or [-0.284%; +0.284%]NoneNoneNone

Group 9

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
tags/replace_trace_tagsexecution_time2.308µs2.386µs ± 0.020µs2.389µs ± 0.007µs2.394µs2.415µs2.419µs2.423µs1.42%-1.7594.3890.83%0.001µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
tags/replace_trace_tagsexecution_time[2.384µs; 2.389µs] or [-0.115%; +0.115%]NoneNoneNone

Group 10

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
two way interfaceexecution_time17.830µs25.800µs ± 9.620µs18.112µs ± 0.208µs34.571µs42.741µs43.659µs60.337µs233.13%0.817-0.13937.19%0.680µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
two way interfaceexecution_time[24.466µs; 27.133µs] or [-5.168%; +5.168%]NoneNoneNone

Group 11

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching serializing traces from their internal representation to msgpackexecution_time14.251ms14.293ms ± 0.034ms14.287ms ± 0.010ms14.296ms14.350ms14.441ms14.513ms1.59%3.26013.7550.24%0.002ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching serializing traces from their internal representation to msgpackexecution_time[14.288ms; 14.298ms] or [-0.033%; +0.033%]NoneNoneNone

Group 12

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching string interning on wordpress profileexecution_time160.982µs161.917µs ± 0.288µs161.917µs ± 0.139µs162.054µs162.268µs162.967µs163.964µs1.26%2.03914.1830.18%0.020µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching string interning on wordpress profileexecution_time[161.877µs; 161.957µs] or [-0.025%; +0.025%]NoneNoneNone

Group 13

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...execution_time534.479µs535.669µs ± 0.873µs535.407µs ± 0.363µs535.931µs537.447µs538.450µs540.777µs1.00%2.0996.5250.16%0.062µs1200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...throughput1849192.077op/s1866827.692op/s ± 3032.155op/s1867736.667op/s ± 1265.164op/s1868711.631op/s1869939.586op/s1870530.759op/s1870981.517op/s0.17%-2.0796.3840.16%214.406op/s1200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててexecution_time379.851µs380.569µs ± 0.314µs380.531µs ± 0.194µs380.770µs381.124µs381.423µs381.632µs0.29%0.5670.4070.08%0.022µs1200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててthroughput2620327.131op/s2627646.440op/s ± 2167.064op/s2627904.842op/s ± 1341.777op/s2629144.206op/s2630778.502op/s2631712.262op/s2632611.811op/s0.18%-0.5620.3970.08%153.235op/s1200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersexecution_time189.850µs190.415µs ± 0.201µs190.418µs ± 0.137µs190.555µs190.734µs190.936µs190.992µs0.30%0.0910.0410.11%0.014µs1200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersthroughput5235817.284op/s5251686.063op/s ± 5554.953op/s5251605.399op/s ± 3789.385op/s5255403.236op/s5261035.070op/s5263700.328op/s5267316.996op/s0.30%-0.0850.0380.11%392.794op/s1200
normalization/normalize_service/normalize_service/[empty string]execution_time37.731µs37.877µs ± 0.056µs37.877µs ± 0.035µs37.911µs37.968µs37.990µs38.014µs0.36%-0.166-0.2170.15%0.004µs1200
normalization/normalize_service/normalize_service/[empty string]throughput26306048.617op/s26401554.268op/s ± 39123.691op/s26400897.631op/s ± 24496.329op/s26426247.249op/s26470516.075op/s26491629.626op/s26503625.978op/s0.39%0.174-0.2140.15%2766.463op/s1200
normalization/normalize_service/normalize_service/test_ASCIIexecution_time45.794µs45.911µs ± 0.042µs45.910µs ± 0.021µs45.931µs45.975µs46.020µs46.110µs0.44%0.6532.7280.09%0.003µs1200
normalization/normalize_service/normalize_service/test_ASCIIthroughput21687280.025op/s21781359.754op/s ± 20032.000op/s21781960.401op/s ± 9785.168op/s21790683.299op/s21814340.908op/s21822603.054op/s21836762.918op/s0.25%-0.6412.6910.09%1416.476op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...execution_time[535.548µs; 535.790µs] or [-0.023%; +0.023%]NoneNoneNone
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...throughput[1866407.464op/s; 1867247.919op/s] or [-0.023%; +0.023%]NoneNoneNone
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててexecution_time[380.525µs; 380.612µs] or [-0.011%; +0.011%]NoneNoneNone
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててthroughput[2627346.106op/s; 2627946.775op/s] or [-0.011%; +0.011%]NoneNoneNone
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersexecution_time[190.387µs; 190.443µs] or [-0.015%; +0.015%]NoneNoneNone
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersthroughput[5250916.200op/s; 5252455.926op/s] or [-0.015%; +0.015%]NoneNoneNone
normalization/normalize_service/normalize_service/[empty string]execution_time[37.869µs; 37.884µs] or [-0.021%; +0.021%]NoneNoneNone
normalization/normalize_service/normalize_service/[empty string]throughput[26396132.101op/s; 26406976.435op/s] or [-0.021%; +0.021%]NoneNoneNone
normalization/normalize_service/normalize_service/test_ASCIIexecution_time[45.905µs; 45.917µs] or [-0.013%; +0.013%]NoneNoneNone
normalization/normalize_service/normalize_service/test_ASCIIthroughput[21778583.511op/s; 21784135.996op/s] or [-0.013%; +0.013%]NoneNoneNone

Group 14

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
receiver_entry_point/report/2597execution_time6.065ms6.385ms ± 0.055ms6.387ms ± 0.017ms6.404ms6.438ms6.535ms6.713ms5.11%-1.06516.3860.86%0.004ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
receiver_entry_point/report/2597execution_time[6.378ms; 6.393ms] or [-0.120%; +0.120%]NoneNoneNone

Group 15

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching deserializing traces from msgpack to their internal representationexecution_time60.310ms60.822ms ± 2.383ms60.466ms ± 0.056ms60.543ms60.969ms79.710ms80.420ms33.00%7.90960.9603.91%0.169ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching deserializing traces from msgpack to their internal representationexecution_time[60.492ms; 61.152ms] or [-0.543%; +0.543%]NoneNoneNone

Group 16

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
sql/obfuscate_sql_stringexecution_time84.902µs85.212µs ± 0.177µs85.194µs ± 0.073µs85.270µs85.365µs85.488µs87.148µs2.29%6.79070.8310.21%0.012µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
sql/obfuscate_sql_stringexecution_time[85.187µs; 85.236µs] or [-0.029%; +0.029%]NoneNoneNone

Group 17

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz022cce81762785642jwiriath/add-debug-levels-in-tracerflare-cc
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
ip_address/quantize_peer_ip_address_benchmarkexecution_time4.943µs5.038µs ± 0.053µs5.038µs ± 0.051µs5.063µs5.122µs5.128µs5.130µs1.82%0.159-1.0481.04%0.004µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
ip_address/quantize_peer_ip_address_benchmarkexecution_time[5.031µs; 5.046µs] or [-0.145%; +0.145%]NoneNoneNone

Baseline

Omitted due to size.

@dd-octo-sts
Copy link

dd-octo-stsbot commentedOct 21, 2025
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
ArtifactBaselineCommitChange
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so7.57 MB7.57 MB0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a83.06 MB83.06 MB0% (0 B) 👌
aarch64-unknown-linux-gnu
ArtifactBaselineCommitChange
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a96.24 MB96.24 MB0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so9.55 MB9.55 MB0% (0 B) 👌
libdatadog-x64-windows
ArtifactBaselineCommitChange
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll18.94 MB18.94 MB0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib52.37 KB52.37 KB0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb131.56 MB131.55 MB-0% (-8.00 KB) 👌
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib693.77 MB693.77 MB0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll6.26 MB6.26 MB0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib52.37 KB52.37 KB0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb18.92 MB18.92 MB0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib36.55 MB36.55 MB0% (0 B) 👌
libdatadog-x86-windows
ArtifactBaselineCommitChange
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll16.03 MB16.03 MB0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib53.19 KB53.19 KB0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb133.76 MB133.76 MB0% (0 B) 👌
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib681.69 MB681.69 MB0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll4.80 MB4.80 MB0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib53.19 KB53.19 KB0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb20.06 MB20.06 MB0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib34.32 MB34.32 MB0% (0 B) 👌
x86_64-alpine-linux-musl
ArtifactBaselineCommitChange
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a72.00 MB72.00 MB0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so8.92 MB8.92 MB0% (0 B) 👌
x86_64-unknown-linux-gnu
ArtifactBaselineCommitChange
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a90.99 MB90.99 MB0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so10.28 MB10.28 MB0% (0 B) 👌

@codecov-commenter
Copy link

codecov-commenter commentedOct 21, 2025
edited
Loading

Codecov Report

❌ Patch coverage is2.27273% with86 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.36%. Comparing base (c9a8858) to head (022cce8).

Additional details and impacted files
@@            Coverage Diff             @@##             main    #1272      +/-   ##==========================================- Coverage   71.42%   71.36%   -0.06%==========================================  Files         375      375                Lines       59469    59485      +16     ==========================================- Hits        42475    42454      -21- Misses      16994    17031      +37
ComponentsCoverage Δ
datadog-crashtracker54.43% <ø> (ø)
datadog-crashtracker-ffi18.37% <ø> (ø)
datadog-alloc∅ <ø> (∅)
data-pipeline∅ <ø> (∅)
data-pipeline-ffi∅ <ø> (∅)
ddcommon∅ <ø> (∅)
ddcommon-ffi∅ <ø> (∅)
ddtelemetry∅ <ø> (∅)
ddtelemetry-ffi∅ <ø> (∅)
dogstatsd-client∅ <ø> (∅)
datadog-ipc82.59% <ø> (-0.07%)⬇️
datadog-profiling75.93% <ø> (ø)
datadog-profiling-ffi62.16% <ø> (ø)
datadog-sidecar36.72% <ø> (ø)
datdog-sidecar-ffi11.53% <ø> (ø)
spawn-worker55.18% <ø> (ø)
tinybytes∅ <ø> (∅)
datadog-trace-normalization∅ <ø> (∅)
datadog-trace-obfuscation94.17% <ø> (ø)
datadog-trace-protobuf∅ <ø> (∅)
datadog-trace-utils∅ <ø> (∅)
datadog-tracer-flare62.25% <2.27%> (-1.23%)⬇️
datadog-log∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch 4 times, most recently from49d542a to512c624CompareOctober 22, 2025 10:05
@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch from512c624 to6cdb6e4CompareOctober 22, 2025 10:14
@datadog-official
Copy link

datadog-officialbot commentedOct 22, 2025
edited by datadog-datadog-prod-us1bot
Loading

✅ Tests

🎉 All green!

❄️ No newflaky tests detected
🧪 Alltests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA:022cce8 |Docs |Datadog PR Page | Was this helpful? Give usfeedback!

@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch from0b8b3db to67e886fCompareOctober 22, 2025 13:08
@Aaalibaba42Aaalibaba42 marked this pull request as ready for reviewOctober 22, 2025 13:12
@Aaalibaba42Aaalibaba42 requested a review froma team as acode ownerOctober 22, 2025 13:12
Copy link
Contributor

@anais-raisonanais-raison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In the end after thinking about it and writing my comments I don't know anymore if keeping thecurrent_log_level overcollecting is that much of a better choice.

@Aaalibaba42Aaalibaba42 requested a review froma team as acode ownerOctober 23, 2025 10:36
@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch 2 times, most recently from60ad4cc to476b25dCompareOctober 23, 2025 11:39
@Aaalibaba42Aaalibaba42force-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch from476b25d to5ddde0fCompareOctober 23, 2025 11:46
@anais-raisonanais-raison requested review froma team ascode ownersNovember 10, 2025 13:50
@anais-raisonanais-raison requested review froma team ascode ownersNovember 10, 2025 13:50
@anais-raisonanais-raison marked this pull request as draftNovember 10, 2025 13:55
@anais-raisonanais-raison removed request fora teamNovember 10, 2025 13:55
@anais-raisonanais-raisonforce-pushed thejwiriath/add-debug-levels-in-tracerflare-cc branch fromb8c6214 tod10fff8CompareNovember 10, 2025 14:14
@anais-raisonanais-raison marked this pull request as ready for reviewNovember 10, 2025 14:28
Copy link
Contributor

@anais-raisonanais-raison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM ;)

@anais-raison
Copy link
Contributor

/merge

@dd-devflow-routing-codex
Copy link

dd-devflow-routing-codexbot commentedNov 10, 2025
edited
Loading

View all feedbacks in Devflow UI.

2025-11-10 15:25:05 UTC ℹ️ Start processing command/merge


2025-11-10 15:25:10 UTC ℹ️MergeQueue: pull request added to thequeue

The expected merge time inmain is approximately 34m (p90).


2025-11-10 15:55:47 UTC ℹ️MergeQueue: This merge request was merged

@dd-mergequeuedd-mergequeuebot merged commit1c29e2b intomainNov 10, 2025
37 checks passed
@dd-mergequeuedd-mergequeuebot deleted the jwiriath/add-debug-levels-in-tracerflare-cc branchNovember 10, 2025 15:55
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@anais-raisonanais-raisonanais-raison approved these changes

@paullegranddcpaullegranddcAwaiting requested review from paullegranddcpaullegranddc was automatically assigned from DataDog/libdatadog-telemetry

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Aaalibaba42@codecov-commenter@anais-raison

[8]ページ先頭

©2009-2025 Movatter.jp