Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[crashtracking] upload to both telemetry intake and errors intake#1259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
gyuheon0h wants to merge23 commits intomain
base:main
Choose a base branch
Loading
fromgyuheon0h/prof-12603-dual-uploads

Conversation

@gyuheon0h
Copy link
Contributor

@gyuheon0hgyuheon0h commentedOct 3, 2025•
edited
Loading

What does this PR do?

With the new Errors intake, we want to support dual uploads to Errors intake and the current telemetry intake

Motivation

What inspired you to submit this pull request?

Additional Notes

Errors Intake endpoints and conditions; this was largely follows howTelemetry handlesCrashInfo uploads

  1. Agent Proxy Mode
  • Endpoint:http://localhost:8126/evp_proxy/v4/api/v2/errorsintake
  • Path: /evp_proxy/v4/api/v2/errorsintake
  • When used: Default behavior - when either condition is true:
    • No DD_API_KEY is set
    • _DD_DIRECT_SUBMISSION_ENABLED is false/unset
  • Headers: X-Datadog-EVP-Subdomain: event-platform-intake
  • Authentication: No API key needed (agent handles it)
  1. Direct Errors Intake Submission
  • Endpoint:https://event-platform-intake.{site}/api/v2/errorsintake
  • Path: /api/v2/errorsintake
  • When used: When both conditions are met:
    • _DD_DIRECT_SUBMISSION_ENABLED=true
    • DD_API_KEY is set
  • Headers: DD-API-KEY: {api_key} (added automatically)
  • Default site: event-platform-intake.datad0g.com
  1. Custom Agent Host/Port
  • Endpoint: http://{host}:{port}/evp_proxy/v4/api/v2/errorsintake
  • When used: Agent proxy mode with custom location
  • Config: DD_AGENT_HOST and/or DD_TRACE_AGENT_PORT
  • Defaults: host=localhost, port=8126
  1. Unix Domain Socket (UDS)
  • Endpoint: unix:///var/run/datadog/apm.socket/evp_proxy/v4/api/v2/errorsintake
  • When used: Unix systems when socket file exists at /var/run/datadog/apm.socket
  • Priority: Used as fallback when explicit host/port not configured
  • Path: Still uses agent proxy path
  1. Windows Named Pipes
  • Endpoint: windows:{pipe_name}/evp_proxy/v4/api/v2/errorsintake
  • When used: Windows systems with DD_TRACE_PIPE_NAME set
  • Config: DD_TRACE_PIPE_NAME environment variable
  • Path: Uses agent proxy path
  1. Direct Agent URL Override
  • Endpoint: {DD_TRACE_AGENT_URL}/evp_proxy/v4/api/v2/errorsintake
  • When used: When DD_TRACE_AGENT_URL is explicitly set
  • Supports: http://, https://, unix:// schemes
  • Path: Agent proxy path appended to custom URL
  1. File Endpoint (Testing)
  • Endpoint: file://{path}.errors
  • When used: Testing/debugging with file:// URLs
  • Behavior: Writes JSON payload to file instead of HTTP request
  • File extension: Automatically appends .errors to the base path

How to test the change?

Unit tests
Run a tracer that points to the latest commit on this PR for libdatadog locally and crash a program
https://dd.datad0g.com/error-tracking?query=service%3Atest_app&fromUser=false&order=first_seen&refresh_mode=sliding&source=all&from_ts=1759843044695&to_ts=1760447844695&live=true

@pr-commenter
Copy link

pr-commenterbot commentedOct 3, 2025•
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-11-12 10:44:08

Comparing candidate commita725ec2 in PR branchgyuheon0h/prof-12603-dual-uploads with baseline commit1b7b2da in branchmain.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 2 unstable metrics.

scenario:sdk_test_data/rules-based

  • 🟩execution_time [-23.470µs; -22.866µs] or [-16.010%; -15.598%]

Candidate

Candidate benchmark details

Group 1

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
receiver_entry_point/report/2597execution_time6.279ms6.490ms ± 0.055ms6.493ms ± 0.020ms6.513ms6.574ms6.655ms6.684ms2.93%-0.3272.8510.85%0.004ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
receiver_entry_point/report/2597execution_time[6.483ms; 6.498ms] or [-0.118%; +0.118%]NoneNoneNone

Group 2

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...execution_time204.682µs205.349µs ± 0.370µs205.295µs ± 0.250µs205.590µs205.999µs206.335µs206.754µs0.71%0.7160.5030.18%0.026µs1200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...throughput4836656.312op/s4869780.050op/s ± 8768.781op/s4871030.258op/s ± 5941.305op/s4875958.579op/s4882009.677op/s4883856.907op/s4885637.783op/s0.30%-0.7050.4740.18%620.046op/s1200
normalization/normalize_name/normalize_name/bad-nameexecution_time18.556µs18.621µs ± 0.065µs18.601µs ± 0.016µs18.628µs18.770µs18.862µs19.004µs2.17%2.8889.9850.35%0.005µs1200
normalization/normalize_name/normalize_name/bad-namethroughput52621253.909op/s53703103.492op/s ± 185724.447op/s53760956.154op/s ± 47058.269op/s53798796.748op/s53846875.091op/s53885593.229op/s53890619.061op/s0.24%-2.8519.6890.34%13132.702op/s1200
normalization/normalize_name/normalize_name/goodexecution_time10.709µs10.791µs ± 0.026µs10.793µs ± 0.015µs10.806µs10.834µs10.857µs10.869µs0.71%-0.1200.7090.24%0.002µs1200
normalization/normalize_name/normalize_name/goodthroughput92001804.707op/s92670987.987op/s ± 220890.594op/s92654739.923op/s ± 133066.829op/s92792853.328op/s93043675.572op/s93217378.968op/s93383167.572op/s0.79%0.1400.7110.24%15619.324op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...execution_time[205.297µs; 205.400µs] or [-0.025%; +0.025%]NoneNoneNone
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...throughput[4868564.781op/s; 4870995.319op/s] or [-0.025%; +0.025%]NoneNoneNone
normalization/normalize_name/normalize_name/bad-nameexecution_time[18.612µs; 18.630µs] or [-0.048%; +0.048%]NoneNoneNone
normalization/normalize_name/normalize_name/bad-namethroughput[53677363.870op/s; 53728843.114op/s] or [-0.048%; +0.048%]NoneNoneNone
normalization/normalize_name/normalize_name/goodexecution_time[10.787µs; 10.794µs] or [-0.033%; +0.033%]NoneNoneNone
normalization/normalize_name/normalize_name/goodthroughput[92640374.675op/s; 92701601.298op/s] or [-0.033%; +0.033%]NoneNoneNone

Group 3

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_trace/test_traceexecution_time244.650ns253.024ns ± 12.380ns247.095ns ± 1.328ns254.266ns285.310ns291.950ns299.014ns21.01%2.0323.1434.88%0.875ns1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_trace/test_traceexecution_time[251.309ns; 254.740ns] or [-0.678%; +0.678%]NoneNoneNone

Group 4

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching serializing traces from their internal representation to msgpackexecution_time14.126ms14.166ms ± 0.029ms14.160ms ± 0.009ms14.170ms14.207ms14.284ms14.382ms1.56%3.62218.2440.21%0.002ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching serializing traces from their internal representation to msgpackexecution_time[14.162ms; 14.170ms] or [-0.029%; +0.029%]NoneNoneNone

Group 5

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
concentrator/add_spans_to_concentratorexecution_time10.683ms10.707ms ± 0.014ms10.706ms ± 0.008ms10.714ms10.727ms10.753ms10.798ms0.86%1.8628.8700.13%0.001ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
concentrator/add_spans_to_concentratorexecution_time[10.705ms; 10.709ms] or [-0.018%; +0.018%]NoneNoneNone

Group 6

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
redis/obfuscate_redis_stringexecution_time34.268µs34.875µs ± 1.056µs34.367µs ± 0.056µs34.568µs37.119µs37.219µs38.214µs11.19%1.6981.0123.02%0.075µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
redis/obfuscate_redis_stringexecution_time[34.728µs; 35.021µs] or [-0.420%; +0.420%]NoneNoneNone

Group 7

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
sql/obfuscate_sql_stringexecution_time85.067µs85.290µs ± 0.165µs85.264µs ± 0.043µs85.313µs85.404µs85.774µs87.123µs2.18%7.70677.9130.19%0.012µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
sql/obfuscate_sql_stringexecution_time[85.267µs; 85.313µs] or [-0.027%; +0.027%]NoneNoneNone

Group 8

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
ip_address/quantize_peer_ip_address_benchmarkexecution_time4.975µs5.042µs ± 0.050µs5.015µs ± 0.028µs5.087µs5.129µs5.134µs5.140µs2.49%0.572-1.2421.00%0.004µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
ip_address/quantize_peer_ip_address_benchmarkexecution_time[5.035µs; 5.049µs] or [-0.139%; +0.139%]NoneNoneNone

Group 9

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
two way interfaceexecution_time17.802µs25.083µs ± 8.939µs18.041µs ± 0.129µs33.281µs41.047µs46.844µs66.747µs269.98%0.9650.85835.55%0.632µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
two way interfaceexecution_time[23.844µs; 26.322µs] or [-4.939%; +4.939%]NoneNoneNone

Group 10

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
sdk_test_data/rules-basedexecution_time121.607µs123.428µs ± 1.398µs123.251µs ± 0.519µs123.734µs125.039µs127.976µs137.158µs11.28%5.60747.9241.13%0.099µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
sdk_test_data/rules-basedexecution_time[123.235µs; 123.622µs] or [-0.157%; +0.157%]NoneNoneNone

Group 11

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
write only interfaceexecution_time1.140µs3.234µs ± 1.418µs3.020µs ± 0.024µs3.041µs3.710µs13.866µs14.810µs390.48%7.28854.54343.75%0.100µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
write only interfaceexecution_time[3.037µs; 3.431µs] or [-6.079%; +6.079%]NoneNoneNone

Group 12

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching string interning on wordpress profileexecution_time161.337µs162.275µs ± 0.372µs162.258µs ± 0.143µs162.393µs162.632µs163.253µs165.942µs2.27%5.01946.5520.23%0.026µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching string interning on wordpress profileexecution_time[162.224µs; 162.327µs] or [-0.032%; +0.032%]NoneNoneNone

Group 13

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...execution_time534.572µs535.980µs ± 1.220µs535.543µs ± 0.450µs536.342µs538.154µs539.826µs542.266µs1.26%2.0765.2760.23%0.086µs1200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...throughput1844111.805op/s1865751.942op/s ± 4228.366op/s1867262.155op/s ± 1571.039op/s1868477.793op/s1869673.013op/s1870180.279op/s1870656.638op/s0.18%-2.0565.1540.23%298.991op/s1200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててexecution_time380.268µs380.740µs ± 0.229µs380.726µs ± 0.166µs380.905µs381.094µs381.283µs381.507µs0.21%0.346-0.0470.06%0.016µs1200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててthroughput2621180.449op/s2626461.909op/s ± 1576.176op/s2626558.482op/s ± 1146.148op/s2627635.216op/s2628881.891op/s2629239.311op/s2629723.985op/s0.12%-0.343-0.0530.06%111.452op/s1200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersexecution_time189.813µs190.357µs ± 0.417µs190.313µs ± 0.118µs190.460µs190.697µs190.993µs195.391µs2.67%8.863104.0460.22%0.030µs1200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersthroughput5117934.937op/s5253313.702op/s ± 11304.568op/s5254498.255op/s ± 3271.309op/s5257527.516op/s5262857.785op/s5265629.615op/s5268348.747op/s0.26%-8.684101.1520.21%799.354op/s1200
normalization/normalize_service/normalize_service/[empty string]execution_time37.888µs38.020µs ± 0.054µs38.017µs ± 0.036µs38.055µs38.121µs38.132µs38.173µs0.41%0.160-0.2140.14%0.004µs1200
normalization/normalize_service/normalize_service/[empty string]throughput26196779.605op/s26302038.250op/s ± 37087.355op/s26304013.648op/s ± 24830.243op/s26326861.065op/s26363140.508op/s26377884.352op/s26393916.956op/s0.34%-0.152-0.2170.14%2622.472op/s1200
normalization/normalize_service/normalize_service/test_ASCIIexecution_time45.767µs45.901µs ± 0.112µs45.897µs ± 0.035µs45.931µs45.968µs46.020µs47.318µs3.10%10.144126.0610.24%0.008µs1200
normalization/normalize_service/normalize_service/test_ASCIIthroughput21133444.252op/s21786049.779op/s ± 51939.375op/s21787935.302op/s ± 16704.672op/s21804950.628op/s21824803.583op/s21843860.913op/s21849891.247op/s0.28%-9.960123.0020.24%3672.668op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...execution_time[535.811µs; 536.149µs] or [-0.032%; +0.032%]NoneNoneNone
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...throughput[1865165.931op/s; 1866337.953op/s] or [-0.031%; +0.031%]NoneNoneNone
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててexecution_time[380.709µs; 380.772µs] or [-0.008%; +0.008%]NoneNoneNone
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰ててthroughput[2626243.466op/s; 2626680.352op/s] or [-0.008%; +0.008%]NoneNoneNone
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersexecution_time[190.299µs; 190.415µs] or [-0.030%; +0.030%]NoneNoneNone
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Charactersthroughput[5251746.998op/s; 5254880.407op/s] or [-0.030%; +0.030%]NoneNoneNone
normalization/normalize_service/normalize_service/[empty string]execution_time[38.013µs; 38.027µs] or [-0.020%; +0.020%]NoneNoneNone
normalization/normalize_service/normalize_service/[empty string]throughput[26296898.299op/s; 26307178.200op/s] or [-0.020%; +0.020%]NoneNoneNone
normalization/normalize_service/normalize_service/test_ASCIIexecution_time[45.886µs; 45.917µs] or [-0.034%; +0.034%]NoneNoneNone
normalization/normalize_service/normalize_service/test_ASCIIthroughput[21778851.481op/s; 21793248.077op/s] or [-0.033%; +0.033%]NoneNoneNone

Group 14

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
benching deserializing traces from msgpack to their internal representationexecution_time60.048ms60.432ms ± 2.112ms60.164ms ± 0.048ms60.215ms60.447ms69.258ms81.054ms34.72%8.87579.4573.49%0.149ms1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
benching deserializing traces from msgpack to their internal representationexecution_time[60.139ms; 60.724ms] or [-0.484%; +0.484%]NoneNoneNone

Group 15

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
credit_card/is_card_number/execution_time3.891µs3.913µs ± 0.003µs3.912µs ± 0.002µs3.914µs3.918µs3.921µs3.932µs0.51%0.14812.6950.09%0.000µs1200
credit_card/is_card_number/throughput254323626.018op/s255583964.255op/s ± 221124.470op/s255610454.468op/s ± 106881.513op/s255703374.492op/s255805565.479op/s255872234.510op/s257008431.908op/s0.55%-0.11012.7750.09%15635.861op/s1200
credit_card/is_card_number/ 3782-8224-6310-005execution_time78.735µs81.691µs ± 1.231µs81.550µs ± 0.791µs82.455µs83.920µs84.750µs85.491µs4.83%0.3190.2361.50%0.087µs1200
credit_card/is_card_number/ 3782-8224-6310-005throughput11697121.025op/s12243958.943op/s ± 183743.159op/s12262413.252op/s ± 118881.455op/s12358678.292op/s12533598.133op/s12684437.723op/s12700763.708op/s3.57%-0.2230.1821.50%12992.603op/s1200
credit_card/is_card_number/ 378282246310005execution_time71.386µs72.202µs ± 0.791µs71.859µs ± 0.342µs72.636µs73.979µs74.325µs74.373µs3.50%1.1710.3781.09%0.056µs1200
credit_card/is_card_number/ 378282246310005throughput13445726.711op/s13851757.262op/s ± 149924.743op/s13916183.893op/s ± 66490.769op/s13971783.557op/s13990584.912op/s13993846.316op/s14008432.270op/s0.66%-1.1380.2831.08%10601.280op/s1200
credit_card/is_card_number/37828224631execution_time3.894µs3.913µs ± 0.003µs3.913µs ± 0.002µs3.914µs3.917µs3.920µs3.923µs0.25%-0.8368.3320.08%0.000µs1200
credit_card/is_card_number/37828224631throughput254920941.596op/s255571693.805op/s ± 193423.574op/s255563876.048op/s ± 108221.266op/s255697964.284op/s255830242.103op/s255876683.618op/s256825236.154op/s0.49%0.8588.4580.08%13677.112op/s1200
credit_card/is_card_number/378282246310005execution_time68.280µs68.945µs ± 0.623µs68.745µs ± 0.364µs69.258µs70.127µs70.699µs71.079µs3.39%1.1210.6550.90%0.044µs1200
credit_card/is_card_number/378282246310005throughput14068850.255op/s14505567.491op/s ± 129805.104op/s14546482.157op/s ± 77480.669op/s14615906.128op/s14635908.470op/s14644317.204op/s14645516.802op/s0.68%-1.0840.5340.89%9178.607op/s1200
credit_card/is_card_number/37828224631000521389798execution_time45.370µs45.688µs ± 0.118µs45.692µs ± 0.082µs45.771µs45.856µs45.928µs45.942µs0.55%-0.361-0.1740.26%0.008µs1200
credit_card/is_card_number/37828224631000521389798throughput21766635.822op/s21887914.694op/s ± 56403.907op/s21885721.756op/s ± 39040.933op/s21925853.444op/s21988218.715op/s22028679.685op/s22040905.304op/s0.71%0.374-0.1610.26%3988.359op/s1200
credit_card/is_card_number/x371413321323331execution_time6.428µs6.435µs ± 0.004µs6.435µs ± 0.003µs6.438µs6.442µs6.446µs6.450µs0.23%0.6910.4130.06%0.000µs1200
credit_card/is_card_number/x371413321323331throughput155044390.187op/s155389985.254op/s ± 94013.653op/s155406597.027op/s ± 63369.272op/s155458736.197op/s155513809.672op/s155563367.674op/s155578510.783op/s0.11%-0.6880.4050.06%6647.769op/s1200
credit_card/is_card_number_no_luhn/execution_time3.893µs3.913µs ± 0.002µs3.913µs ± 0.001µs3.914µs3.916µs3.918µs3.920µs0.17%-2.32019.3120.06%0.000µs1200
credit_card/is_card_number_no_luhn/throughput255131235.936op/s255577938.220op/s ± 162993.912op/s255576914.158op/s ± 76650.608op/s255649911.792op/s255772933.662op/s255862195.664op/s256888339.771op/s0.51%2.35119.5970.06%11525.410op/s1200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005execution_time61.443µs62.854µs ± 0.455µs62.858µs ± 0.276µs63.089µs63.535µs64.069µs64.375µs2.41%0.2400.5800.72%0.032µs1200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005throughput15534092.889op/s15910663.422op/s ± 115008.877op/s15908794.420op/s ± 69568.722op/s15986290.013op/s16079631.424op/s16145976.885op/s16275361.927op/s2.30%-0.1850.5530.72%8132.356op/s1200
credit_card/is_card_number_no_luhn/ 378282246310005execution_time54.098µs54.317µs ± 0.088µs54.316µs ± 0.062µs54.375µs54.457µs54.519µs54.575µs0.48%0.171-0.1300.16%0.006µs1200
credit_card/is_card_number_no_luhn/ 378282246310005throughput18323266.597op/s18410609.040op/s ± 29873.617op/s18410667.759op/s ± 21157.019op/s18432311.496op/s18456556.959op/s18479426.489op/s18485021.587op/s0.40%-0.163-0.1360.16%2112.384op/s1200
credit_card/is_card_number_no_luhn/37828224631execution_time3.897µs3.915µs ± 0.004µs3.915µs ± 0.003µs3.918µs3.920µs3.922µs3.923µs0.21%-0.4111.4870.09%0.000µs1200
credit_card/is_card_number_no_luhn/37828224631throughput254923865.432op/s255430561.048op/s ± 235088.391op/s255453305.978op/s ± 179338.312op/s255599846.677op/s255765161.644op/s255851187.544op/s256587270.842op/s0.44%0.4201.5290.09%16623.260op/s1200
credit_card/is_card_number_no_luhn/378282246310005execution_time50.263µs50.508µs ± 0.133µs50.490µs ± 0.059µs50.559µs50.704µs51.032µs51.569µs2.14%3.34121.0800.26%0.009µs1200
credit_card/is_card_number_no_luhn/378282246310005throughput19391656.319op/s19798968.149op/s ± 51651.877op/s19805822.912op/s ± 23296.150op/s19827272.413op/s19857548.670op/s19867592.868op/s19895276.490op/s0.45%-3.24920.1470.26%3652.339op/s1200
credit_card/is_card_number_no_luhn/37828224631000521389798execution_time45.381µs45.692µs ± 0.147µs45.696µs ± 0.095µs45.786µs45.905µs46.053µs46.328µs1.38%0.3420.9660.32%0.010µs1200
credit_card/is_card_number_no_luhn/37828224631000521389798throughput21585163.128op/s21885943.339op/s ± 70406.469op/s21883547.949op/s ± 45608.152op/s21934320.211op/s22002823.486op/s22026128.883op/s22035788.939op/s0.70%-0.3140.8860.32%4978.489op/s1200
credit_card/is_card_number_no_luhn/x371413321323331execution_time6.428µs6.437µs ± 0.005µs6.437µs ± 0.003µs6.440µs6.445µs6.451µs6.467µs0.46%1.3766.2090.08%0.000µs1200
credit_card/is_card_number_no_luhn/x371413321323331throughput154637313.307op/s155341128.615op/s ± 116683.851op/s155346071.650op/s ± 66661.640op/s155417352.348op/s155517166.633op/s155541361.278op/s155569929.033op/s0.14%-1.3616.1180.07%8250.794op/s1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
credit_card/is_card_number/execution_time[3.912µs; 3.913µs] or [-0.012%; +0.012%]NoneNoneNone
credit_card/is_card_number/throughput[255553318.531op/s; 255614609.980op/s] or [-0.012%; +0.012%]NoneNoneNone
credit_card/is_card_number/ 3782-8224-6310-005execution_time[81.521µs; 81.862µs] or [-0.209%; +0.209%]NoneNoneNone
credit_card/is_card_number/ 3782-8224-6310-005throughput[12218493.909op/s; 12269423.978op/s] or [-0.208%; +0.208%]NoneNoneNone
credit_card/is_card_number/ 378282246310005execution_time[72.092µs; 72.311µs] or [-0.152%; +0.152%]NoneNoneNone
credit_card/is_card_number/ 378282246310005throughput[13830979.135op/s; 13872535.390op/s] or [-0.150%; +0.150%]NoneNoneNone
credit_card/is_card_number/37828224631execution_time[3.912µs; 3.913µs] or [-0.010%; +0.010%]NoneNoneNone
credit_card/is_card_number/37828224631throughput[255544887.158op/s; 255598500.452op/s] or [-0.010%; +0.010%]NoneNoneNone
credit_card/is_card_number/378282246310005execution_time[68.858µs; 69.031µs] or [-0.125%; +0.125%]NoneNoneNone
credit_card/is_card_number/378282246310005throughput[14487577.752op/s; 14523557.230op/s] or [-0.124%; +0.124%]NoneNoneNone
credit_card/is_card_number/37828224631000521389798execution_time[45.671µs; 45.704µs] or [-0.036%; +0.036%]NoneNoneNone
credit_card/is_card_number/37828224631000521389798throughput[21880097.655op/s; 21895731.733op/s] or [-0.036%; +0.036%]NoneNoneNone
credit_card/is_card_number/x371413321323331execution_time[6.435µs; 6.436µs] or [-0.008%; +0.008%]NoneNoneNone
credit_card/is_card_number/x371413321323331throughput[155376955.866op/s; 155403014.642op/s] or [-0.008%; +0.008%]NoneNoneNone
credit_card/is_card_number_no_luhn/execution_time[3.912µs; 3.913µs] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/throughput[255555348.832op/s; 255600527.609op/s] or [-0.009%; +0.009%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005execution_time[62.791µs; 62.917µs] or [-0.100%; +0.100%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005throughput[15894724.298op/s; 15926602.546op/s] or [-0.100%; +0.100%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 378282246310005execution_time[54.304µs; 54.329µs] or [-0.022%; +0.022%]NoneNoneNone
credit_card/is_card_number_no_luhn/ 378282246310005throughput[18406468.844op/s; 18414749.236op/s] or [-0.022%; +0.022%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631execution_time[3.914µs; 3.915µs] or [-0.013%; +0.013%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631throughput[255397980.058op/s; 255463142.038op/s] or [-0.013%; +0.013%]NoneNoneNone
credit_card/is_card_number_no_luhn/378282246310005execution_time[50.490µs; 50.526µs] or [-0.036%; +0.036%]NoneNoneNone
credit_card/is_card_number_no_luhn/378282246310005throughput[19791809.695op/s; 19806126.602op/s] or [-0.036%; +0.036%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631000521389798execution_time[45.672µs; 45.712µs] or [-0.045%; +0.045%]NoneNoneNone
credit_card/is_card_number_no_luhn/37828224631000521389798throughput[21876185.680op/s; 21895700.998op/s] or [-0.045%; +0.045%]NoneNoneNone
credit_card/is_card_number_no_luhn/x371413321323331execution_time[6.437µs; 6.438µs] or [-0.010%; +0.010%]NoneNoneNone
credit_card/is_card_number_no_luhn/x371413321323331throughput[155324957.356op/s; 155357299.875op/s] or [-0.010%; +0.010%]NoneNoneNone

Group 16

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
single_flag_killswitch/rules-basedexecution_time182.110ns185.557ns ± 3.025ns185.065ns ± 1.994ns186.952ns192.800ns195.445ns196.424ns6.14%1.4502.1211.63%0.214ns1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
single_flag_killswitch/rules-basedexecution_time[185.138ns; 185.976ns] or [-0.226%; +0.226%]NoneNoneNone

Group 17

cpu_modelgit_commit_shagit_commit_dategit_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHza725ec21762943444gyuheon0h/prof-12603-dual-uploads
scenariometricminmean ± sdmedian ± madp75p95p99maxpeak_to_median_ratioskewnesskurtosiscvsemrunssample_size
tags/replace_trace_tagsexecution_time2.414µs2.440µs ± 0.019µs2.438µs ± 0.010µs2.446µs2.492µs2.497µs2.502µs2.61%1.4622.0680.79%0.001µs1200
scenariometric95% CI meanShapiro-Wilk pvalueLjung-Box pvalue (lag=1)Dip test pvalue
tags/replace_trace_tagsexecution_time[2.438µs; 2.443µs] or [-0.110%; +0.110%]NoneNoneNone

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commentedOct 3, 2025•
edited
Loading

Codecov Report

❌ Patch coverage is83.33333% with126 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.23%. Comparing base (35314d9) to head (babb062).

Additional details and impacted files
@@            Coverage Diff             @@##             main    #1259      +/-   ##==========================================+ Coverage   71.08%   71.23%   +0.14%==========================================  Files         379      380       +1       Lines       59814    60563     +749     ==========================================+ Hits        42520    43141     +621- Misses      17294    17422     +128
ComponentsCoverage Δ
datadog-crashtracker∅ <ø> (∅)
datadog-crashtracker-ffi∅ <ø> (∅)
datadog-alloc∅ <ø> (∅)
data-pipeline∅ <ø> (∅)
data-pipeline-ffi∅ <ø> (∅)
ddcommon∅ <ø> (∅)
ddcommon-ffi∅ <ø> (∅)
ddtelemetry∅ <ø> (∅)
ddtelemetry-ffi∅ <ø> (∅)
dogstatsd-client∅ <ø> (∅)
datadog-ipc82.59% <ø> (ø)
datadog-profiling0.00% <ø> (ø)
datadog-profiling-ffi∅ <ø> (∅)
datadog-sidecar37.57% <ø> (ø)
datdog-sidecar-ffi15.63% <ø> (ø)
spawn-worker55.18% <ø> (ø)
tinybytes∅ <ø> (∅)
datadog-trace-normalization∅ <ø> (∅)
datadog-trace-obfuscation94.17% <ø> (ø)
datadog-trace-protobuf∅ <ø> (∅)
datadog-trace-utils∅ <ø> (∅)
datadog-tracer-flare62.25% <ø> (ø)
datadog-log∅ <ø> (∅)
🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1bot commentedOct 3, 2025•
edited by datadog-officialbot
Loading

✅ Tests

🎉 All green!

❄️ No newflaky tests detected
🧪 Alltests passed

This comment will be updated automatically if new data arrives.
🔗 Commit SHA:a725ec2 |Docs |Datadog PR Page | Was this helpful? Give usfeedback!

@dd-octo-sts
Copy link

dd-octo-stsbot commentedOct 3, 2025•
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl
ArtifactBaselineCommitChange
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a71.36 MB71.61 MB+.34% (+250.64 KB) 🔍
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so7.25 MB7.25 MB0% (0 B) 👌
aarch64-unknown-linux-gnu
ArtifactBaselineCommitChange
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a83.71 MB84.07 MB+.42% (+367.71 KB) 🔍
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so9.20 MB9.28 MB+.80% (+76.03 KB) 🔍
libdatadog-x64-windows
ArtifactBaselineCommitChange
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll18.61 MB18.69 MB+.39% (+75.00 KB) 🔍
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib65.77 KB65.77 KB0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb131.06 MB131.43 MB+.28% (+376.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib692.06 MB698.47 MB+.92% (+6.40 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll5.93 MB5.97 MB+.62% (+38.00 KB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib65.77 KB65.77 KB0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb17.51 MB17.58 MB+.40% (+72.00 KB) 🔍
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib32.46 MB32.62 MB+.48% (+160.91 KB) 🔍
libdatadog-x86-windows
ArtifactBaselineCommitChange
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll15.85 MB15.91 MB+.43% (+70.50 KB) 🔍
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib66.79 KB66.79 KB0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb133.16 MB133.55 MB+.29% (+400.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib680.68 MB687.08 MB+.94% (+6.39 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll4.54 MB4.57 MB+.53% (+25.00 KB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib66.79 KB66.79 KB0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb18.66 MB18.73 MB+.41% (+80.00 KB) 🔍
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib30.52 MB30.66 MB+.47% (+149.48 KB) 🔍
x86_64-alpine-linux-musl
ArtifactBaselineCommitChange
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a63.98 MB64.20 MB+.34% (+227.08 KB) 🔍
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so8.56 MB8.59 MB+.36% (+32.00 KB) 🔍
x86_64-unknown-linux-gnu
ArtifactBaselineCommitChange
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a78.42 MB78.74 MB+.40% (+323.65 KB) 🔍
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so9.91 MB9.94 MB+.36% (+37.17 KB) 🔍

@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch from7a55094 tod42530cCompareOctober 6, 2025 17:45
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch from74a5f22 to9e55d5fCompareOctober 7, 2025 14:46
@gyuheon0hgyuheon0h marked this pull request as ready for reviewOctober 7, 2025 14:47
@gyuheon0hgyuheon0h requested a review froma team as acode ownerOctober 7, 2025 14:47
@gyuheon0hgyuheon0h changed the title[crashtracking] upload to both telemetry intake and errors intake[WIP] upload to both telemetry intake and errors intakeOct 7, 2025
@gyuheon0hgyuheon0h changed the title[WIP] upload to both telemetry intake and errors intake[WIP][crashtracking] upload to both telemetry intake and errors intakeOct 7, 2025
@gyuheon0hgyuheon0h requested a review froma team as acode ownerOctober 7, 2025 17:22
@gyuheon0hgyuheon0h changed the title[WIP][crashtracking] upload to both telemetry intake and errors intake[crashtracking] upload to both telemetry intake and errors intakeOct 7, 2025
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch 3 times, most recently fromfca11ec toaf27f4bCompareOctober 14, 2025 12:35
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch 3 times, most recently from23cc5f8 tod8a46d6CompareOctober 20, 2025 12:52
@gyuheon0h
Copy link
ContributorAuthor

TODOs:

  1. Update hardcoded staging vars after done with testing
  2. Add test to confirm that a failed request doesn't interfere with other requests

@gyuheon0hGraphite App
Copy link
ContributorAuthor

gyuheon0h commentedOct 24, 2025•
edited
Loading

@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch 2 times, most recently fromd39b44b to7211c87CompareOctober 27, 2025 13:53
@gyuheon0h
Copy link
ContributorAuthor

TODO: Needs to be a flag for the whole feat.

Copy link
Member

@GianlucaBortoliGianlucaBortoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM after this tiny change

dd-mergequeuebot pushed a commit to DataDog/datadog-agent that referenced this pull requestNov 10, 2025
…tracking standalone is enabled (#42799)### What does this PR do?#30065 added the Error Tracking standalone config and marks the APM trace chunk with a `_dd.error_tracking_standalone.error: true` attribute so that it's possible to recognize them in the backend.There will be soon cases (seeDataDog/libdatadog#1259) where the agent has the Error Tracking standalone config enabled and the EvP proxy is used to send data to the Error Tracking backend instead of using APM traces/spans. For the same reason, we need a way to recognize these payloads in the backend and this PR achieves it by adding a `X-Datadog-Error-Tracking-Standalone: true` HTTP header to the outgoing requests of the EvP proxy when the config is enabled.### MotivationSupport new ways to send data to Error Tracking.### Describe how you validated your changes* Built the agent locally from the branch* Enabled the `error_tracking_standalone.enabled` config option and added an API key in the local `datadog.yaml` file* Run the agent binary* Made a request to the EvP proxy endpoint using `cURL`* Checked the backend sees the added HTTP headerCo-authored-by: gianluca.bortoli <gianluca.bortoli@datadoghq.com>
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch fromf81c75a to05b9b8eCompareNovember 12, 2025 08:53
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch 2 times, most recently frombabb062 to2b78b7bCompareNovember 12, 2025 10:11
@gyuheon0hgyuheon0hforce-pushed thegyuheon0h/prof-12603-dual-uploads branch from2b78b7b toa725ec2CompareNovember 12, 2025 10:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@GianlucaBortoliGianlucaBortoliGianlucaBortoli left review comments

@gleocadiegleocadiegleocadie left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gyuheon0h@codecov-commenter@GianlucaBortoli@gleocadie
[8]ページ先頭
©2009-2025 Movatter.jp