NotificationsYou must be signed in to change notification settings
Fork15
Star60

[Crashtracker] Use range-based datastructure to store modules#1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

gleocadie wants to merge2 commits intomain

base:main

Choose a base branch

fromgleocadie/improve-windows-crashtracker

Draft

[Crashtracker] Use range-based datastructure to store modules#1250

gleocadie wants to merge2 commits intomainfromgleocadie/improve-windows-crashtracker

Conversation

Copy link

Contributor

gleocadie commentedSep 30, 2025

What does this PR do?

A brief description of the change being made with this pull request.

Motivation

What inspired you to submit this pull request?

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Describe here in detail how the change can be validated.

github-actionsbot added the crashtracker label

Sep 30, 2025

Copy link

pr-commenterbot commentedSep 30, 2025•
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2025-10-10 13:40:54

Comparing candidate commitff244b9 in PR branchgleocadie/improve-windows-crashtracker with baseline commitd9b1999 in branchmain.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 53 metrics, 2 unstable metrics.

Candidate

Candidate benchmark details

Group 1

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
write only interface	execution_time	1.252µs	3.237µs ± 1.433µs	3.015µs ± 0.031µs	3.050µs	3.696µs	14.179µs	14.827µs	391.73%	7.288	54.455	44.16%	0.101µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
write only interface	execution_time	[3.038µs; 3.435µs] or [-6.135%; +6.135%]	None	None	None

Group 2

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching serializing traces from their internal representation to msgpack	execution_time	15.102ms	15.150ms ± 0.030ms	15.146ms ± 0.010ms	15.155ms	15.179ms	15.256ms	15.370ms	1.48%	4.224	24.029	0.20%	0.002ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching serializing traces from their internal representation to msgpack	execution_time	[15.146ms; 15.154ms] or [-0.027%; +0.027%]	None	None	None

Group 3

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
credit_card/is_card_number/	execution_time	3.894µs	3.911µs ± 0.003µs	3.911µs ± 0.001µs	3.912µs	3.915µs	3.916µs	3.918µs	0.19%	-1.247	9.319	0.06%	0.000µs	1	200
credit_card/is_card_number/	throughput	255214607.338op/s	255708163.676op/s ± 164763.875op/s	255706456.589op/s ± 90209.246op/s	255792680.083op/s	255939431.338op/s	255973699.630op/s	256824093.374op/s	0.44%	1.266	9.454	0.06%	11650.565op/s	1	200
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	80.520µs	82.476µs ± 0.643µs	82.557µs ± 0.402µs	82.909µs	83.420µs	83.633µs	84.142µs	1.92%	-0.444	0.041	0.78%	0.045µs	1	200
credit_card/is_card_number/ 3782-8224-6310-005	throughput	11884681.571op/s	12125476.733op/s ± 94860.173op/s	12112785.553op/s ± 59215.944op/s	12178448.470op/s	12299802.857op/s	12386197.593op/s	12419257.015op/s	2.53%	0.487	0.092	0.78%	6707.627op/s	1	200
credit_card/is_card_number/ 378282246310005	execution_time	74.488µs	75.032µs ± 0.209µs	75.001µs ± 0.130µs	75.149µs	75.385µs	75.557µs	75.687µs	0.92%	0.453	0.185	0.28%	0.015µs	1	200
credit_card/is_card_number/ 378282246310005	throughput	13212222.607op/s	13327797.278op/s ± 37001.118op/s	13333211.280op/s ± 23135.504op/s	13353179.459op/s	13384764.996op/s	13394144.663op/s	13424955.650op/s	0.69%	-0.436	0.167	0.28%	2616.374op/s	1	200
credit_card/is_card_number/37828224631	execution_time	3.895µs	3.911µs ± 0.002µs	3.911µs ± 0.002µs	3.913µs	3.915µs	3.916µs	3.917µs	0.16%	-1.319	9.060	0.06%	0.000µs	1	200
credit_card/is_card_number/37828224631	throughput	255273641.963op/s	255673390.000op/s ± 162248.892op/s	255674764.901op/s ± 107576.439op/s	255776157.353op/s	255891940.707op/s	255953636.541op/s	256772332.615op/s	0.43%	1.337	9.194	0.06%	11472.729op/s	1	200
credit_card/is_card_number/378282246310005	execution_time	71.641µs	72.214µs ± 0.275µs	72.167µs ± 0.165µs	72.369µs	72.744µs	72.950µs	73.033µs	1.20%	0.661	0.228	0.38%	0.019µs	1	200
credit_card/is_card_number/378282246310005	throughput	13692395.893op/s	13847933.483op/s ± 52697.010op/s	13856818.723op/s ± 31674.660op/s	13886207.525op/s	13923402.873op/s	13951283.344op/s	13958429.988op/s	0.73%	-0.640	0.200	0.38%	3726.241op/s	1	200
credit_card/is_card_number/37828224631000521389798	execution_time	52.139µs	52.198µs ± 0.031µs	52.196µs ± 0.019µs	52.214µs	52.258µs	52.281µs	52.294µs	0.19%	0.656	0.452	0.06%	0.002µs	1	200
credit_card/is_card_number/37828224631000521389798	throughput	19122471.763op/s	19157822.738op/s ± 11490.308op/s	19158661.357op/s ± 6816.395op/s	19165704.409op/s	19174510.366op/s	19178342.665op/s	19179407.071op/s	0.11%	-0.652	0.446	0.06%	812.487op/s	1	200
credit_card/is_card_number/x371413321323331	execution_time	5.692µs	5.830µs ± 0.086µs	5.835µs ± 0.069µs	5.899µs	5.957µs	6.011µs	6.032µs	3.37%	-0.019	-0.911	1.48%	0.006µs	1	200
credit_card/is_card_number/x371413321323331	throughput	165786231.768op/s	171553379.116op/s ± 2539861.562op/s	171381089.061op/s ± 2028886.109op/s	173565370.951op/s	175588009.326op/s	175650278.097op/s	175669984.091op/s	2.50%	0.066	-0.936	1.48%	179595.333op/s	1	200
credit_card/is_card_number_no_luhn/	execution_time	3.892µs	3.913µs ± 0.003µs	3.913µs ± 0.002µs	3.915µs	3.917µs	3.920µs	3.923µs	0.27%	-0.864	6.773	0.08%	0.000µs	1	200
credit_card/is_card_number_no_luhn/	throughput	254897429.952op/s	255584217.600op/s ± 215052.699op/s	255582764.187op/s ± 144396.935op/s	255720873.216op/s	255877827.427op/s	255929764.535op/s	256935061.145op/s	0.53%	0.885	6.895	0.08%	15206.522op/s	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	64.126µs	64.320µs ± 0.100µs	64.302µs ± 0.051µs	64.364µs	64.485µs	64.635µs	64.892µs	0.92%	1.914	6.539	0.16%	0.007µs	1	200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	15410264.204op/s	15547192.206op/s ± 24152.740op/s	15551720.461op/s ± 12318.826op/s	15562419.092op/s	15574895.760op/s	15584623.585op/s	15594414.081op/s	0.27%	-1.892	6.403	0.15%	1707.857op/s	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	57.272µs	57.545µs ± 0.130µs	57.516µs ± 0.065µs	57.594µs	57.762µs	57.975µs	58.386µs	1.51%	2.236	9.272	0.22%	0.009µs	1	200
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	17127501.452op/s	17377919.933op/s ± 38950.339op/s	17386386.460op/s ± 19532.424op/s	17403618.216op/s	17417732.035op/s	17426902.000op/s	17460519.908op/s	0.43%	-2.194	8.947	0.22%	2754.205op/s	1	200
credit_card/is_card_number_no_luhn/37828224631	execution_time	3.896µs	3.911µs ± 0.003µs	3.911µs ± 0.002µs	3.913µs	3.915µs	3.918µs	3.919µs	0.20%	-0.619	4.574	0.07%	0.000µs	1	200
credit_card/is_card_number_no_luhn/37828224631	throughput	255169018.789op/s	255666252.973op/s ± 176877.157op/s	255669204.644op/s ± 116045.489op/s	255797106.978op/s	255909418.376op/s	255971653.007op/s	256686677.921op/s	0.40%	0.632	4.641	0.07%	12507.104op/s	1	200
credit_card/is_card_number_no_luhn/378282246310005	execution_time	54.563µs	54.822µs ± 0.194µs	54.783µs ± 0.087µs	54.880µs	55.154µs	55.638µs	56.079µs	2.37%	2.618	10.952	0.35%	0.014µs	1	200
credit_card/is_card_number_no_luhn/378282246310005	throughput	17832103.438op/s	18240979.519op/s ± 63838.252op/s	18253915.263op/s ± 29080.637op/s	18281019.742op/s	18304507.948op/s	18320797.957op/s	18327570.164op/s	0.40%	-2.555	10.448	0.35%	4514.046op/s	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	52.129µs	52.196µs ± 0.039µs	52.192µs ± 0.024µs	52.216µs	52.264µs	52.284µs	52.444µs	0.48%	1.592	7.398	0.07%	0.003µs	1	200
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	19067878.669op/s	19158649.346op/s ± 14185.123op/s	19159918.409op/s ± 8633.665op/s	19168552.073op/s	19178851.576op/s	19181127.401op/s	19183001.942op/s	0.12%	-1.577	7.284	0.07%	1003.040op/s	1	200
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	5.690µs	5.819µs ± 0.079µs	5.823µs ± 0.060µs	5.870µs	5.938µs	5.982µs	6.013µs	3.26%	0.093	-0.851	1.36%	0.006µs	1	200
credit_card/is_card_number_no_luhn/x371413321323331	throughput	166318379.843op/s	171873847.059op/s ± 2336528.649op/s	171740497.843op/s ± 1778769.208op/s	173588689.423op/s	175602676.593op/s	175715389.083op/s	175737555.937op/s	2.33%	-0.047	-0.876	1.36%	165217.525op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
credit_card/is_card_number/	execution_time	[3.910µs; 3.911µs] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/	throughput	[255685328.988op/s; 255730998.365op/s] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	execution_time	[82.387µs; 82.565µs] or [-0.108%; +0.108%]	None	None	None
credit_card/is_card_number/ 3782-8224-6310-005	throughput	[12112330.025op/s; 12138623.440op/s] or [-0.108%; +0.108%]	None	None	None
credit_card/is_card_number/ 378282246310005	execution_time	[75.003µs; 75.061µs] or [-0.039%; +0.039%]	None	None	None
credit_card/is_card_number/ 378282246310005	throughput	[13322669.279op/s; 13332925.277op/s] or [-0.038%; +0.038%]	None	None	None
credit_card/is_card_number/37828224631	execution_time	[3.911µs; 3.912µs] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/37828224631	throughput	[255650903.864op/s; 255695876.136op/s] or [-0.009%; +0.009%]	None	None	None
credit_card/is_card_number/378282246310005	execution_time	[72.176µs; 72.252µs] or [-0.053%; +0.053%]	None	None	None
credit_card/is_card_number/378282246310005	throughput	[13840630.184op/s; 13855236.782op/s] or [-0.053%; +0.053%]	None	None	None
credit_card/is_card_number/37828224631000521389798	execution_time	[52.194µs; 52.202µs] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/37828224631000521389798	throughput	[19156230.292op/s; 19159415.184op/s] or [-0.008%; +0.008%]	None	None	None
credit_card/is_card_number/x371413321323331	execution_time	[5.818µs; 5.842µs] or [-0.205%; +0.205%]	None	None	None
credit_card/is_card_number/x371413321323331	throughput	[171201378.731op/s; 171905379.502op/s] or [-0.205%; +0.205%]	None	None	None
credit_card/is_card_number_no_luhn/	execution_time	[3.912µs; 3.913µs] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/	throughput	[255554413.364op/s; 255614021.836op/s] or [-0.012%; +0.012%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	execution_time	[64.307µs; 64.334µs] or [-0.022%; +0.022%]	None	None	None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005	throughput	[15543844.869op/s; 15550539.544op/s] or [-0.022%; +0.022%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	execution_time	[57.527µs; 57.563µs] or [-0.031%; +0.031%]	None	None	None
credit_card/is_card_number_no_luhn/ 378282246310005	throughput	[17372521.791op/s; 17383318.076op/s] or [-0.031%; +0.031%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	execution_time	[3.911µs; 3.912µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631	throughput	[255641739.500op/s; 255690766.445op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	execution_time	[54.795µs; 54.849µs] or [-0.049%; +0.049%]	None	None	None
credit_card/is_card_number_no_luhn/378282246310005	throughput	[18232132.152op/s; 18249826.887op/s] or [-0.049%; +0.049%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	execution_time	[52.190µs; 52.201µs] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/37828224631000521389798	throughput	[19156683.425op/s; 19160615.268op/s] or [-0.010%; +0.010%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	execution_time	[5.808µs; 5.830µs] or [-0.189%; +0.189%]	None	None	None
credit_card/is_card_number_no_luhn/x371413321323331	throughput	[171550026.660op/s; 172197667.459op/s] or [-0.188%; +0.188%]	None	None	None

Group 4

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
concentrator/add_spans_to_concentrator	execution_time	10.678ms	10.707ms ± 0.012ms	10.707ms ± 0.008ms	10.714ms	10.729ms	10.744ms	10.751ms	0.41%	0.652	0.935	0.11%	0.001ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
concentrator/add_spans_to_concentrator	execution_time	[10.706ms; 10.709ms] or [-0.016%; +0.016%]	None	None	None

Group 5

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching string interning on wordpress profile	execution_time	157.729µs	158.449µs ± 0.392µs	158.427µs ± 0.200µs	158.609µs	159.116µs	159.737µs	160.414µs	1.25%	1.235	3.694	0.25%	0.028µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching string interning on wordpress profile	execution_time	[158.395µs; 158.504µs] or [-0.034%; +0.034%]	None	None	None

Group 6

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
tags/replace_trace_tags	execution_time	2.378µs	2.422µs ± 0.021µs	2.419µs ± 0.006µs	2.425µs	2.470µs	2.478µs	2.493µs	3.05%	0.940	1.669	0.85%	0.001µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
tags/replace_trace_tags	execution_time	[2.419µs; 2.424µs] or [-0.118%; +0.118%]	None	None	None

Group 7

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
two way interface	execution_time	17.526µs	25.865µs ± 10.275µs	17.863µs ± 0.263µs	35.640µs	44.478µs	47.408µs	59.907µs	235.37%	0.784	-0.687	39.63%	0.727µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
two way interface	execution_time	[24.441µs; 27.289µs] or [-5.506%; +5.506%]	None	None	None

Group 8

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
receiver_entry_point/report/2597	execution_time	6.260ms	6.331ms ± 0.051ms	6.314ms ± 0.018ms	6.349ms	6.446ms	6.495ms	6.563ms	3.94%	1.693	2.933	0.81%	0.004ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
receiver_entry_point/report/2597	execution_time	[6.324ms; 6.338ms] or [-0.112%; +0.112%]	None	None	None

Group 9

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_trace/test_trace	execution_time	241.479ns	255.077ns ± 14.730ns	248.112ns ± 3.849ns	259.651ns	284.992ns	287.527ns	288.180ns	16.15%	1.165	-0.292	5.76%	1.042ns	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_trace/test_trace	execution_time	[253.035ns; 257.118ns] or [-0.800%; +0.800%]	None	None	None

Group 10

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	185.402µs	185.937µs ± 0.294µs	185.921µs ± 0.183µs	186.076µs	186.373µs	187.175µs	187.428µs	0.81%	1.609	5.782	0.16%	0.021µs	1	200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	5335377.138op/s	5378190.794op/s ± 8473.403op/s	5378640.856op/s ± 5294.474op/s	5384701.773op/s	5388797.686op/s	5392461.952op/s	5393689.437op/s	0.28%	-1.585	5.648	0.16%	599.160op/s	1	200
normalization/normalize_name/normalize_name/bad-name	execution_time	17.937µs	18.024µs ± 0.038µs	18.020µs ± 0.027µs	18.053µs	18.083µs	18.124µs	18.145µs	0.69%	0.328	-0.084	0.21%	0.003µs	1	200
normalization/normalize_name/normalize_name/bad-name	throughput	55112979.292op/s	55480757.976op/s ± 117852.897op/s	55493960.371op/s ± 84000.218op/s	55564466.109op/s	55654344.631op/s	55711993.124op/s	55750212.811op/s	0.46%	-0.317	-0.099	0.21%	8333.458op/s	1	200
normalization/normalize_name/normalize_name/good	execution_time	9.878µs	9.922µs ± 0.066µs	9.891µs ± 0.004µs	9.900µs	10.074µs	10.133µs	10.141µs	2.52%	1.857	2.069	0.66%	0.005µs	1	200
normalization/normalize_name/normalize_name/good	throughput	98611505.516op/s	100792640.012op/s ± 658167.054op/s	101098976.280op/s ± 44303.695op/s	101135608.403op/s	101178901.567op/s	101208396.310op/s	101230675.787op/s	0.13%	-1.845	2.010	0.65%	46539.439op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	execution_time	[185.896µs; 185.977µs] or [-0.022%; +0.022%]	None	None	None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo...	throughput	[5377016.461op/s; 5379365.126op/s] or [-0.022%; +0.022%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	execution_time	[18.019µs; 18.030µs] or [-0.029%; +0.029%]	None	None	None
normalization/normalize_name/normalize_name/bad-name	throughput	[55464424.698op/s; 55497091.254op/s] or [-0.029%; +0.029%]	None	None	None
normalization/normalize_name/normalize_name/good	execution_time	[9.913µs; 9.931µs] or [-0.092%; +0.092%]	None	None	None
normalization/normalize_name/normalize_name/good	throughput	[100701424.389op/s; 100883855.636op/s] or [-0.090%; +0.090%]	None	None	None

Group 11

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
benching deserializing traces from msgpack to their internal representation	execution_time	59.758ms	60.406ms ± 1.893ms	60.206ms ± 0.102ms	60.288ms	60.419ms	70.133ms	81.846ms	35.94%	9.241	91.374	3.13%	0.134ms	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
benching deserializing traces from msgpack to their internal representation	execution_time	[60.143ms; 60.668ms] or [-0.434%; +0.434%]	None	None	None

Group 12

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	495.334µs	496.182µs ± 0.500µs	496.132µs ± 0.300µs	496.430µs	496.931µs	497.365µs	499.815µs	0.74%	2.060	12.486	0.10%	0.035µs	1	200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	2000740.719op/s	2015389.736op/s ± 2025.773op/s	2015593.640op/s ± 1216.245op/s	2016745.375op/s	2018045.633op/s	2018622.748op/s	2018839.360op/s	0.16%	-2.029	12.210	0.10%	143.244op/s	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	370.895µs	371.588µs ± 0.323µs	371.564µs ± 0.240µs	371.823µs	372.115µs	372.285µs	372.511µs	0.26%	0.134	-0.489	0.09%	0.023µs	1	200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	2684482.918op/s	2691157.303op/s ± 2337.221op/s	2691328.598op/s ± 1740.743op/s	2692937.560op/s	2694871.710op/s	2695971.432op/s	2696182.124op/s	0.18%	-0.130	-0.491	0.09%	165.266op/s	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	168.864µs	169.879µs ± 0.231µs	169.895µs ± 0.099µs	170.013µs	170.131µs	170.223µs	170.275µs	0.22%	-1.908	4.850	0.14%	0.016µs	1	200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	5872857.551op/s	5886552.331op/s ± 8028.273op/s	5885981.556op/s ± 3430.623op/s	5888313.348op/s	5904810.695op/s	5916081.064op/s	5921908.210op/s	0.61%	1.921	4.904	0.14%	567.685op/s	1	200
normalization/normalize_service/normalize_service/[empty string]	execution_time	37.696µs	37.808µs ± 0.043µs	37.806µs ± 0.027µs	37.835µs	37.879µs	37.907µs	37.973µs	0.44%	0.441	0.917	0.11%	0.003µs	1	200
normalization/normalize_service/normalize_service/[empty string]	throughput	26334343.027op/s	26449387.845op/s ± 29781.643op/s	26450677.090op/s ± 19052.674op/s	26468807.848op/s	26492459.667op/s	26513768.109op/s	26528156.859op/s	0.29%	-0.431	0.901	0.11%	2105.880op/s	1	200
normalization/normalize_service/normalize_service/test_ASCII	execution_time	46.216µs	46.346µs ± 0.061µs	46.337µs ± 0.035µs	46.380µs	46.452µs	46.501µs	46.604µs	0.58%	0.882	2.003	0.13%	0.004µs	1	200
normalization/normalize_service/normalize_service/test_ASCII	throughput	21457221.929op/s	21577105.081op/s ± 28509.791op/s	21580953.517op/s ± 16279.447op/s	21595714.546op/s	21616200.580op/s	21629858.952op/s	21637663.382op/s	0.26%	-0.869	1.957	0.13%	2015.947op/s	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	execution_time	[496.113µs; 496.252µs] or [-0.014%; +0.014%]	None	None	None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000...	throughput	[2015108.983op/s; 2015670.489op/s] or [-0.014%; +0.014%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	execution_time	[371.543µs; 371.632µs] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて	throughput	[2690833.386op/s; 2691481.219op/s] or [-0.012%; +0.012%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	execution_time	[169.847µs; 169.911µs] or [-0.019%; +0.019%]	None	None	None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters	throughput	[5885439.690op/s; 5887664.973op/s] or [-0.019%; +0.019%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	execution_time	[37.802µs; 37.814µs] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_service/normalize_service/[empty string]	throughput	[26445260.396op/s; 26453515.294op/s] or [-0.016%; +0.016%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	execution_time	[46.337µs; 46.354µs] or [-0.018%; +0.018%]	None	None	None
normalization/normalize_service/normalize_service/test_ASCII	throughput	[21573153.898op/s; 21581056.264op/s] or [-0.018%; +0.018%]	None	None	None

Group 13

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
ip_address/quantize_peer_ip_address_benchmark	execution_time	5.014µs	5.089µs ± 0.043µs	5.073µs ± 0.038µs	5.137µs	5.152µs	5.153µs	5.155µs	1.60%	0.180	-1.325	0.85%	0.003µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
ip_address/quantize_peer_ip_address_benchmark	execution_time	[5.083µs; 5.095µs] or [-0.118%; +0.118%]	None	None	None

Group 14

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
redis/obfuscate_redis_string	execution_time	33.771µs	34.423µs ± 1.125µs	33.914µs ± 0.051µs	33.981µs	36.781µs	36.820µs	39.002µs	15.00%	1.797	1.645	3.26%	0.080µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
redis/obfuscate_redis_string	execution_time	[34.268µs; 34.579µs] or [-0.453%; +0.453%]	None	None	None

Group 15

cpu_model	git_commit_sha	git_commit_date	git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	`ff244b9`	1760102875	gleocadie/improve-windows-crashtracker

scenario	metric	min	mean ± sd	median ± mad	p75	p95	p99	max	peak_to_median_ratio	skewness	kurtosis	cv	sem	runs	sample_size
sql/obfuscate_sql_string	execution_time	89.076µs	89.444µs ± 0.201µs	89.410µs ± 0.141µs	89.600µs	89.720µs	89.939µs	90.360µs	1.06%	1.047	2.578	0.22%	0.014µs	1	200

scenario	metric	95% CI mean	Shapiro-Wilk pvalue	Ljung-Box pvalue (lag=1)	Dip test pvalue
sql/obfuscate_sql_string	execution_time	[89.417µs; 89.472µs] or [-0.031%; +0.031%]	None	None	None

Baseline

Omitted due to size.

gleocadie force-pushed thegleocadie/improve-windows-crashtracker branch 3 times, most recently fromd41cb20 to4250409Compare

September 30, 2025 12:26

Copy link

codecov-commenter commentedSep 30, 2025•
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.90%. Comparing base (d9b1999) to head (ff244b9).

Additional details and impacted files

@@            Coverage Diff             @@##             main    #1250      +/-   ##==========================================+ Coverage   71.88%   71.90%   +0.02%==========================================  Files         356      356                Lines       56691    56691              ==========================================+ Hits        40750    40764      +14+ Misses      15941    15927      -14

Components	Coverage Δ
datadog-crashtracker	`49.30% <ø> (+0.02%)`	⬆️
datadog-crashtracker-ffi	`5.93% <ø> (ø)`
datadog-alloc	`98.73% <ø> (ø)`
data-pipeline	`87.85% <ø> (ø)`
data-pipeline-ffi	`88.19% <ø> (ø)`
ddcommon	`84.54% <ø> (ø)`
ddcommon-ffi	`73.84% <ø> (ø)`
ddtelemetry	`59.73% <ø> (-0.04%)`	⬇️
ddtelemetry-ffi	`21.24% <ø> (ø)`
dogstatsd-client	`83.26% <ø> (ø)`
datadog-ipc	`82.39% <ø> (ø)`
datadog-profiling	`76.90% <ø> (ø)`
datadog-profiling-ffi	`62.12% <ø> (ø)`
datadog-sidecar	`37.53% <ø> (ø)`
datdog-sidecar-ffi	`13.54% <ø> (ø)`
spawn-worker	`55.35% <ø> (ø)`
tinybytes	`92.22% <ø> (ø)`
datadog-trace-normalization	`98.24% <ø> (ø)`
datadog-trace-obfuscation	`94.17% <ø> (ø)`
datadog-trace-protobuf	`59.65% <ø> (ø)`
datadog-trace-utils	`89.99% <ø> (ø)`
datadog-tracer-flare	`56.08% <ø> (ø)`
datadog-log	`76.31% <ø> (ø)`

🚀 New features to boost your workflow:

❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

gleocadie force-pushed thegleocadie/improve-windows-crashtracker branch from4250409 to7062850Compare

September 30, 2025 12:48

Copy link

dd-octo-stsbot commentedSep 30, 2025•
edited
Loading

Artifact Size Benchmark Report

aarch64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.a	71.33 MB	71.33 MB	0% (0 B) 👌
/aarch64-alpine-linux-musl/lib/libdatadog_profiling.so	7.25 MB	7.25 MB	0% (0 B) 👌

aarch64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.a	83.64 MB	83.64 MB	0% (0 B) 👌
/aarch64-unknown-linux-gnu/lib/libdatadog_profiling.so	9.20 MB	9.20 MB	0% (0 B) 👌

libdatadog-x64-windows

Artifact	Baseline	Commit	Change
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.dll	18.59 MB	18.59 MB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.lib	65.77 KB	65.77 KB	0% (0 B) 👌
/libdatadog-x64-windows/debug/dynamic/datadog_profiling_ffi.pdb	129.39 MB	130.16 MB	+.59% (+792.00 KB) 🔍
/libdatadog-x64-windows/debug/static/datadog_profiling_ffi.lib	676.00 MB	678.37 MB	+.35% (+2.37 MB) 🔍
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.dll	5.93 MB	5.93 MB	--.08% (-5.00 KB) 💪
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.lib	65.77 KB	65.77 KB	0% (0 B) 👌
/libdatadog-x64-windows/release/dynamic/datadog_profiling_ffi.pdb	17.52 MB	17.52 MB	0% (0 B) 👌
/libdatadog-x64-windows/release/static/datadog_profiling_ffi.lib	32.48 MB	32.48 MB	--.02% (-6.97 KB) 💪

libdatadog-x86-windows

Artifact	Baseline	Commit	Change
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.dll	15.85 MB	15.85 MB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.lib	66.79 KB	66.79 KB	0% (0 B) 👌
/libdatadog-x86-windows/debug/dynamic/datadog_profiling_ffi.pdb	131.80 MB	132.58 MB	+.59% (+808.00 KB) 🔍
/libdatadog-x86-windows/debug/static/datadog_profiling_ffi.lib	664.83 MB	667.20 MB	+.35% (+2.36 MB) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.dll	4.54 MB	4.54 MB	+.01% (+512 B) 🔍
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.lib	66.79 KB	66.79 KB	0% (0 B) 👌
/libdatadog-x86-windows/release/dynamic/datadog_profiling_ffi.pdb	18.66 MB	18.66 MB	0% (0 B) 👌
/libdatadog-x86-windows/release/static/datadog_profiling_ffi.lib	30.50 MB	30.50 MB	+0% (+1.04 KB) 👌

x86_64-alpine-linux-musl

Artifact	Baseline	Commit	Change
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.a	63.94 MB	63.94 MB	0% (0 B) 👌
/x86_64-alpine-linux-musl/lib/libdatadog_profiling.so	8.56 MB	8.56 MB	0% (0 B) 👌

x86_64-unknown-linux-gnu

Artifact	Baseline	Commit	Change
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.a	78.36 MB	78.36 MB	0% (0 B) 👌
/x86_64-unknown-linux-gnu/lib/libdatadog_profiling.so	9.90 MB	9.90 MB	0% (0 B) 👌

gleocadie added2 commits

October 10, 2025 15:12

Use range-based datastructure to store modules

60eaab4

Add bin tests for windows

ff244b9

gleocadie force-pushed thegleocadie/improve-windows-crashtracker branch from37be097 toff244b9Compare

October 10, 2025 13:28

Labels

crashtracker

Movatterモバイル変換

[Crashtracker] Use range-based datastructure to store modules#1250

Are you sure you want to change the base?

[Crashtracker] Use range-based datastructure to store modules#1250

Uh oh!

Conversation

gleocadie commentedSep 30, 2025

What does this PR do?

Motivation

Additional Notes

How to test the change?

Uh oh!

pr-commenterbot commentedSep 30, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Benchmarks

Comparison

Candidate

Group 1

Group 2

Group 3

Group 4

Group 5

Group 6

Group 7

Group 8

Group 9

Group 10

Group 11

Group 12

Group 13

Group 14

Group 15

Baseline

Uh oh!

codecov-commenter commentedSep 30, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Codecov Report

Uh oh!

dd-octo-stsbot commentedSep 30, 2025• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Artifact Size Benchmark Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pr-commenterbot commentedSep 30, 2025•
edited
Loading

codecov-commenter commentedSep 30, 2025•
edited
Loading

dd-octo-stsbot commentedSep 30, 2025•
edited
Loading