Rundatadog-ci synthetics build-and-test (name TBD).
datadog-ci will run the build command of the project passingBUILD_PLUGINS_S8S_PORT.
build-plugins will recogniseBUILD_PLUGINS_S8S_PORT and will run a local dev server over theoutDir of the build, with a small api/_datadog-ci_/build-status fordatadog-ci to follow the build progression.
build's complete.
datadog-ci opens a tunnel.
datadog-ci trigger a test batch using the local assets from the build through theresourceUrlSubstitutionRegexes configuration.

More details

The local server offers two routes (in addition to the file server over the out directory):

/_datadog-ci_/build-status responding with:

{"status":"running"|"success"|"fail","outDir":"/..."// Absolute path of the build's outDir."publicPath":"/"// Assets' public path if available.}

/_datadog-ci_/kill kills the server.

TODO

Add documentation fors8s.

yoannmoinet changed the base branch frommaster toyoann/move-dev-server

March 26, 2025 15:58

yoannmoinet added6 commits

March 26, 2025 18:01

Add s8s plugin

ea051ef

Update/add utility types

92843b8

Actually run the server and update configurations

cad4d4a

Add tests

0ab5804

Finalize feature and testing

9986a72

Add missing OSS header

d0b4490

yoannmoinet force-pushed theyoann/s8s-dev-server branch from98f973d tod0b4490Compare

March 26, 2025 17:02

Use local relative imports

7914418

yoannmoinet force-pushed theyoann/s8s-dev-server branch fromf66613e to7914418Compare

March 27, 2025 09:35

This was referencedMar 27, 2025

[internal] Move dev server helper#152

Merged

[internal] Change how we initialise plugins#151

Merged

yoannmoinet requested review fromelbywan andetnbrd

March 27, 2025 10:18

yoannmoinet marked this pull request as ready for review

March 27, 2025 10:18

yoannmoinet requested a review fromCopilot

March 27, 2025 10:20

CopilotAI reviewed

Mar 27, 2025

View reviewed changes

Copy link

CopilotAI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Pull Request Overview

This PR introduces a new Synthetics plugin that enables the local development server for build-time testing and integrates with datadog-ci for build status reporting.

Added Synthetics plugin implementation across various bundler plugins.
Updated exports and factory configuration to include SyntheticsTypes.
Introduced plugin validation, routes for build status and server shutdown, and comprehensive test coverage.

Reviewed Changes

Copilot reviewed 16 out of 20 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
packages/published/webpack-plugin/src/index.ts	Added SyntheticsTypes export in the plugin.
packages/published/vite-plugin/src/index.ts	Added SyntheticsTypes export in the plugin.
packages/published/rspack-plugin/src/index.ts	Added SyntheticsTypes export in the plugin.
packages/published/rollup-plugin/src/index.ts	Added SyntheticsTypes export in the plugin.
packages/published/esbuild-plugin/src/index.ts	Added SyntheticsTypes export in the plugin.
packages/plugins/synthetics/src/{validate,types,index,constants}.ts	Introduced core implementation for the new Synthetics plugin.
packages/plugins/synthetics/src/index.test.ts	Added tests validating server behavior and plugin initialization.
packages/plugins/synthetics/README.md	Provided documentation for the new Synthetics plugin.
packages/factory/src/index.ts	Updated factory exports and configuration to include the Synthetics plugin.
packages/core/src/types.ts	Extended core types to support configuration for the Synthetics plugin.
README.md	Updated root documentation to include Synthetics plugin guidelines.

Files not reviewed (4)

.github/CODEOWNERS: Language not supported
packages/factory/package.json: Language not supported
packages/plugins/synthetics/package.json: Language not supported
packages/plugins/synthetics/tsconfig.json: Language not supported

Comments suppressed due to low confidence (1)

packages/plugins/synthetics/src/index.ts:66

[nitpick] Multiple server shutdown calls (server.close, server.closeAllConnections, server.closeIdleConnections) occur in immediate succession, which may lead to unexpected behavior. Consider consolidating these calls or adding checks to ensure that the server shutdown process is idempotent.

server.close();

packages/plugins/synthetics/src/index.test.ts OutdatedShow resolvedHide resolved

Remove unused env var

9267855

etnbrd mentioned this pull request

Mar 28, 2025

implement the build-and-test commandDataDog/datadog-ci#1595

Merged

1 task

Ayc0 reviewed

Mar 28, 2025

View reviewed changes

.github/CODEOWNERS Outdated

		packages/plugins/custom-hooks@yoannmoinet

		# Synthetics
		packages/plugins/synthetics@yoannmoinet@etnbrd

Copy link

Collaborator

Ayc0Mar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You need to invite etienne I think:

Copy link

MemberAuthor

yoannmoinetMar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Good catch.
I'll wait for his review, see if I should instead maybe use a team (cc@etnbrd)

Copy link

etnbrdMar 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You should definitely use the @DataDog/synthetics-ct team, indeed.

Ayc0 approved these changes

Mar 28, 2025

View reviewed changes

Copy link

Collaborator

Ayc0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM but i'm not versed in s8s

Drarig29 reviewed

Mar 28, 2025

View reviewed changes

global.d.ts OutdatedShow resolvedHide resolved

packages/plugins/synthetics/README.mdShow resolvedHide resolved

packages/plugins/synthetics/src/validate.ts OutdatedShow resolvedHide resolved

elbywan approved these changes

Mar 28, 2025

View reviewed changes

etnbrd approved these changes

Mar 28, 2025

View reviewed changes

Copy link

etnbrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, left a few questions, but nothing blocking.

packages/plugins/synthetics/src/constants.ts OutdatedShow resolvedHide resolved

packages/plugins/synthetics/src/index.ts OutdatedShow resolvedHide resolved

packages/plugins/synthetics/src/validate.ts OutdatedShow resolvedHide resolved

Base automatically changed fromyoann/move-dev-server tomaster

March 28, 2025 16:59

yoannmoinet added5 commits

March 31, 2025 10:08

Update doc

627e847

Simplify setup

6ff010c

Update TOC

f5d2cb2

Update codeowners

0c38e12

Do not run multiple servers

ed64d1c

yoannmoinetand others added6 commits

April 4, 2025 10:59

Do not make the server fail the build

9430eb9

Add comment

fc29fed

Missing new line

0cc8f29

Update tests to better catch multiple server runs

0c1e987

Merge branch 'master' into yoann/s8s-dev-server

31c989e

wip

2706a91

Copy link

MemberAuthor

yoannmoinet commentedApr 8, 2025

Putting this on hold for now.

We'll redesign a bit the feature to have the server part running ondatadog-ci's side instead ofbuild-plugins's.

While testing withweb-ui we noticed that handling sequential builds (or parallel ones even) would be very difficult to do from thebuild-plugins's PoV.

Instead, we'll havedatadog-ci run a server andbuild-plugins register its builds and reporting its status to it by calling the server's API.