Commita4ea0fe

authored

Merge pull requestpython-gitlab#702 from jpiron/eq_hash

Implement __eq__ and __hash__ methods

2 parents57fa4e3 +3d60850 commita4ea0feCopy full SHA for a4ea0fe

File tree

+34

-1

lines changed

+34

-1

lines changed

Lines changed: 11 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -96,6 +96,16 @@ def __repr__(self):`
`96`	`96`	`else:`
`97`	`97`	`return'<%s>'%self.__class__.__name__`
`98`	`98`
	`99`	`+def__eq__(self,other):`
	`100`	`+ifself.get_id()andother.get_id():`
	`101`	`+returnself.get_id()==other.get_id()`
	`102`	`+returnsuper().__eq__(other)`
	`103`	`+`
	`104`	`+def__hash__(self):`
	`105`	`+ifnotself.get_id():`
	`106`	`+returnsuper().__hash__()`
	`107`	`+returnhash(self.get_id())`
	`108`	`+`
`99`	`109`	`def_create_managers(self):`
`100`	`110`	`managers=getattr(self,'_managers',None)`
`101`	`111`	`ifmanagersisNone:`
`@@ -112,7 +122,7 @@ def _update_attrs(self, new_attrs):`
`112`	`122`
`113`	`123`	`defget_id(self):`
`114`	`124`	`"""Returns the id of the resource."""`
`115`		`-ifself._id_attrisNone:`
	`125`	`+ifself._id_attrisNoneornothasattr(self,self._id_attr):`
`116`	`126`	`returnNone`
`117`	`127`	`returngetattr(self,self._id_attr)`
`118`	`128`

Lines changed: 23 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -134,3 +134,26 @@ class ObjectWithManager(FakeObject):`
`134`	`134`	`self.assertIsInstance(obj.fakes,FakeManager)`
`135`	`135`	`self.assertEqual(obj.fakes.gitlab,self.gitlab)`
`136`	`136`	`self.assertEqual(obj.fakes._parent,obj)`
	`137`	`+`
	`138`	`+deftest_equality(self):`
	`139`	`+obj1=FakeObject(self.manager, {'id':'foo'})`
	`140`	`+obj2=FakeObject(self.manager, {'id':'foo','other_attr':'bar'})`
	`141`	`+self.assertEqual(obj1,obj2)`
	`142`	`+`
	`143`	`+deftest_equality_custom_id(self):`
	`144`	`+classOtherFakeObject(FakeObject):`
	`145`	`+_id_attr='foo'`
	`146`	`+`
	`147`	`+obj1=OtherFakeObject(self.manager, {'foo':'bar'})`
	`148`	`+obj2=OtherFakeObject(self.manager, {'foo':'bar','other_attr':'baz'})`
	`149`	`+self.assertEqual(obj1,obj2)`
	`150`	`+`
	`151`	`+deftest_inequality(self):`
	`152`	`+obj1=FakeObject(self.manager, {'id':'foo'})`
	`153`	`+obj2=FakeObject(self.manager, {'id':'bar'})`
	`154`	`+self.assertNotEqual(obj1,obj2)`
	`155`	`+`
	`156`	`+deftest_inequality_no_id(self):`
	`157`	`+obj1=FakeObject(self.manager, {'attr1':'foo'})`
	`158`	`+obj2=FakeObject(self.manager, {'attr1':'bar'})`
	`159`	`+self.assertNotEqual(obj1,obj2)`

Comments

(0)