Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

upgrade CW packages to v2#840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
noahsaso wants to merge1 commit intodevelopment
base:development
Choose a base branch
Loading
fromcw-std-2
Draft

upgrade CW packages to v2#840

noahsaso wants to merge1 commit intodevelopmentfromcw-std-2

Conversation

@noahsaso
Copy link
Member

@noahsasonoahsaso commentedJun 17, 2024
edited
Loading

@noahsaso
Copy link
MemberAuthor

blocked onpublic-awesome/cw-nfts#160

@mintthemoon
Copy link

I'm looking into this, there's a bit of a dependency snag to resolve here -- cw-nfts actually depends on this repo, for thecw-paginate-storage package:https://github.com/public-awesome/cw-nfts/blob/v0.19.0/Cargo.toml#L28

I can't get thecw721 package to compile without updating or removing this dependency. There's only one place the package is used and it only relies on thepaginate_map_values query definedhere.

Since it's only called once and the implementation is hardly any longer than the function call, maybe the best solution is to inline it and stop relying on the package?

@noahsaso
Copy link
MemberAuthor

I'm looking into this, there's a bit of a dependency snag to resolve here -- cw-nfts actually depends on this repo, for thecw-paginate-storage package:https://github.com/public-awesome/cw-nfts/blob/v0.19.0/Cargo.toml#L28

I can't get thecw721 package to compile without updating or removing this dependency. There's only one place the package is used and it only relies on thepaginate_map_values query definedhere.

Since it's only called once and the implementation is hardly any longer than the function call, maybe the best solution is to inline it and stop relying on the package?

omg nooo, thank you for figuring this all out 🙏

i'm very down for that solution. it sounds best to me to depend on fewer packages if the reliance is so trivial.

@mintthemoon
Copy link

Actually I see they're not even using it for pagination now that I look closer at the implementation, passingNone for both bounds. So I'd say that's definitely the way to go, code is much more clear without the indirection anyways.

@noahsaso
Copy link
MemberAuthor

public-awesome/cw-nfts#160 was merged so this should be unblocked!

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@noahsaso@mintthemoon

[8]ページ先頭

©2009-2025 Movatter.jp