Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

URL Heuristics Feature#970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
eeshs wants to merge1 commit intoCycloneDX:main
base:main
Choose a base branch
Loading
fromeeshs:feature/url-map-heuristics

Conversation

@eeshs
Copy link

Extended existing label map coverage and added URL map to match PyPI heuristics.

@eeshseeshs requested a review froma team as acode ownerSeptember 19, 2025 01:23
… url map to reflect PyPI heuristicsSigned-off-by: Eesh Sahay <eesh.sahay@ufl.edu>
@eeshseeshsforce-pushed thefeature/url-map-heuristics branch fromc50992f to284c023CompareSeptember 19, 2025 01:34
@jkowalleck
Copy link
Member

where do these additions come from? are there any docs for this?

'donation':ExternalReferenceType.SOCIAL,
'donate':ExternalReferenceType.SOCIAL
}
URL_MAP= {
Copy link
Member

@jkowalleckjkowalleckSep 19, 2025•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

unused symbol?
what is it for?

@eeshs
Copy link
Author

eeshs commentedSep 19, 2025•
edited by jkowalleck
Loading

where do these additions come from? are there any docs for this?

This is in reference to issue#800 "extend project URLs -> external references", I made the additions according to the specified domains in this document that was provided under the issue here:https://docs.pypi.org/project_metadata/#icons. It was my understanding that the code needed to be updated to be able to match the specified URL labels and URLs found in the doc to their proper external reference types. Please let me know if I am misunderstanding what needs to be done.

@jkowalleckjkowalleck marked this pull request as draftSeptember 22, 2025 08:27
@jkowalleck
Copy link
Member

could you add tests for that new implementation?
test beds for the various types are here:https://github.com/CycloneDX/cyclonedx-python/tree/main/tests/_data/infiles

'repository':ExternalReferenceType.VCS,
'github':ExternalReferenceType.VCS,
'chat':ExternalReferenceType.CHAT,
'sponsor':ExternalReferenceType.SOCIAL,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"sponsor","donation", "donate" - this is an undesired category mapping to "social".
thats not whatsocial is for. seehttps://cyclonedx.org/docs/1.6/json/#externalReferences_items_type

'changelog':ExternalReferenceType.RELEASE_NOTES,
'changes':ExternalReferenceType.RELEASE_NOTES,
'releasenotes':ExternalReferenceType.RELEASE_NOTES,
'news':ExternalReferenceType.RELEASE_NOTES,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"news","whatsnew" can be anything, not only release notes - i think this is undesired

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jkowalleckjkowalleckjkowalleck requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eeshs@jkowalleck
[8]ページ先頭
©2009-2025 Movatter.jp