Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

NetworkManager package and PAM stat files fixes#14053

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
shanedell wants to merge1 commit intoComplianceAsCode:master
base:master
Choose a base branch
Loading
fromshanedell:network-manager/pam-stat/fix

Conversation

@shanedell
Copy link

NetworkManager package and PAM stat files fixes

  • Use proper NetworkManager package for ubuntu2204 and ubuntu2404.
  • Resolved issue where using the same register variable outside and inside the block was causing failures.

Description:

  • Update logic to make sure the NetworkManager package for ubuntu2204 and ubuntu2404 is being installed.
    • The updated logic makes sure that if future products useplatform_package_overrides.NetworkManager that package gets used.
  • Resolved issue where using the same register variable outside and inside the block was causing failures.

Rationale:

  • When testing the Ansible playbook for ubuntu2404 I ran into two issues:

    • The playbook was trying to install and look for the NetworkManager package calledNetworkManager, however for ubuntu2204 and ubuntu2404 the correct package name isnetwork-manager. This was noted in the product files, it just was not being overriden.
    • When only the register variable ofresult_pam_file_present was being used for both inside and outside of a block it would cause strange errors.
  • FixesNetworkManager package not overriden for ubuntu 22.04 and 24.04 #14038

@openshift-ci
Copy link

Hi@shanedell. Thanks for your PR.

I'm waiting for agithub.com member to verify that this patch is reasonable to test. If it is, they should reply with/ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors shouldjoin the org to skip this step.

Once the patch is verified, the new status will be reflected by theok-to-test label.

I understand the commands that are listedhere.

Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository.

@openshift-ciopenshift-cibot added the needs-ok-to-testUsed by openshift-ci bot. labelOct 27, 2025
@Mab879Mab879 added this to the0.1.79 milestoneOct 28, 2025
@shanedellshanedellforce-pushed thenetwork-manager/pam-stat/fix branch frome2261e7 to8faf447CompareOctober 31, 2025 17:10
@jan-cernyjan-cerny self-assigned thisNov 3, 2025
@dodysdodys requested a review froma teamNovember 3, 2025 12:34
@dodysdodys added the UbuntuUbuntu product related. labelNov 3, 2025
@dodys
Copy link
Contributor

/packit build

packit-as-a-service[bot] reacted with eyes emoji

1 similar comment
@dodys
Copy link
Contributor

/packit build

packit-as-a-service[bot] reacted with eyes emoji

Copy link
Contributor

@dodysdodys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

please check the packit failures, it seems related to your changes to some of the password rules.
Also for Ubuntu, check the bash remediation, you might want to create an Ansible specific for Ubuntu as for this rule you don't necessarily need network-manager. Not all deployed systems might have it by default.

@shanedellshanedellforce-pushed thenetwork-manager/pam-stat/fix branch 2 times, most recently fromdc7e9a5 to2e3a28fCompareNovember 5, 2025 13:35
- Use proper NetworkManager package for ubuntu2204 and ubuntu2404.- Resolved issue where using the same register variable outside and inside the block was causing failures.Signed-off-by: Shane Dell <shanedell100@gmail.com>
@shanedellshanedellforce-pushed thenetwork-manager/pam-stat/fix branch from2e3a28f to6307d3bCompareNovember 5, 2025 13:35
@shanedell
Copy link
Author

@dodys I am not sure what you are referring with the bash remediation. After building theubuntu2404 product, there is nothing dealing withNetworkManager it seems inside of the bash remediation files. Is that what you meant for me to check or something different?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@dodysdodysdodys requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@jan-cernyjan-cerny

Labels

needs-ok-to-testUsed by openshift-ci bot.UbuntuUbuntu product related.

Projects

None yet

Milestone

0.1.79

Development

Successfully merging this pull request may close these issues.

NetworkManager package not overriden for ubuntu 22.04 and 24.04

4 participants

@shanedell@dodys@Mab879@jan-cerny

[8]ページ先頭

©2009-2025 Movatter.jp