- Notifications
You must be signed in to change notification settings - Fork756
NetworkManager package and PAM stat files fixes#14053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:master
Are you sure you want to change the base?
NetworkManager package and PAM stat files fixes#14053
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Hi@shanedell. Thanks for your PR. I'm waiting for agithub.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listedhere. Instructions for interacting with me using PR comments are availablehere. If you have questions or suggestions related to my behavior, please file an issue against thekubernetes-sigs/prow repository. |
e2261e7 to8faf447Compare...em/network/network-wireless/wireless_software/wireless_disable_interfaces/ansible/shared.yml OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
/packit build |
1 similar comment
/packit build |
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
please check the packit failures, it seems related to your changes to some of the password rules.
Also for Ubuntu, check the bash remediation, you might want to create an Ansible specific for Ubuntu as for this rule you don't necessarily need network-manager. Not all deployed systems might have it by default.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
dc7e9a5 to2e3a28fCompare- Use proper NetworkManager package for ubuntu2204 and ubuntu2404.- Resolved issue where using the same register variable outside and inside the block was causing failures.Signed-off-by: Shane Dell <shanedell100@gmail.com>
2e3a28f to6307d3bCompare@dodys I am not sure what you are referring with the bash remediation. After building the |
NetworkManager package and PAM stat files fixes
Description:
platform_package_overrides.NetworkManagerthat package gets used.Rationale:
When testing the Ansible playbook for ubuntu2404 I ran into two issues:
NetworkManager, however for ubuntu2204 and ubuntu2404 the correct package name isnetwork-manager. This was noted in the product files, it just was not being overriden.result_pam_file_presentwas being used for both inside and outside of a block it would cause strange errors.FixesNetworkManager package not overriden for ubuntu 22.04 and 24.04 #14038