Baseflow/flutter_cache_managerPublic

NotificationsYou must be signed in to change notification settings
Fork488
Star805

Problem with path_provider fixed#484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

KalybosPro wants to merge11 commits intoBaseflow:main

base:main

Choose a base branch

fromKalybosPro:develop

Open

Problem with path_provider fixed#484

KalybosPro wants to merge11 commits intoBaseflow:mainfromKalybosPro:develop

Conversation

Copy link

KalybosPro commentedMar 13, 2025•
edited
Loading

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

Bug fix

⤵️ What is the current behavior?

The current behavior includes an issue caused by the path_provider package, which affects the functionality of the project.

🆕 What is the new behavior (if this is a feature change)?

The path_provider package has been removed and replaced with a custom getDirectory() function. This fixes the issue and improves the functionality.

💥 Does this PR introduce a breaking change?

No, this PR does not introduce a breaking change.

🐛 Recommendations for testing

Test the new getDirectory() function to ensure it works correctly and replaces the previous functionality of the path_provider package.

Verify that all existing features work as expected without any issues.

Run the application on different platforms to confirm compatibility.

📝 Links to relevant issues/docs

🤔 Checklist before submitting

All projects build
Follows style guide lines (code style guide)
Relevant documentation was updated
Rebased onto current develop

martijn00and others added11 commits

August 13, 2024 14:52

Update

87186d4

Fix bucket is null because of variable shadowing

584b356

Merge pull requestBaseflow#468from minhdanh/develop

3d18fcf

Fix bucket is null because of variable shadowing

Fix removeCacheFile

b2effad

Added test for removeCachedFile

9d2dbe5

Merge pull requestBaseflow#469from SmartVive/develop

515cc9e

Fix removeCacheFile

Symlink readme file

d9a4a6d

Add dart language deets

a63ce08

Merge pull requestBaseflow#474from kevmoo/symlink_readme

54904e4

path provider issue fixed

b9229b9

path_provider removed from pubspec.yaml

ba703cf

Copy link

Contributor

renefloor commentedMar 13, 2025

Actually, the sqflite author discourages to use thegetDatabasesPath and recommends to use path_provider. What's the issue with path_provider that you mention? Do you maybe have a link to a github issue?

https://github.com/tekartik/sqflite/blob/master/sqflite_common_ffi/README.md?plain=1#L163C20-L163C33

Copy link

Author

KalybosPro commentedMar 13, 2025

Actually, the sqflite author discourages to use thegetDatabasesPath and recommends to use path_provider. What's the issue with path_provider that you mention? Do you maybe have a link to a github issue?
https://github.com/tekartik/sqflite/blob/master/sqflite_common_ffi/README.md?plain=1#L163C20-L163C33

You're right, but the path_provider package is currently facing some issues and isn't working correctly with Flutter 3.29. Therefore, we can use the getDatabasesPath function for now.

Copy link

Author

KalybosPro commentedMar 13, 2025

Actually, the sqflite author discourages to use thegetDatabasesPath and recommends to use path_provider. What's the issue with path_provider that you mention? Do you maybe have a link to a github issue?
https://github.com/tekartik/sqflite/blob/master/sqflite_common_ffi/README.md?plain=1#L163C20-L163C33

We can't not wait for path_provider author to update his package. This package is used by many packages (cached_network_image for example)

Copy link

Contributor

renefloor commentedMar 13, 2025

But I still don't get what the issue is. If I look at the open issues there is no recent issue about android:https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+path_provider%22

The cached_network_image example has some outdated android project files, but if I delete them and recreate them it runs fine on Android with Flutter 3.29.0.

Can you point me to a specific issue that you have with path_provider? I wonder if you should just update your gradle files. It's also good to use java 17 instead of 21 on Android Studio.

Copy link

Author

KalybosPro commentedMar 13, 2025

But I still don't get what the issue is. If I look at the open issues there is no recent issue about android:https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+path_provider%22
The cached_network_image example has some outdated android project files, but if I delete them and recreate them it runs fine on Android with Flutter 3.29.0.
Can you point me to a specific issue that you have with path_provider? I wonder if you should just update your gradle files. It's also good to use java 17 instead of 21 on Android Studio.

I can't point you to the specific issue because the issue is not on github. I was notified by my app users that the images are not showing up. After days of looking for the cause of that issue, I found out that, the issue related to path_provider. In debug mode, everything works fine but not in release mode. The app cannot get the directories (documents, downloads, etc...)
After removing everything related to path_provider and rewrite the code, my app works fine.