Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork488
Clear cache filesystem when emptying the store cache#477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
js2702 wants to merge2 commits intoBaseflow:developChoose a base branch
base:develop
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
cedvdb commentedApr 22, 2025
@renefloor could you review this ? Can you consider adding additional maintainers ? |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)
Bug fix
When there is a desync between the filesystem and the store those files are never cleaned up, filling up the filesystem. This desync can happen because of bugs in the library like the ones listed in#476.
🆕 What is the new behavior (if this is a feature change)?
When calling
emptyCachewe can also clean up the cache directory associated to the store to clean up dangling files as well.💥 Does this PR introduce a breaking change?
It adds a method to the file system interface.
🐛 Recommendations for testing
Previously files were not deleted when calling
removeFile(), so it only affects extra dangling files in the cache store.So to test it just add an extra file and call emptyCache.�The current emptyCache test has been tweaked to account for this behavior.
🤔 Checklist before submitting