Commitaf0ccdc

and

authored

refactoring: Added parameterization to enumeration test (iluwatar#1698)

Signed-off-by: Elvys Soares <eas5@cin.ufpe.br>Co-authored-by: Subhrodip Mohanta <hello@subho.xyz>

1 parent323dd63 commitaf0ccdcCopy full SHA for af0ccdc

File tree

+16

-11

lines changed

multiton
- pom.xml
- src/test/java/com/iluwatar/multiton
  - NazgulEnumTest.java

+16

-11

lines changed

Lines changed: 5 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,6 +38,11 @@`
`38`	`38`	`<artifactId>junit-jupiter-engine</artifactId>`
`39`	`39`	`<scope>test</scope>`
`40`	`40`	`</dependency>`
	`41`	`+ <dependency>`
	`42`	`+ <groupId>org.junit.jupiter</groupId>`
	`43`	`+ <artifactId>junit-jupiter-params</artifactId>`
	`44`	`+ <scope>test</scope>`
	`45`	`+ </dependency>`
`41`	`46`	`</dependencies>`
`42`	`47`	`<build>`
`43`	`48`	`<plugins>`

Lines changed: 11 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,8 @@`
`25`	`25`
`26`	`26`	`importstaticorg.junit.jupiter.api.Assertions.assertSame;`
`27`	`27`
`28`		`-importorg.junit.jupiter.api.Test;`
	`28`	`+importorg.junit.jupiter.params.ParameterizedTest;`
	`29`	`+importorg.junit.jupiter.params.provider.EnumSource;`
`29`	`30`
`30`	`31`	`/**`
`31`	`32`	`* @author anthony`
`@@ -37,15 +38,14 @@ class NazgulEnumTest {`
`37`	`38`	`* Check that multiple calls to any one of the instances in the multiton returns`
`38`	`39`	`* only that one particular instance, and do that for all instances in multiton`
`39`	`40`	`*/`
`40`		`-@Test`
`41`		`-voidtestTheSameObjectIsReturnedWithMultipleCalls() {`
`42`		`-for (vari =0;i <NazgulEnum.values().length;i++) {`
`43`		`-varinstance1 =NazgulEnum.values()[i];`
`44`		`-varinstance2 =NazgulEnum.values()[i];`
`45`		`-varinstance3 =NazgulEnum.values()[i];`
`46`		`-assertSame(instance1,instance2);`
`47`		`-assertSame(instance1,instance3);`
`48`		`-assertSame(instance2,instance3);`
`49`		`- }`
	`41`	`+@ParameterizedTest`
	`42`	`+@EnumSource`
	`43`	`+voidtestTheSameObjectIsReturnedWithMultipleCalls(NazgulEnumnazgulEnum) {`
	`44`	`+varinstance1 =nazgulEnum;`
	`45`	`+varinstance2 =nazgulEnum;`
	`46`	`+varinstance3 =nazgulEnum;`
	`47`	`+assertSame(instance1,instance2);`
	`48`	`+assertSame(instance1,instance3);`
	`49`	`+assertSame(instance2,instance3);`
`50`	`50`	`}`
`51`	`51`	`}`

Comments

(0)