This repository was archived by the owner on Jul 19, 2024. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork237
Accessibility: Backport modal autofocus in latest insomnia version#166
Open
thgcode wants to merge1 commit intoArchGPT:mainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
None yet
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request backportsPull request 6945 on Insomnia. This pull request adds a focus scope to the modals and autofocuses it, making a screen reader (for example NVDA) moving the cursor inside of the modal and speaking its contents automatically, instead of requiring the user to guess if the modal was opened and manually moving the keyboard to it.
Tests performed:
With the code on the main branch:
NVDA does not identified the modal, requiring the user to press CTRL+HOME and space to open id, the arrow keys caused NVDA to speak other elements not related with the modal.
With the code on this pull request:
NVDA instantly started to speak the modal contents and the arrow keys worked to speak the modal elements.