generated fromfastai/nbdev_template
- Notifications
You must be signed in to change notification settings - Fork286
add hackability to use_kwargs_dict#279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Draft
marii-moe wants to merge1 commit intoAnswerDotAI:masterChoose a base branch frommarii-moe:kwargs_dcit
base:master
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Draft
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered byReviewNB |
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

To support the 'val_'+kwargs here:fastai/fastai#3133
Idea is to allow a little bit of hack-ability to
use_kwargs_dictinstead of writing specialdelegatesfunction for my one off use case. Maybe not a good idea?_wrapis reproducing the behavior indelegates, didn't want to change the default behavior ofuse_kwargs_dict, as I am not very familiar with its usage._wrapallows the stacking of multipleuse_kwargs_dictordelegateswhen keep=True, otherwise they would error when**kwargsis removed by firstdelegates`use_kwargs_dict`. (tests should make this more clear).Mostly looking for guidance here on if this makes sense, or if I should try something else. Here is example usage for easy reference: